Integrated: 8240903: Add test to check that jmod hashes are reproducible
On Fri, 25 Mar 2022 01:50:04 GMT, Dongbo He wrote: > This creates a regression test for > [JDK-8240734](https://bugs.openjdk.java.net/browse/JDK-8240734). This was > once blocked > by a time stamp issue which has been resolved by: [JDK-8276766 > ](https://bugs.openjdk.java.net/browse/JDK-8276766) > > We found the issue can be produced stably with at least 64 modules. > Note that we need to add the --date jmod option to avoid the timestamp issue. > > Testing: > Added test case fails without fix for JDK-8240734, and passes otherwise. > Tested with tier2 on linux x86. This pull request has now been integrated. Changeset: 96952834 Author:Dongbo He Committer: Fei Yang URL: https://git.openjdk.java.net/jdk/commit/9695283458c273c2a4121f88a2a971ad4f297d5b Stats: 135 lines in 1 file changed: 135 ins; 0 del; 0 mod 8240903: Add test to check that jmod hashes are reproducible Reviewed-by: alanb - PR: https://git.openjdk.java.net/jdk/pull/7948
Re: RFR: 8240903: Add test to check that jmod hashes are reproducible [v5]
On Wed, 30 Mar 2022 01:55:30 GMT, Dongbo He wrote: >> This creates a regression test for >> [JDK-8240734](https://bugs.openjdk.java.net/browse/JDK-8240734). This was >> once blocked >> by a time stamp issue which has been resolved by: [JDK-8276766 >> ](https://bugs.openjdk.java.net/browse/JDK-8276766) >> >> We found the issue can be produced stably with at least 64 modules. >> Note that we need to add the --date jmod option to avoid the timestamp issue. >> >> Testing: >> Added test case fails without fix for JDK-8240734, and passes otherwise. >> Tested with tier2 on linux x86. > > Dongbo He has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains six additional commits since > the last revision: > > - Merge branch 'master' into 8240903 > - Delete extra blank links > - Change shell test io java test > - Get date by 'date +%Y-%m-%dT%H:%M:%S%:z' > - Update Copyright > - 8240903: Add a regression test for JDK-8240734 Thank you for your review, Alan. - PR: https://git.openjdk.java.net/jdk/pull/7948
Re: RFR: 8240903: Add test to check that jmod hashes are reproducible [v5]
On Fri, 8 Apr 2022 09:26:08 GMT, Alan Bateman wrote: > I think this looks okay. Can you say how long the test runs for you? It > creates 130 JMOD files and I'm just wondering if the default timeout is > enough when running with debug builds. The following is the test result on linux x86 with 128 cores, it looks ok. time make CONF=release run-test TEST=test/jdk/tools/jmod/hashes/HashesOrderTest.java Finished building target 'run-test' in configuration 'linux-x86_64-server-release' real0m24.235s user0m52.196s sys 0m7.170s time make CONF=slowdebug run-test TEST=test/jdk/tools/jmod/hashes/HashesOrderTest.java real2m2.877s user5m58.887s sys 0m10.474s - PR: https://git.openjdk.java.net/jdk/pull/7948
Re: RFR: 8240903: Add test to check that jmod hashes are reproducible [v3]
On Fri, 25 Mar 2022 11:54:52 GMT, Alan Bateman wrote: >> Dongbo He has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Get date by 'date +%Y-%m-%dT%H:%M:%S%:z' > > The existing tests for the jmod tool are in test/jdk/tools/jmod. > HashesTest.java might provide inspiration to avoid introducing a shell test. @AlanBateman Could you please take another look? - PR: https://git.openjdk.java.net/jdk/pull/7948
Re: RFR: 8240903: Add test to check that jmod hashes are reproducible [v5]
> This creates a regression test for > [JDK-8240734](https://bugs.openjdk.java.net/browse/JDK-8240734). This was > once blocked > by a time stamp issue which has been resolved by: [JDK-8276766 > ](https://bugs.openjdk.java.net/browse/JDK-8276766) > > We found the issue can be produced stably with at least 64 modules. > Note that we need to add the --date jmod option to avoid the timestamp issue. > > Testing: > Added test case fails without fix for JDK-8240734, and passes otherwise. > Tested with tier2 on linux x86. Dongbo He has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge branch 'master' into 8240903 - Delete extra blank links - Change shell test io java test - Get date by 'date +%Y-%m-%dT%H:%M:%S%:z' - Update Copyright - 8240903: Add a regression test for JDK-8240734 - Changes: - all: https://git.openjdk.java.net/jdk/pull/7948/files - new: https://git.openjdk.java.net/jdk/pull/7948/files/6b185934..34b8008d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7948=04 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7948=03-04 Stats: 3635 lines in 166 files changed: 2489 ins; 556 del; 590 mod Patch: https://git.openjdk.java.net/jdk/pull/7948.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7948/head:pull/7948 PR: https://git.openjdk.java.net/jdk/pull/7948
Re: RFR: 8240903: Add a regression test for JDK-8240734 [v3]
On Fri, 25 Mar 2022 11:54:52 GMT, Alan Bateman wrote: > The existing tests for the jmod tool are in test/jdk/tools/jmod. > HashesTest.java might provide inspiration to avoid introducing a shell test. Hi, Alan I have rewritten this test in Java in the latest commit. - PR: https://git.openjdk.java.net/jdk/pull/7948
Re: RFR: 8240903: Add a regression test for JDK-8240734 [v4]
> This creates a regression test for > [JDK-8240734](https://bugs.openjdk.java.net/browse/JDK-8240734). This was > once blocked > by a time stamp issue which has been resolved by: [JDK-8276766 > ](https://bugs.openjdk.java.net/browse/JDK-8276766) > > We found the issue can be produced stably with at least 64 modules. > Note that we need to add the --date jmod option to avoid the timestamp issue. > > Testing: > Added test case fails without fix for JDK-8240734, and passes otherwise. > Tested with tier2 on linux x86. Dongbo He has updated the pull request incrementally with one additional commit since the last revision: Change shell test io java test - Changes: - all: https://git.openjdk.java.net/jdk/pull/7948/files - new: https://git.openjdk.java.net/jdk/pull/7948/files/aea79a40..6b185934 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7948=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7948=02-03 Stats: 279 lines in 4 files changed: 136 ins; 142 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/7948.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7948/head:pull/7948 PR: https://git.openjdk.java.net/jdk/pull/7948
Re: RFR: 8240903: Add a regression test for JDK-8240734 [v3]
> This creates a regression test for > [JDK-8240734](https://bugs.openjdk.java.net/browse/JDK-8240734). This was > once blocked > by a time stamp issue which has been resolved by: [JDK-8276766 > ](https://bugs.openjdk.java.net/browse/JDK-8276766) > > We found the issue can be produced stably with at least 64 modules. > Note that we need to add the --date jmod option to avoid the timestamp issue. > > Testing: > Added test case fails without fix for JDK-8240734, and passes otherwise. > Tested with tier2 on linux x86. Dongbo He has updated the pull request incrementally with one additional commit since the last revision: Get date by 'date +%Y-%m-%dT%H:%M:%S%:z' - Changes: - all: https://git.openjdk.java.net/jdk/pull/7948/files - new: https://git.openjdk.java.net/jdk/pull/7948/files/b2a1c843..aea79a40 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7948=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7948=01-02 Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/7948.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7948/head:pull/7948 PR: https://git.openjdk.java.net/jdk/pull/7948
Re: RFR: 8240903: Add a regression test for JDK-8240734 [v2]
> This creates a regression test for JDK-8240734. This was once blocked > by a time stamp issue which has been resolved by: [JDK-8276766 > ](https://bugs.openjdk.java.net/browse/JDK-8276766) > > We found the issue can always be produced with at least 64 modules. > Note that we need to add the --date jmod option to avoid the timestamp issue. > > Testing: > Added test case fails before JDK-8240734, and passes after JDK-8240734. > Tested with tier2 on linux x86. Dongbo He has updated the pull request incrementally with one additional commit since the last revision: Update Copyright - Changes: - all: https://git.openjdk.java.net/jdk/pull/7948/files - new: https://git.openjdk.java.net/jdk/pull/7948/files/12c35178..b2a1c843 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7948=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7948=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/7948.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7948/head:pull/7948 PR: https://git.openjdk.java.net/jdk/pull/7948
RFR: 8240903: Add a regression test for JDK-8240734
This creates a regression test for JDK-8240734. This was once blocked by a time stamp issue which has been resolved by: [JDK-8276766 ](https://bugs.openjdk.java.net/browse/JDK-8276766) We found the issue can always be produced with at least 64 modules. Note that we need to add the --date jmod option to avoid the timestamp issue. Testing: Added test case fails before JDK-8240734, and passes after JDK-8240734. Tested with tier2 on linux x86. - Commit messages: - 8240903: Add a regression test for JDK-8240734 Changes: https://git.openjdk.java.net/jdk/pull/7948/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7948=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8240903 Stats: 78 lines in 3 files changed: 75 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/7948.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7948/head:pull/7948 PR: https://git.openjdk.java.net/jdk/pull/7948
