Re: RFR [15] 8243541: (tz) Upgrade time-zone data to tzdata2020a

[Kiran Ravikumar]

Hi Martin and Andrew,


Thanks for the review and providing a direction towards updating the 
translations.



Here is an updated webrev with the changes:

http://cr.openjdk.java.net/~kravikumar/8243541/webrev/


All associated tests pass. Please let me know if they look alright.


Thanks,

Kiran

On 27/04/2020 15:16, Martin Buchholz wrote:

Hi Kiran,

Thanks for working on this update so promptly.

The innocent renaming of America/Godthab to America/Nuuk is causing 
much trouble.
Since it's a renaming, both names remain and I expected them to have 
the same metadata.
So I expected the entries in TimeZoneNames.java and the translations 
in e.g.TimeZoneNames_de.java to have parallel entries for both names.

Which is what happened with Asia/Rangoon rename to Asia/Yangon.
Consider the output of
 $ find . -type f -name '*.java' | xargs grep -E 'Asia/(Rangoon|Yangon)'

(I wish IANA would coordinate their tzdata releases with ICU CLDR 
releases, but apparently they don't)


(I help keep Google's java programs up to date with tzdata)

On Mon, Apr 27, 2020 at 4:21 AM Kiran Ravikumar 
<mailto:kiran.sidhartha.raviku...@oracle.com>> wrote:


Hello All,


Please review the patch for tzdata2020a integration into jdk.

Release details can be found here:

http://mm.icann.org/pipermail/tz-announce/2020-April/58.html

<https://urldefense.com/v3/__http://mm.icann.org/pipermail/tz-announce/2020-April/58.html__;!!GqivPVa7Brio!PGqR3RfBtyodUFrLtWqpA28agMmn_GtHHtKh8oegq3ePykB5KcxVpzelGnZjTxeLKvzw6K2xqoo$>


Webrev: http://cr.openjdk.java.net/~kravikumar/8243541/webrev.00/

Bug: https://bugs.openjdk.java.net/browse/JDK-8243541


The patch has passed all the related testing including JCK and uses
vanguard format tzdata.


Thanks,

Kiran

RFR [15] 8243541: (tz) Upgrade time-zone data to tzdata2020a

[Kiran Ravikumar]

Hello All,


Please review the patch for tzdata2020a integration into jdk.

Release details can be found here:

http://mm.icann.org/pipermail/tz-announce/2020-April/58.html


Webrev: http://cr.openjdk.java.net/~kravikumar/8243541/webrev.00/

Bug: https://bugs.openjdk.java.net/browse/JDK-8243541


The patch has passed all the related testing including JCK and uses 
vanguard format tzdata.



Thanks,

Kiran

Re: RFR [15] 8161558: ListIterator should not discard cause on exception

[Kiran Ravikumar]

Thanks Stuart and Martin,


Here is an updated webrev with the changes.

http://cr.openjdk.java.net/~kravikumar/8161558/webrev.01/

JBS: https://bugs.openjdk.java.net/browse/JDK-8161558


Thanks,

Kiran


On 15/01/2020 12:46, Martin Buchholz wrote:

Hi Kiran,

Looks good to me, but I always nitpick ...

Stray semicolon?
       var iterator = list.listIterator(list.size());; // position at end

I would have documented whitebox test assumptions: that nCopies 
iterators are implemented via AbstractList, and that 
AbstractList's list iterator inherits behavior from iterator.


I probably would have added a plain iterator test, and might have 
refactored the code that tests the exception.



On Wed, Jan 15, 2020 at 4:07 AM Kiran Ravikumar 
<mailto:kiran.sidhartha.raviku...@oracle.com>> wrote:


Hi Guys,


Could someone please review my fix to add missing standard
constructor
overloads to NoSuchElementException class and update the AbstractList
class to use them.


A CSR was filed and approved. Along with the code change a new
test is
added to verify the behavior.


Please find the webrev at  -


http://cr.openjdk.java.net/~kravikumar/8161558/webrev.00/


JBS: https://bugs.openjdk.java.net/browse/JDK-8161558


Thanks,

Kiran

RFR [15] 8161558: ListIterator should not discard cause on exception

[Kiran Ravikumar]

Hi Guys,


Could someone please review my fix to add missing standard constructor 
overloads to NoSuchElementException class and update the AbstractList 
class to use them.



A CSR was filed and approved. Along with the code change a new test is 
added to verify the behavior.



Please find the webrev at  -


http://cr.openjdk.java.net/~kravikumar/8161558/webrev.00/


JBS: https://bugs.openjdk.java.net/browse/JDK-8161558


Thanks,

Kiran

RFR 8233187: Return Empty List if 0 Copies Requested in Collections nCopies

[Kiran Ravikumar]

Hi Guys,


Please review the following optimization to nCopies method to return 
empty list and to avoid instantiating an empty CopiesList object.



JBS link : https://bugs.openjdk.java.net/browse/JDK-8233187


Patch:

diff -r f279d8a9bb78 src/java.base/share/classes/java/util/Collections.java
--- a/src/java.base/share/classes/java/util/Collections.java Wed Nov 13 
11:27:50 2019 +
+++ b/src/java.base/share/classes/java/util/Collections.java Thu Nov 14 
09:37:56 2019 +

@@ -5105,6 +5105,8 @@
 public static  List nCopies(int n, T o) {
 if (n < 0)
 throw new IllegalArgumentException("List length = " + n);
+    if (n == 0)
+    return Collections.emptyList();
 return new CopiesList<>(n, o);
 }


Thanks,

Kiran

RFR 8233731: repeated typo "fro" for "for"

[Kiran Ravikumar]

Hey Guys,

Please review the correction of a typo from 'fro' to 'for' in 
java.util.Arrays class.



Thanks,

Kiran

*Patch :*

@@ -2599,7 +2599,7 @@
  *   first array to be tested
  * @param aToIndex the index (exclusive) of the last element in the
  * first array to be tested
- * @param b the second array to be tested fro equality
+ * @param b the second array to be tested for equality
  * @param bFromIndex the index (inclusive) of the first element in the
  *   second array to be tested
  * @param bToIndex the index (exclusive) of the last element in the
@@ -2671,7 +2671,7 @@
  *   first array to be tested
  * @param aToIndex the index (exclusive) of the last element in the
  * first array to be tested
- * @param b the second array to be tested fro equality
+ * @param b the second array to be tested for equality
  * @param bFromIndex the index (inclusive) of the first element in the
  *   second array to be tested
  * @param bToIndex the index (exclusive) of the last element in the
@@ -2743,7 +2743,7 @@
  *   first array to be tested
  * @param aToIndex the index (exclusive) of the last element in the
  * first array to be tested
- * @param b the second array to be tested fro equality
+ * @param b the second array to be tested for equality
  * @param bFromIndex the index (inclusive) of the first element in the
  *   second array to be tested
  * @param bToIndex the index (exclusive) of the last element in the
@@ -2816,7 +2816,7 @@
  *   first array to be tested
  * @param aToIndex the index (exclusive) of the last element in the
  * first array to be tested
- * @param b the second array to be tested fro equality
+ * @param b the second array to be tested for equality
  * @param bFromIndex the index (inclusive) of the first element in the
  *   second array to be tested
  * @param bToIndex the index (exclusive) of the last element in the
@@ -2889,7 +2889,7 @@
  *   first array to be tested
  * @param aToIndex the index (exclusive) of the last element in the
  * first array to be tested
- * @param b the second array to be tested fro equality
+ * @param b the second array to be tested for equality
  * @param bFromIndex the index (inclusive) of the first element in the
  *   second array to be tested
  * @param bToIndex the index (exclusive) of the last element in the
@@ -2961,7 +2961,7 @@
  *   first array to be tested
  * @param aToIndex the index (exclusive) of the last element in the
  * first array to be tested
- * @param b the second array to be tested fro equality
+ * @param b the second array to be tested for equality
  * @param bFromIndex the index (inclusive) of the first element in the
  *   second array to be tested
  * @param bToIndex the index (exclusive) of the last element in the
@@ -3044,7 +3044,7 @@
  *   first array to be tested
  * @param aToIndex the index (exclusive) of the last element in the
  * first array to be tested
- * @param b the second array to be tested fro equality
+ * @param b the second array to be tested for equality
  * @param bFromIndex the index (inclusive) of the first element in the
  *   second array to be tested
  * @param bToIndex the index (exclusive) of the last element in the
@@ -3127,7 +3127,7 @@
  *   first array to be tested
  * @param aToIndex the index (exclusive) of the last element in the
  * first array to be tested
- * @param b the second array to be tested fro equality
+ * @param b the second array to be tested for equality
  * @param bFromIndex the index (inclusive) of the first element in the
  *   second array to be tested
  * @param bToIndex the index (exclusive) of the last element in the
@@ -3210,7 +3210,7 @@
  *   first array to be tested
  * @param aToIndex the index (exclusive) of the last element in the
  * first array to be tested
- * @param b the second array to be tested fro equality
+ * @param b the second array to be tested for equality
  * @param bFromIndex the index (inclusive) of the first element in the
  *   second array to be tested
  * @param bToIndex the index (exclusive) of the last element in the
@@ -3303,7 +3303,7 @@
  *   first array to be tested
  * @param aToIndex the index (exclusive) of the last element in the
  * first array to be tested
- * @param b the second 

RFR: 8232984: Upgrading Joni License version to 2.1.16

[Kiran Ravikumar]

Hi,

Please review this patch to update the joni version to 2.1.16.


JBS: https://bugs.openjdk.java.net/browse/JDK-8232984

License File: https://github.com/jruby/joni/blob/joni-2.1.16/LICENSE

Patch File:

diff -r ab4db38ed085 src/jdk.scripting.nashorn/share/legal/joni.md
--- a/src/jdk.scripting.nashorn/share/legal/joni.md Fri Nov 01 
16:16:05 2019 +0100
+++ b/src/jdk.scripting.nashorn/share/legal/joni.md Mon Nov 04 
09:57:41 2019 +

@@ -1,9 +1,9 @@
-## JRuby Joni v1.1.9
+## JRuby Joni v2.1.16

-### JRuby License
+### MIT License
 

-Jruby 2012
+Copyright (c) 2017 JRuby Team

 Permission is hereby granted, free of charge, to any person obtaining a
 copy of this software and associated documentation files (the "Software"),


Thanks,

Kiran

RFR: JDK-8231770 - Test java/util/zip/FlaterTest.java fails with -Xcheck:jni

[Kiran Ravikumar]

Hi Guys,

I am a new hire with the Oracle Java Platform Group and will be working mainly 
on JDK Update releases. Below is my first contribution. Looking forward to 
contribute more to the community.

Please review the fix:

Bug :https://bugs.openjdk.java.net/browse/JDK-8231770
Webrev :https://cr.openjdk.java.net/~coffeys/webrev.8231770/webrev/  

Explanation : Minor correction to the native code that had wrong arguments. 
Updated the corresponding test to run with -Xcheck:jni to prevent further 
occurrences of similar issue.


Thanks,
Kiran