Integrated: JDK-8276239: Better tables in java.util.random package summary
On Mon, 1 Nov 2021 17:10:56 GMT, Ludvig Janiuk wrote: > The tables are now striped, and they use row headers (which is a nice-to-have > for accessibility). This pull request has now been integrated. Changeset: d8b0dee6 Author:Ludvig Janiuk Committer: Claes Redestad URL: https://git.openjdk.java.net/jdk/commit/d8b0dee65e7e074d81eecf451542f79747ea7c78 Stats: 32 lines in 1 file changed: 0 ins; 0 del; 32 mod 8276239: Better tables in java.util.random package summary Reviewed-by: jlaskey - PR: https://git.openjdk.java.net/jdk/pull/6196
Re: RFR: JDK-8276239: Better tables in java.util.random package summary
On Mon, 1 Nov 2021 17:17:18 GMT, Jim Laskey wrote: >> The tables are now striped, and they use row headers (which is a >> nice-to-have for accessibility). > > Marked as reviewed by jlaskey (Reviewer). @JimLaskey Could I ask you to sponsor? - PR: https://git.openjdk.java.net/jdk/pull/6196
Integrated: JDK-8276653: Missing row headers in j.l.Character docs
On Thu, 4 Nov 2021 16:52:48 GMT, Ludvig Janiuk wrote: > The first table is missing row headers, adding them to aid screen readers. This pull request has now been integrated. Changeset: 8ec80c4b Author: Ludvig Janiuk Committer: Naoto Sato URL: https://git.openjdk.java.net/jdk/commit/8ec80c4bc1c3169963137b5a16a1b787540a3589 Stats: 11 lines in 1 file changed: 0 ins; 0 del; 11 mod 8276653: Missing row headers in j.l.Character docs Reviewed-by: naoto - PR: https://git.openjdk.java.net/jdk/pull/6262
Re: RFR: JDK-8276649: MethodHandles.Lookup docs: replace the table in the cross-module access check section with list
On Thu, 4 Nov 2021 17:03:54 GMT, Mandy Chung wrote: >> Inferring from the flow of the text, the table should have been a list all >> along, so I've made it that way. Before and after for comparison: >>  >>  > > That's what I suspect related to accessibility. Thanks. @mlchung Could I ask you to sponsor this change? - PR: https://git.openjdk.java.net/jdk/pull/6260
Integrated: JDK-8276652: Missing row headers in MethodHandles.Lookup docs
On Thu, 4 Nov 2021 16:41:11 GMT, Ludvig Janiuk wrote: > Added row headers missing in the table captioned "Access mode summary". This > carries no visual change, but might be useful for screen readers. This pull request has now been integrated. Changeset: 7e87f946 Author: Ludvig Janiuk Committer: Mandy Chung URL: https://git.openjdk.java.net/jdk/commit/7e87f946cedf93f19c38fd596039a16394c03ea4 Stats: 34 lines in 1 file changed: 0 ins; 0 del; 34 mod 8276652: Missing row headers in MethodHandles.Lookup docs Reviewed-by: mchung - PR: https://git.openjdk.java.net/jdk/pull/6261
Integrated: JDK-8276649: MethodHandles.Lookup docs: replace the table in the cross-module access check section with list
On Thu, 4 Nov 2021 16:18:45 GMT, Ludvig Janiuk wrote: > Inferring from the flow of the text, the table should have been a list all > along, so I've made it that way. Before and after for comparison: >  >  This pull request has now been integrated. Changeset: 99d4b07c Author:Ludvig Janiuk Committer: Mandy Chung URL: https://git.openjdk.java.net/jdk/commit/99d4b07cddec05428e4d578ba6f494f51b92e841 Stats: 34 lines in 1 file changed: 0 ins; 20 del; 14 mod 8276649: MethodHandles.Lookup docs: replace the table in the cross-module access check section with list Reviewed-by: mchung - PR: https://git.openjdk.java.net/jdk/pull/6260
Re: RFR: JDK-8276649: MethodHandles.Lookup docs: replace the table in the cross-module access check section with list
On Thu, 4 Nov 2021 16:18:45 GMT, Ludvig Janiuk wrote: > Inferring from the flow of the text, the table should have been a list all > along, so I've made it that way. Before and after for comparison: >  >  It was flagged as an accessibility issue by a scanning tool. I don't think it's going to make a world of difference, but if the tool says it's better, I suppose why not change it. Also, just feels more natural. - PR: https://git.openjdk.java.net/jdk/pull/6260
RFR: JDK-8276653: Missing row headers in j.l.Character docs
The first table is missing row headers, adding them to aid screen readers. - Commit messages: - Added row headers in Character docs Changes: https://git.openjdk.java.net/jdk/pull/6262/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6262&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276653 Stats: 11 lines in 1 file changed: 0 ins; 0 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/6262.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6262/head:pull/6262 PR: https://git.openjdk.java.net/jdk/pull/6262
RFR: JDK-8276652: Missing row headers in MethodHandles.Lookup docs
Added row headers missing in the table captioned "Access mode summary". This carries no visual change, but might be useful for screen readers. - Commit messages: - Added table headers Changes: https://git.openjdk.java.net/jdk/pull/6261/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6261&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276652 Stats: 34 lines in 1 file changed: 0 ins; 0 del; 34 mod Patch: https://git.openjdk.java.net/jdk/pull/6261.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6261/head:pull/6261 PR: https://git.openjdk.java.net/jdk/pull/6261
RFR: JDK-8276649: MethodHandles.Lookup docs: table could be list
Inferring from the flow of the text, the table should have been a list all along, so I've made it that way. Before and after for comparison:   - Commit messages: - Oops, trailing whitespace - Single column table -> list Changes: https://git.openjdk.java.net/jdk/pull/6260/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6260&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276649 Stats: 34 lines in 1 file changed: 0 ins; 20 del; 14 mod Patch: https://git.openjdk.java.net/jdk/pull/6260.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6260/head:pull/6260 PR: https://git.openjdk.java.net/jdk/pull/6260
Integrated: JDK-8276236: Table headers missing in Formatter api docs
On Mon, 1 Nov 2021 15:59:22 GMT, Ludvig Janiuk wrote: > Adds table headers to all tables in Formatter api docs. I inferred the header > "Unicode" for the columns that contained unicode > codepoints. > > Formatter api docs: > https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Formatter.html This pull request has now been integrated. Changeset: 92be9d8c Author:Ludvig Janiuk Committer: Sean Coffey URL: https://git.openjdk.java.net/jdk/commit/92be9d8c535274eea4edd06273e6d7811f6bb113 Stats: 80 lines in 1 file changed: 80 ins; 0 del; 0 mod 8276236: Table headers missing in Formatter api docs Reviewed-by: coffeys, iris - PR: https://git.openjdk.java.net/jdk/pull/6195
RFR: JDK-8276239: Better tables in java.util.random package summary
The tables are now striped, and they use row headers (which is a nice-to-have for accessibility). - Commit messages: - Striped tables and table row headers Changes: https://git.openjdk.java.net/jdk/pull/6196/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6196&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276239 Stats: 32 lines in 1 file changed: 0 ins; 0 del; 32 mod Patch: https://git.openjdk.java.net/jdk/pull/6196.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6196/head:pull/6196 PR: https://git.openjdk.java.net/jdk/pull/6196
RFR: JDK-8276236: Table headers missing in Formatter api docs
Adds table headers to all tables in Formatter api docs. I inferred the header "Unicode" for the columns that contained unicode codepoints. Formatter api docs: https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Formatter.html - Commit messages: - Fixes JDK-8276236 Changes: https://git.openjdk.java.net/jdk/pull/6195/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6195&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276236 Stats: 80 lines in 1 file changed: 80 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/6195.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6195/head:pull/6195 PR: https://git.openjdk.java.net/jdk/pull/6195
