Re: [12] RFR: 8216546: Support new Japanese era in java.lang.Character for Java SE 11

2019-01-31 Thread Chris Hegarty 



> On 31 Jan 2019, at 17:07, Naoto Sato  wrote:
> 
> Hi Chris,
> 
> Thank you for the comments. I updated the CSR and the webrev:
> 
> https://bugs.openjdk.java.net/browse/JDK-8217938
> https://cr.openjdk.java.net/~naoto/8216546/webrev.01/

Thanks Naoto. Reviewed.

-Chris

Re: [12] RFR: 8216546: Support new Japanese era in java.lang.Character for Java SE 11

2019-01-31 Thread Naoto Sato 

Hi Chris,

Thank you for the comments. I updated the CSR and the webrev:

https://bugs.openjdk.java.net/browse/JDK-8217938
https://cr.openjdk.java.net/~naoto/8216546/webrev.01/

Naoto

On 1/31/19 1:15 AM, Chris Hegarty wrote:

Naoto,


On 31 Jan 2019, at 00:35, naoto.s...@oracle.com wrote:

...

https://bugs.openjdk.java.net/browse/JDK-8217938
http://cr.openjdk.java.net/~naoto/8216546/webrev.00/


This looks good. Just a few very minor comments.

1) To be consistent can you please include the addition of the
   word ‘conditions’ to the following methods:

 “... the following *conditions* is true:"

  isJavaIdentifierPart(char ch)
  isJavaIdentifierPart(int codePoint)
  isJavaLetter(char ch)
  isJavaIdentifierPart(char)

2)  There was a small correction in isJavaIdentifierPart(int).

 Replace"the character"  with   "the code point"

Thanks,
-Chris.

Re: [12] RFR: 8216546: Support new Japanese era in java.lang.Character for Java SE 11

2019-01-31 Thread Chris Hegarty 
Naoto,

> On 31 Jan 2019, at 00:35, naoto.s...@oracle.com wrote:
> 
> ...
> 
> https://bugs.openjdk.java.net/browse/JDK-8217938
> http://cr.openjdk.java.net/~naoto/8216546/webrev.00/

This looks good. Just a few very minor comments.

1) To be consistent can you please include the addition of the
  word ‘conditions’ to the following methods:

“... the following *conditions* is true:"

 isJavaIdentifierPart(char ch)
 isJavaIdentifierPart(int codePoint) 
 isJavaLetter(char ch) 
 isJavaIdentifierPart(char)

2)  There was a small correction in isJavaIdentifierPart(int). 

Replace"the character"  with   "the code point"

Thanks,
-Chris.

[12] RFR: 8216546: Support new Japanese era in java.lang.Character for Java SE 11

2019-01-30 Thread naoto . sato 

Hi,

Please review the javadoc fix for the following issue:

https://bugs.openjdk.java.net/browse/JDK-8216546

The CSR and the proposed changeset are located at:

https://bugs.openjdk.java.net/browse/JDK-8217938
http://cr.openjdk.java.net/~naoto/8216546/webrev.00/

This is a forward poring of the fix made in 11u release:
https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/c1e1669edace

The changeset has been modified from the original 11u one, in order to 
mandate the Japanese Era code point in all Java SE 12 implementations.


Naoto