Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

2020-04-23 Thread Chris Yin 
Thank you, Vyom

Regards,
Chris

> On 23 Apr 2020, at 4:35 PM, Vyom Tiwari  wrote:
> 
> Hi Chris,
> change looks good to me.
> Vyom
> 
> On Wed, Apr 22, 2020 at 12:59 PM Chris Yin  > wrote:
> Hello
> 
> Please review following change for enhancement to 
> com/sun/jndi/ldap/lib/BaseLdapServer.java, thanks
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8243138 
> 
> Webrev: http://cr.openjdk.java.net/~xyin/8243138/webrev.00/ 
> 
> 
> There is requirement to test starttls extended op against dummy ldap server, 
> but unfortunately, current BaseLdapSever logic cannot handle it correctly 
> since the starttls request is quite special to use existed socket for tls 
> negotiate. This enhancement will provide the possibility to wrap current 
> socket connection and overwrite in-place processing input/output stream, 
> certainly, that will not affect existed tests which depends on 
> BaseLdapServer. Run existed dependency tests on 4 platforms for total 200 
> times, all green.
> 
> Thanks,
> Chris
> 
> 
> -- 
> Thanks,
> Vyom

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

2020-04-23 Thread Chris Yin 
Thank you, Daniel. Pushed

Regards,
Chris

> On 23 Apr 2020, at 4:11 PM, Daniel Fuchs  wrote:
> 
> On 23/04/2020 01:39, Aleks Efimov wrote:
>> Hi Chris,
>> The changes look good to me.
>> Thank you for extending the LDAP test server functionality.
> 
> +1
> 
> Reviewed.
> 
> best regards,
> 
> -- daniel
>

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

2020-04-23 Thread Vyom Tiwari 
Hi Chris,
change looks good to me.
Vyom

On Wed, Apr 22, 2020 at 12:59 PM Chris Yin  wrote:

> Hello
>
> Please review following change for enhancement to
> com/sun/jndi/ldap/lib/BaseLdapServer.java, thanks
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8243138
> Webrev: http://cr.openjdk.java.net/~xyin/8243138/webrev.00/
>
> There is requirement to test starttls extended op against dummy ldap
> server, but unfortunately, current BaseLdapSever logic cannot handle it
> correctly since the starttls request is quite special to use existed socket
> for tls negotiate. This enhancement will provide the possibility to wrap
> current socket connection and overwrite in-place processing input/output
> stream, certainly, that will not affect existed tests which depends on
> BaseLdapServer. Run existed dependency tests on 4 platforms for total 200
> times, all green.
>
> Thanks,
> Chris



-- 
Thanks,
Vyom

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

2020-04-23 Thread Daniel Fuchs 

On 23/04/2020 01:39, Aleks Efimov wrote:

Hi Chris,

The changes look good to me.
Thank you for extending the LDAP test server functionality.


+1

Reviewed.

best regards,

-- daniel

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

2020-04-22 Thread Chris Yin 
Thank you for reviewing, Aleksei

Regards,
Chris

> On 23 Apr 2020, at 8:39 AM, Aleks Efimov  wrote:
> 
> Hi Chris,
> 
> The changes look good to me.
> Thank you for extending the LDAP test server functionality.
> 
> With Best Regards,
> Aleksei
> 
> On 22/04/2020 08:27, Chris Yin wrote:
>> Hello
>> 
>> Please review following change for enhancement to 
>> com/sun/jndi/ldap/lib/BaseLdapServer.java, thanks
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8243138
>> Webrev: http://cr.openjdk.java.net/~xyin/8243138/webrev.00/
>> 
>> There is requirement to test starttls extended op against dummy ldap server, 
>> but unfortunately, current BaseLdapSever logic cannot handle it correctly 
>> since the starttls request is quite special to use existed socket for tls 
>> negotiate. This enhancement will provide the possibility to wrap current 
>> socket connection and overwrite in-place processing input/output stream, 
>> certainly, that will not affect existed tests which depends on 
>> BaseLdapServer. Run existed dependency tests on 4 platforms for total 200 
>> times, all green.
>> 
>> Thanks,
>> Chris
>

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

2020-04-22 Thread Aleks Efimov 

Hi Chris,

The changes look good to me.
Thank you for extending the LDAP test server functionality.

With Best Regards,
Aleksei

On 22/04/2020 08:27, Chris Yin wrote:

Hello

Please review following change for enhancement to 
com/sun/jndi/ldap/lib/BaseLdapServer.java, thanks

Bug: https://bugs.openjdk.java.net/browse/JDK-8243138
Webrev: http://cr.openjdk.java.net/~xyin/8243138/webrev.00/

There is requirement to test starttls extended op against dummy ldap server, 
but unfortunately, current BaseLdapSever logic cannot handle it correctly since 
the starttls request is quite special to use existed socket for tls negotiate. 
This enhancement will provide the possibility to wrap current socket connection 
and overwrite in-place processing input/output stream, certainly, that will not 
affect existed tests which depends on BaseLdapServer. Run existed dependency 
tests on 4 platforms for total 200 times, all green.

Thanks,
Chris

[15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

2020-04-22 Thread Chris Yin 
Hello

Please review following change for enhancement to 
com/sun/jndi/ldap/lib/BaseLdapServer.java, thanks

Bug: https://bugs.openjdk.java.net/browse/JDK-8243138
Webrev: http://cr.openjdk.java.net/~xyin/8243138/webrev.00/

There is requirement to test starttls extended op against dummy ldap server, 
but unfortunately, current BaseLdapSever logic cannot handle it correctly since 
the starttls request is quite special to use existed socket for tls negotiate. 
This enhancement will provide the possibility to wrap current socket connection 
and overwrite in-place processing input/output stream, certainly, that will not 
affect existed tests which depends on BaseLdapServer. Run existed dependency 
tests on 4 platforms for total 200 times, all green.

Thanks,
Chris