Re: [9] RFR (S): 8038261: JSR292: cache and reuse typed array accessors
I'd like to revive review this review thread.
Updated version:
http://cr.openjdk.java.net/~vlivanov/8038261/webrev.03/
Thanks!
Best regards,
Vladimir Ivanov
On 3/24/14 10:10 PM, Vladimir Ivanov wrote:
http://cr.openjdk.java.net/~vlivanov/8038261/webrev.00
https://bugs.openjdk.java.net/browse/JDK-8038261
56 lines changed: 26 ins; 14 del; 16 mod
Cache typed array element getters/setters and reuse them.
Initially, it was part of 8037209, but I decided to integrate it
separately.
Contributed-by: john.r.r...@oracle.com
Testing: jdk/java/{lang/invoke,util}, vm.mlvm.testlist, nashorn, jruby
Configs: -ea -esa -Xverify:all -D...COMPILE_THRESHOLD={0,30}
Best regards,
Vladimir Ivanov
Re: [9] RFR (S): 8038261: JSR292: cache and reuse typed array accessors
On Jul 8, 2014, at 12:09 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com wrote: I'd like to revive review this review thread. Updated version: http://cr.openjdk.java.net/~vlivanov/8038261/webrev.03/ +1 Paul.
Re: [9] RFR (S): 8038261: JSR292: cache and reuse typed array accessors
On Jul 8, 2014, at 12:40 PM, Paul Sandoz paul.san...@oracle.com wrote: On Jul 8, 2014, at 12:09 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com wrote: I'd like to revive review this review thread. Updated version: http://cr.openjdk.java.net/~vlivanov/8038261/webrev.03/ +1 A v. minor point. There is one newly added method InvokerBytecodeGenerator.match that is not used by this patch or the other one for 8037209. I dunno if it will be used later or not by a future patch. Paul.
Re: [9] RFR (S): 8038261: JSR292: cache and reuse typed array accessors
I'd like to revive review this review thread. Updated version: http://cr.openjdk.java.net/~vlivanov/8038261/webrev.03/ +1 A v. minor point. There is one newly added method InvokerBytecodeGenerator.match that is not used by this patch or the other one for 8037209. I dunno if it will be used later or not by a future patch. Good catch! It's a leftover from one of recent cleanups I did. Will remove it. Thanks for the prompt review! Best regards, Vladimir Ivanov
[9] RFR (S): 8038261: JSR292: cache and reuse typed array accessors
http://cr.openjdk.java.net/~vlivanov/8038261/webrev.00
https://bugs.openjdk.java.net/browse/JDK-8038261
56 lines changed: 26 ins; 14 del; 16 mod
Cache typed array element getters/setters and reuse them.
Initially, it was part of 8037209, but I decided to integrate it
separately.
Contributed-by: john.r.r...@oracle.com
Testing: jdk/java/{lang/invoke,util}, vm.mlvm.testlist, nashorn, jruby
Configs: -ea -esa -Xverify:all -D...COMPILE_THRESHOLD={0,30}
Best regards,
Vladimir Ivanov
