Re: [9] RFR JDK-8153564: Add java/nio/Buffer/BasicByte.java to exclude list until JDK-8153563 is fixed
It was late for me, so Amy took over and fixed it Thanks Alejandro On 4/6/2016 1:36 AM, Alan Bateman wrote: On 06/04/2016 06:14, Alejandro Murillo wrote: I'd like to push the changeset below to exclude java/nio/Buffer/BasicByte.java It started failing after the hotspot snapshot was pushed to jdk9/dev tonight. https://bugs.openjdk.java.net/browse/JDK-8153563 has been filed for that failure. Would it be possible to add @modules java.base/jdk.internal.misc, as below, and not exclude these tests? -Alan $ hg diff -g . diff --git a/test/java/nio/Buffer/Basic.java b/test/java/nio/Buffer/Basic.java --- a/test/java/nio/Buffer/Basic.java +++ b/test/java/nio/Buffer/Basic.java @@ -22,6 +22,7 @@ */ /* @test + * @modules java.base/jdk.internal.misc * @summary Unit test for buffers * @bug 4413135 4414911 4416536 4416562 4418782 4471053 4472779 4490253 4523725 * 4526177 4463011 4660660 4661219 4663521 4782970 4804304 4938424 6231529 diff --git a/test/java/nio/Buffer/CopyDirectMemory.java b/test/java/nio/Buffer/CopyDirectMemory.java --- a/test/java/nio/Buffer/CopyDirectMemory.java +++ b/test/java/nio/Buffer/CopyDirectMemory.java @@ -25,6 +25,7 @@ * @summary Test view buffer bulk operations for large buffers. * @bug 4463011 * + * @modules java.base/jdk.internal.misc * @build Basic * @run main CopyDirectMemory */ -- Alejandro
Re: [9] RFR JDK-8153564: Add java/nio/Buffer/BasicByte.java to exclude list until JDK-8153563 is fixed
On 06/04/2016 06:14, Alejandro Murillo wrote: I'd like to push the changeset below to exclude java/nio/Buffer/BasicByte.java It started failing after the hotspot snapshot was pushed to jdk9/dev tonight. https://bugs.openjdk.java.net/browse/JDK-8153563 has been filed for that failure. Would it be possible to add @modules java.base/jdk.internal.misc, as below, and not exclude these tests? -Alan $ hg diff -g . diff --git a/test/java/nio/Buffer/Basic.java b/test/java/nio/Buffer/Basic.java --- a/test/java/nio/Buffer/Basic.java +++ b/test/java/nio/Buffer/Basic.java @@ -22,6 +22,7 @@ */ /* @test + * @modules java.base/jdk.internal.misc * @summary Unit test for buffers * @bug 4413135 4414911 4416536 4416562 4418782 4471053 4472779 4490253 4523725 * 4526177 4463011 4660660 4661219 4663521 4782970 4804304 4938424 6231529 diff --git a/test/java/nio/Buffer/CopyDirectMemory.java b/test/java/nio/Buffer/CopyDirectMemory.java --- a/test/java/nio/Buffer/CopyDirectMemory.java +++ b/test/java/nio/Buffer/CopyDirectMemory.java @@ -25,6 +25,7 @@ * @summary Test view buffer bulk operations for large buffers. * @bug 4463011 * + * @modules java.base/jdk.internal.misc * @build Basic * @run main CopyDirectMemory */
Re: [9] RFR JDK-8153564: Add java/nio/Buffer/BasicByte.java to exclude list until JDK-8153563 is fixed
I didn't see that one failing on my jprt sanity job I went to check the code CopyDirectMemory.java, and it doesn't use jdk.internal.misc.Unsafe (at least directly), so doesn't look like it's the same issue. where did you see the failure ? Alejandro On 4/5/2016 11:59 PM, Amy Lu wrote: java/nio/Buffer/CopyDirectMemory.java run into the same issue, maybe it could be problem listed together in this patch? Thanks, Amy On 4/6/16 1:14 PM, Alejandro Murillo wrote: I'd like to push the changeset below to exclude java/nio/Buffer/BasicByte.java It started failing after the hotspot snapshot was pushed to jdk9/dev tonight. https://bugs.openjdk.java.net/browse/JDK-8153563 has been filed for that failure. $ hg -R jdk9.dev/jdk tip -pv changeset: 14082:5c98c9ad8ff2 tag: tip user:amurillo date:Tue Apr 05 22:06:15 2016 -0700 files: test/ProblemList.txt description: 8153564: Add java/nio/Buffer/BasicByte.java to exclude list until JDK-8153563 is fixed Reviewed-by: tbd diff -r 04f56d4ca167 -r 5c98c9ad8ff2 test/ProblemList.txt --- a/test/ProblemList.txt Tue Apr 05 20:02:21 2016 -0700 +++ b/test/ProblemList.txt Tue Apr 05 22:06:15 2016 -0700 @@ -185,6 +185,8 @@ java/nio/charset/coders/BashStreams.java 8149712 generic-all +java/nio/Buffer/BasicByte.java 8153563 generic-all + # jdk_rmi -- Alejandro
Re: [9] RFR JDK-8153564: Add java/nio/Buffer/BasicByte.java to exclude list until JDK-8153563 is fixed
java/nio/Buffer/CopyDirectMemory.java run into the same issue, maybe it could be problem listed together in this patch? Thanks, Amy On 4/6/16 1:14 PM, Alejandro Murillo wrote: I'd like to push the changeset below to exclude java/nio/Buffer/BasicByte.java It started failing after the hotspot snapshot was pushed to jdk9/dev tonight. https://bugs.openjdk.java.net/browse/JDK-8153563 has been filed for that failure. $ hg -R jdk9.dev/jdk tip -pv changeset: 14082:5c98c9ad8ff2 tag: tip user:amurillo date:Tue Apr 05 22:06:15 2016 -0700 files: test/ProblemList.txt description: 8153564: Add java/nio/Buffer/BasicByte.java to exclude list until JDK-8153563 is fixed Reviewed-by: tbd diff -r 04f56d4ca167 -r 5c98c9ad8ff2 test/ProblemList.txt --- a/test/ProblemList.txt Tue Apr 05 20:02:21 2016 -0700 +++ b/test/ProblemList.txt Tue Apr 05 22:06:15 2016 -0700 @@ -185,6 +185,8 @@ java/nio/charset/coders/BashStreams.java 8149712 generic-all +java/nio/Buffer/BasicByte.java 8153563 generic-all + # jdk_rmi
[9] RFR JDK-8153564: Add java/nio/Buffer/BasicByte.java to exclude list until JDK-8153563 is fixed
I'd like to push the changeset below to exclude java/nio/Buffer/BasicByte.java It started failing after the hotspot snapshot was pushed to jdk9/dev tonight. https://bugs.openjdk.java.net/browse/JDK-8153563 has been filed for that failure. $ hg -R jdk9.dev/jdk tip -pv changeset: 14082:5c98c9ad8ff2 tag: tip user:amurillo date:Tue Apr 05 22:06:15 2016 -0700 files: test/ProblemList.txt description: 8153564: Add java/nio/Buffer/BasicByte.java to exclude list until JDK-8153563 is fixed Reviewed-by: tbd diff -r 04f56d4ca167 -r 5c98c9ad8ff2 test/ProblemList.txt --- a/test/ProblemList.txt Tue Apr 05 20:02:21 2016 -0700 +++ b/test/ProblemList.txt Tue Apr 05 22:06:15 2016 -0700 @@ -185,6 +185,8 @@ java/nio/charset/coders/BashStreams.java 8149712 generic-all +java/nio/Buffer/BasicByte.java 8153563 generic-all + # jdk_rmi -- Alejandro