Re: [jdk17] RFR: JDK-8268826: Cleanup Override in Context-Specific Deserialization Filters [v6]
On Fri, 25 Jun 2021 16:48:45 GMT, Brent Christian wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update logging of faults in jdk.serialFilterFactory to log only the
>> exception message
>> Simplify the logging.properties to only the needed settings
>
> test/jdk/java/io/Serializable/serialFilter/SerialFilterFunctionTest.java line
> 49:
>
>> 47: // Enable logging
>> 48: System.setProperty("java.util.logging.config.file",
>> 49: System.getProperty("test.src", ".") +
>> "/logging.properties");
>
> Is `System.setProperty()` needed if it's already being set with -D ?
Fooey; belt and suspenders not needed here.
In some cases, I used the static initializer to avoid adding command line
arguments that would
obscure the command line arguments being tested.
In this case, the log may be interesting for debugging but not integral to the
test correctness.
-
PR: https://git.openjdk.java.net/jdk17/pull/85
Re: [jdk17] RFR: JDK-8268826: Cleanup Override in Context-Specific Deserialization Filters [v6]
On Fri, 25 Jun 2021 14:54:45 GMT, Roger Riggs wrote:
>> Remove the unnecessary special case "OVERRIDE" in jdk.serialFilterFactory
>> property.
>> Fix description in the example of a filter allowing platform classes.
>> Suppress some warnings about use of SecurityManager in tests.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update logging of faults in jdk.serialFilterFactory to log only the
> exception message
> Simplify the logging.properties to only the needed settings
Marked as reviewed by bchristi (Reviewer).
test/jdk/java/io/Serializable/serialFilter/SerialFilterFunctionTest.java line
49:
> 47: // Enable logging
> 48: System.setProperty("java.util.logging.config.file",
> 49: System.getProperty("test.src", ".") +
> "/logging.properties");
Is `System.setProperty()` needed if it's already being set with -D ?
-
PR: https://git.openjdk.java.net/jdk17/pull/85
Re: [jdk17] RFR: JDK-8268826: Cleanup Override in Context-Specific Deserialization Filters [v6]
On Fri, 25 Jun 2021 14:54:45 GMT, Roger Riggs wrote: >> Remove the unnecessary special case "OVERRIDE" in jdk.serialFilterFactory >> property. >> Fix description in the example of a filter allowing platform classes. >> Suppress some warnings about use of SecurityManager in tests. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Update logging of faults in jdk.serialFilterFactory to log only the > exception message > Simplify the logging.properties to only the needed settings Marked as reviewed by dfuchs (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/85
Re: [jdk17] RFR: JDK-8268826: Cleanup Override in Context-Specific Deserialization Filters [v6]
> Remove the unnecessary special case "OVERRIDE" in jdk.serialFilterFactory > property. > Fix description in the example of a filter allowing platform classes. > Suppress some warnings about use of SecurityManager in tests. Roger Riggs has updated the pull request incrementally with one additional commit since the last revision: Update logging of faults in jdk.serialFilterFactory to log only the exception message Simplify the logging.properties to only the needed settings - Changes: - all: https://git.openjdk.java.net/jdk17/pull/85/files - new: https://git.openjdk.java.net/jdk17/pull/85/files/89df22e7..ca66a7b4 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17=85=05 - incr: https://webrevs.openjdk.java.net/?repo=jdk17=85=04-05 Stats: 69 lines in 2 files changed: 0 ins; 65 del; 4 mod Patch: https://git.openjdk.java.net/jdk17/pull/85.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/85/head:pull/85 PR: https://git.openjdk.java.net/jdk17/pull/85
