On Fri, 11 Sep 2020 14:17:45 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review and a sponsor for this patch which fixes the issue > reported in > https://bugs.openjdk.java.net/browse/JDK-8244706? > The commit here sets the `OS` header flag to `255` (which represents > `unknown`) as noted in [1]. A new test has been > included in this commit to verify the change. Furthermore, this doesn't > impact the `java.util.zip.GZIPInputStream` > since it ignores [2] this header value while reading the headers from the > stream. [1] > https://tools.ietf.org/html/rfc1952#page-7 [2] > https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/zip/GZIPInputStream.java#L173 This pull request has now been integrated. Changeset: e5866aa7 Author: Jaikiran Pai <j...@openjdk.org> Committer: Lance Andersen <lan...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/e5866aa7 Stats: 79 lines in 2 files changed: 0 ins; 77 del; 2 mod 8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance) Reviewed-by: lancea, bchristi ------------- PR: https://git.openjdk.java.net/jdk/pull/130
