RE: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail
Done: http://hg.openjdk.java.net/jdk/jdk/rev/4cfa5f51eafa From: Steve Groeger Sent: Montag, 28. Januar 2019 17:25 To: Langer, Christoph Cc: core-libs-dev@openjdk.java.net; Roger Riggs Subject: RE: JDK-821 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail Hi Christoph, Additional changes look OK to me. Happy for for you to push. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groe...@uk.ibm.com<mailto:groe...@uk.ibm.com> Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From:"Langer, Christoph" mailto:christoph.lan...@sap.com>> To:Steve Groeger mailto:groe...@uk.ibm.com>>, Roger Riggs mailto:roger.ri...@oracle.com>> Cc: "core-libs-dev@openjdk.java.net<mailto:core-libs-dev@openjdk.java.net>" mailto:core-libs-dev@openjdk.java.net>> Date: 28/01/2019 15:49 Subject:RE: JDK-821 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail Hi Steve, Roger, I made some additional cleanups in the test (Declare constants final, formatting, nice up error output...) This is what ran through our test system without issues: http://cr.openjdk.java.net/~clanger/webrevs/821.0/ In case there was an error in the output, it would read like this: --System.out:(39/1030)-- Preferences::exportSubtree did not yield the expected result. Actual: http://java.sun.com/dtd/preferences.dtd;> Expected: http://java.sun.com/dtd/preferences.dtd;> d Are you all ok with that? Then I'd push it... Thanks Christoph > -Original Message- > From: core-libs-dev > mailto:core-libs-dev-boun...@openjdk.java.net>> > On Behalf > Of Roger Riggs > Sent: Freitag, 25. Januar 2019 17:52 > To: Steve Groeger mailto:groe...@uk.ibm.com>> > Cc: core-libs-dev@openjdk.java.net<mailto:core-libs-dev@openjdk.java.net> > Subject: Re: JDK-821 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java > passes even when test should fail > > +1, > > Thanks, Roger > > > On 01/25/2019 11:21 AM, Steve Groeger wrote: > > Hi Roger, > > > > Thanks. Have included the bug number to the @bug line and have > > included the expected and actual output when there is an error. > > > > Have generated a new webrev here: > > http://cr.openjdk.java.net/~sgroeger/821/webrev.01/ > > <http://cr.openjdk.java.net/%7Esgroeger/821/webrev.01/> > > > > Hope this is now OK. > > > > Thanks > > Steve Groeger > > IBM Runtime Technologies > > Hursley, Winchester > > Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 > > Fax (44) 1962 816800 > > Lotus Notes: Steve Groeger/UK/IBM > > Internet: groe...@uk.ibm.com<mailto:groe...@uk.ibm.com> > > > > Unless stated otherwise above: > > IBM United Kingdom Limited - Registered in England and Wales with > > number 741598. > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 > > 3AU > > > > > > > > From: Roger Riggs mailto:roger.ri...@oracle.com>> > > To: core-libs-dev@openjdk.java.net<mailto:core-libs-dev@openjdk.java.net> > > Date: 25/01/2019 15:30 > > Subject: Re: JDK-821 TEST_BUG: > > jdk/java/util/prefs/ExportSubtree.java passes even when test should fail > > Sent by: "core-libs-dev" > > mailto:core-libs-dev-boun...@openjdk.java.net>> > > > > > > > > > > Hi Steve, > > > > Add 821 to the @bug line; it helps track and run tests that fixed > > bugs (jtreg -bug:821) > > > > +1 printing the expected and actual (when a failure occurs). > > > > Looks fine overall. > > > > Thanks, Roger > > > > > > > > On 01/25/2019 09:57 AM, Steve Groeger wrote: > > > Hi Christoph, > > > > > > Thanks for looking at this. > > > > > > These lines > > > > > > 43 //System.out.print(baos.toString()); > > > 44 //System.out.print(expectedResult); > > > > > > were commented out in the current code but if you think displaying this > > > info would be good then
RE: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail
Hi Christoph, Additional changes look OK to me. Happy for for you to push. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groe...@uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: "Langer, Christoph" To: Steve Groeger , Roger Riggs Cc: "core-libs-dev@openjdk.java.net" Date: 28/01/2019 15:49 Subject: RE: JDK-821 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail Hi Steve, Roger, I made some additional cleanups in the test (Declare constants final, formatting, nice up error output...) This is what ran through our test system without issues: https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Eclanger_webrevs_821.0_=DwIFAw=jf_iaSHvJObTbx-siA1ZOg=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA=Wsc1SgpzRruLlitHKWYS8yqAycO5xt7qqN9bCvVCySc=-D-v0BJbhRMiCOHVFbZuV0K-O9dQfaUZfKDXpVtOFmE= In case there was an error in the output, it would read like this: --System.out:(39/1030)-- Preferences::exportSubtree did not yield the expected result. Actual: https://urldefense.proofpoint.com/v2/url?u=http-3A__java.sun.com_dtd_preferences.dtd=DwIFAw=jf_iaSHvJObTbx-siA1ZOg=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA=Wsc1SgpzRruLlitHKWYS8yqAycO5xt7qqN9bCvVCySc=bY1bNaOaLs6qyiWKdanpoI3RIgdoBdkgbEfvpm5OTTE= "> Expected: https://urldefense.proofpoint.com/v2/url?u=http-3A__java.sun.com_dtd_preferences.dtd=DwIFAw=jf_iaSHvJObTbx-siA1ZOg=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA=Wsc1SgpzRruLlitHKWYS8yqAycO5xt7qqN9bCvVCySc=bY1bNaOaLs6qyiWKdanpoI3RIgdoBdkgbEfvpm5OTTE= "> d Are you all ok with that? Then I'd push it... Thanks Christoph > -Original Message- > From: core-libs-dev On Behalf > Of Roger Riggs > Sent: Freitag, 25. Januar 2019 17:52 > To: Steve Groeger > Cc: core-libs-dev@openjdk.java.net > Subject: Re: JDK-821 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java > passes even when test should fail > > +1, > > Thanks, Roger > > > On 01/25/2019 11:21 AM, Steve Groeger wrote: > > Hi Roger, > > > > Thanks. Have included the bug number to the @bug line and have > > included the expected and actual output when there is an error. > > > > Have generated a new webrev here: > > https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Esgroeger_821_webrev.01_=DwIFAw=jf_iaSHvJObTbx-siA1ZOg=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA=Wsc1SgpzRruLlitHKWYS8yqAycO5xt7qqN9bCvVCySc=HNzeDwTU54Elbh8Xur8QRRGewTWgcTLQbtCW9nU4A7M= > > < https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-257Esgroeger_821_webrev.01_=DwIFAw=jf_iaSHvJObTbx-siA1ZOg=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA=Wsc1SgpzRruLlitHKWYS8yqAycO5xt7qqN9bCvVCySc=A-gmLJCRSPC1xqUfEIvACidaaGaQiYlARpNTAbV0UPs= > > > > > Hope this is now OK. > > > > Thanks > > Steve Groeger > > IBM Runtime Technologies > > Hursley, Winchester > > Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 > > Fax (44) 1962 816800 > > Lotus Notes: Steve Groeger/UK/IBM > > Internet: groe...@uk.ibm.com > > > > Unless stated otherwise above: > > IBM United Kingdom Limited - Registered in England and Wales with > > number 741598. > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 > > 3AU > > > > > > > > From: Roger Riggs > > To: core-libs-dev@openjdk.java.net > > Date: 25/01/2019 15:30 > > Subject: Re: JDK-821 TEST_BUG: > > jdk/java/util/prefs/ExportSubtree.java passes even when test should fail > > Sent by: "core-libs-dev" > > > > > > > > > > Hi Steve, > > > > Add 821 to the @bug line; it helps track and run tests that fixed > > bugs (jtreg -bug:821) > > > > +1 printing the expected and actual (when a failure occurs). > > > > Looks fine overall. > > > > Thanks, Roger > > > > > > > > On 01/25/2019 09:57 AM, Steve Groeger wrote: > > > Hi Christoph, > > > > > > Thanks for looking at this. > > > > > > These lines > > > > > > 43 //System.out.print(baos.toString()); > > >
Re: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail
Looks good, Thanks, Roger On 01/28/2019 10:49 AM, Langer, Christoph wrote: Hi Steve, Roger, I made some additional cleanups in the test (Declare constants final, formatting, nice up error output...) This is what ran through our test system without issues: http://cr.openjdk.java.net/~clanger/webrevs/821.0/ In case there was an error in the output, it would read like this: --System.out:(39/1030)-- Preferences::exportSubtree did not yield the expected result. Actual: http://java.sun.com/dtd/preferences.dtd;> Expected: http://java.sun.com/dtd/preferences.dtd;> d Are you all ok with that? Then I'd push it... Thanks Christoph -Original Message- From: core-libs-dev On Behalf Of Roger Riggs Sent: Freitag, 25. Januar 2019 17:52 To: Steve Groeger Cc: core-libs-dev@openjdk.java.net Subject: Re: JDK-821 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail +1, Thanks, Roger On 01/25/2019 11:21 AM, Steve Groeger wrote: Hi Roger, Thanks. Have included the bug number to the @bug line and have included the expected and actual output when there is an error. Have generated a new webrev here: http://cr.openjdk.java.net/~sgroeger/821/webrev.01/ <http://cr.openjdk.java.net/%7Esgroeger/821/webrev.01/> Hope this is now OK. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groe...@uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: Roger Riggs To: core-libs-dev@openjdk.java.net Date: 25/01/2019 15:30 Subject: Re: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail Sent by: "core-libs-dev" Hi Steve, Add 821 to the @bug line; it helps track and run tests that fixed bugs (jtreg -bug:821) +1 printing the expected and actual (when a failure occurs). Looks fine overall. Thanks, Roger On 01/25/2019 09:57 AM, Steve Groeger wrote: Hi Christoph, Thanks for looking at this. These lines 43 //System.out.print(baos.toString()); 44 //System.out.print(expectedResult); were commented out in the current code but if you think displaying this info would be good then I can un-comment them. I think only fixing this in the jdk (JDK13) branch is OK. If it is later determined that this is really needed in jdk12 or jdk11u , then I can always request a backport. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groe...@uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: "Langer, Christoph" To: Steve Groeger Cc: core-libs Date: 25/01/2019 14:30 Subject: RE: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail Hi Steve, in general this change looks reasonable to me. I think in case there is an error, it would be useful to get a printout of the expected/vs actual strings like these lines: 43 //System.out.print(baos.toString()); 44 //System.out.print(expectedResult); I'll take the change and run it through our test system and see if we see any issues. Is it ok for you if we do the fix just in the jdk branch (JDK13) or are you particularly interested in getting this fixed for jdk12 and/or jdk11u? Best regards Christoph -Original Message- From: core-libs-dev On Behalf Of Steve Groeger Sent: Freitag, 25. Januar 2019 12:40 To: core-libs Subject: RFR: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail Hi all, I have found an issue with the jdk/java/util/prefs/ExportSubtree.java test. Using jtreg to run this test the test passes no matter what happens within the test. Have raised an issue for this: https://bugs.openjdk.java.net/browse/JDK-821 I think the issue is 2 fold: 1) the test check the expected vs. actual and throws an exception but this is caught later in the code, which causes the test to pass as there is no exception thrown. 2) the exported XML now contains a `standalone="no"` entry in the XML prologue, which is not in the expected XML. I have generated a webrev to resolve this: http://cr.op
RE: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail
Hi Steve, Roger, I made some additional cleanups in the test (Declare constants final, formatting, nice up error output...) This is what ran through our test system without issues: http://cr.openjdk.java.net/~clanger/webrevs/821.0/ In case there was an error in the output, it would read like this: --System.out:(39/1030)-- Preferences::exportSubtree did not yield the expected result. Actual: http://java.sun.com/dtd/preferences.dtd;> Expected: http://java.sun.com/dtd/preferences.dtd;> d Are you all ok with that? Then I'd push it... Thanks Christoph > -Original Message- > From: core-libs-dev On Behalf > Of Roger Riggs > Sent: Freitag, 25. Januar 2019 17:52 > To: Steve Groeger > Cc: core-libs-dev@openjdk.java.net > Subject: Re: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java > passes even when test should fail > > +1, > > Thanks, Roger > > > On 01/25/2019 11:21 AM, Steve Groeger wrote: > > Hi Roger, > > > > Thanks. Have included the bug number to the @bug line and have > > included the expected and actual output when there is an error. > > > > Have generated a new webrev here: > > http://cr.openjdk.java.net/~sgroeger/821/webrev.01/ > > <http://cr.openjdk.java.net/%7Esgroeger/821/webrev.01/> > > > > Hope this is now OK. > > > > Thanks > > Steve Groeger > > IBM Runtime Technologies > > Hursley, Winchester > > Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 > > Fax (44) 1962 816800 > > Lotus Notes: Steve Groeger/UK/IBM > > Internet: groe...@uk.ibm.com > > > > Unless stated otherwise above: > > IBM United Kingdom Limited - Registered in England and Wales with > > number 741598. > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 > > 3AU > > > > > > > > From: Roger Riggs > > To: core-libs-dev@openjdk.java.net > > Date: 25/01/2019 15:30 > > Subject: Re: JDK-821 TEST_BUG: > > jdk/java/util/prefs/ExportSubtree.java passes even when test should fail > > Sent by: "core-libs-dev" > > > > > > > > > > Hi Steve, > > > > Add 821 to the @bug line; it helps track and run tests that fixed > > bugs (jtreg -bug:821) > > > > +1 printing the expected and actual (when a failure occurs). > > > > Looks fine overall. > > > > Thanks, Roger > > > > > > > > On 01/25/2019 09:57 AM, Steve Groeger wrote: > > > Hi Christoph, > > > > > > Thanks for looking at this. > > > > > > These lines > > > > > > 43 //System.out.print(baos.toString()); > > > 44 //System.out.print(expectedResult); > > > > > > were commented out in the current code but if you think displaying this > > > info would be good then I can un-comment them. > > > > > > I think only fixing this in the jdk (JDK13) branch is OK. > > > If it is later determined that this is really needed in jdk12 or > > jdk11u , > > > then I can always request a backport. > > > > > > Thanks > > > Steve Groeger > > > IBM Runtime Technologies > > > Hursley, Winchester > > > Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 > > > Fax (44) 1962 816800 > > > Lotus Notes: Steve Groeger/UK/IBM > > > Internet: groe...@uk.ibm.com > > > > > > Unless stated otherwise above: > > > IBM United Kingdom Limited - Registered in England and Wales with > number > > > 741598. > > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire > > PO6 3AU > > > > > > > > > > > > From: "Langer, Christoph" > > > To: Steve Groeger > > > Cc: core-libs > > > Date: 25/01/2019 14:30 > > > Subject: RE: JDK-821 TEST_BUG: > > > jdk/java/util/prefs/ExportSubtree.java passes even when test should fail > > > > > > > > > > > > Hi Steve, > > > > > > in general this change looks reasonable to me. > > > > > > I think in case there is an error, it would be useful to get a > > printout of > > > the expected/vs actual strings like these lines: > > > 43 //System.out.print(baos.toStri
Re: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail
+1, Thanks, Roger On 01/25/2019 11:21 AM, Steve Groeger wrote: Hi Roger, Thanks. Have included the bug number to the @bug line and have included the expected and actual output when there is an error. Have generated a new webrev here: http://cr.openjdk.java.net/~sgroeger/821/webrev.01/ <http://cr.openjdk.java.net/%7Esgroeger/821/webrev.01/> Hope this is now OK. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groe...@uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: Roger Riggs To: core-libs-dev@openjdk.java.net Date: 25/01/2019 15:30 Subject: Re: JDK-821 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail Sent by: "core-libs-dev" Hi Steve, Add 821 to the @bug line; it helps track and run tests that fixed bugs (jtreg -bug:821) +1 printing the expected and actual (when a failure occurs). Looks fine overall. Thanks, Roger On 01/25/2019 09:57 AM, Steve Groeger wrote: > Hi Christoph, > > Thanks for looking at this. > > These lines > > 43 //System.out.print(baos.toString()); > 44 //System.out.print(expectedResult); > > were commented out in the current code but if you think displaying this > info would be good then I can un-comment them. > > I think only fixing this in the jdk (JDK13) branch is OK. > If it is later determined that this is really needed in jdk12 or jdk11u , > then I can always request a backport. > > Thanks > Steve Groeger > IBM Runtime Technologies > Hursley, Winchester > Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 > Fax (44) 1962 816800 > Lotus Notes: Steve Groeger/UK/IBM > Internet: groe...@uk.ibm.com > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > > > > From: "Langer, Christoph" > To: Steve Groeger > Cc: core-libs > Date: 25/01/2019 14:30 > Subject: RE: JDK-821 TEST_BUG: > jdk/java/util/prefs/ExportSubtree.java passes even when test should fail > > > > Hi Steve, > > in general this change looks reasonable to me. > > I think in case there is an error, it would be useful to get a printout of > the expected/vs actual strings like these lines: > 43 //System.out.print(baos.toString()); > 44 //System.out.print(expectedResult); > > I'll take the change and run it through our test system and see if we see > any issues. > > Is it ok for you if we do the fix just in the jdk branch (JDK13) or are > you particularly interested in getting this fixed for jdk12 and/or jdk11u? > > Best regards > Christoph > >> -Original Message----- >> From: core-libs-dev On Behalf >> Of Steve Groeger >> Sent: Freitag, 25. Januar 2019 12:40 >> To: core-libs >> Subject: RFR: JDK-821 TEST_BUG: > jdk/java/util/prefs/ExportSubtree.java >> passes even when test should fail >> >> Hi all, >> >> I have found an issue with the jdk/java/util/prefs/ExportSubtree.java >> test. >> Using jtreg to run this test the test passes no matter what happens > within >> the test. >> Have raised an issue for this: >> > https://bugs.openjdk.java.net/browse/JDK-821 > >> I think the issue is 2 fold: >> 1) the test check the expected vs. actual and throws an exception but > this >> is caught later in the code, which causes the test to pass as there is > no >> exception thrown. >> 2) the exported XML now contains a `standalone="no"` entry in the XML >> prologue, which is not in the expected XML. >> >> I have generated a webrev to resolve this: >> > http://cr.openjdk.java.net/~sgroeger/821/webrev.00/ <http://cr.openjdk.java.net/%7Esgroeger/821/webrev.00/> > >> This occurs on jdk11 but is probabaly also an issue on other releases ie >> jdk8u, jdk12, jdk etc >> >> Please could someone review this webrev and sponsor this chnage for me > as >> I am unable to commit this myself. >> >> Thanks >> Steve Groeger >> IBM Runtime Technologies >> Hursley, Winchester >> Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 >> Fax (44) 1962 816800 >> Lotus Notes: Steve Groeger/UK/IBM
Re: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail
Hi Roger, Thanks. Have included the bug number to the @bug line and have included the expected and actual output when there is an error. Have generated a new webrev here: http://cr.openjdk.java.net/~sgroeger/821/webrev.01/ Hope this is now OK. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groe...@uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: Roger Riggs To: core-libs-dev@openjdk.java.net Date: 25/01/2019 15:30 Subject:Re: JDK-821 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail Sent by:"core-libs-dev" Hi Steve, Add 821 to the @bug line; it helps track and run tests that fixed bugs (jtreg -bug:821) +1 printing the expected and actual (when a failure occurs). Looks fine overall. Thanks, Roger On 01/25/2019 09:57 AM, Steve Groeger wrote: > Hi Christoph, > > Thanks for looking at this. > > These lines > > 43 //System.out.print(baos.toString()); > 44 //System.out.print(expectedResult); > > were commented out in the current code but if you think displaying this > info would be good then I can un-comment them. > > I think only fixing this in the jdk (JDK13) branch is OK. > If it is later determined that this is really needed in jdk12 or jdk11u , > then I can always request a backport. > > Thanks > Steve Groeger > IBM Runtime Technologies > Hursley, Winchester > Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 > Fax (44) 1962 816800 > Lotus Notes: Steve Groeger/UK/IBM > Internet: groe...@uk.ibm.com > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > > > > From: "Langer, Christoph" > To: Steve Groeger > Cc: core-libs > Date: 25/01/2019 14:30 > Subject:RE: JDK-821 TEST_BUG: > jdk/java/util/prefs/ExportSubtree.java passes even when test should fail > > > > Hi Steve, > > in general this change looks reasonable to me. > > I think in case there is an error, it would be useful to get a printout of > the expected/vs actual strings like these lines: > 43 //System.out.print(baos.toString()); > 44 //System.out.print(expectedResult); > > I'll take the change and run it through our test system and see if we see > any issues. > > Is it ok for you if we do the fix just in the jdk branch (JDK13) or are > you particularly interested in getting this fixed for jdk12 and/or jdk11u? > > Best regards > Christoph > >> -Original Message- >> From: core-libs-dev On Behalf >> Of Steve Groeger >> Sent: Freitag, 25. Januar 2019 12:40 >> To: core-libs >> Subject: RFR: JDK-821 TEST_BUG: > jdk/java/util/prefs/ExportSubtree.java >> passes even when test should fail >> >> Hi all, >> >> I have found an issue with the jdk/java/util/prefs/ExportSubtree.java >> test. >> Using jtreg to run this test the test passes no matter what happens > within >> the test. >> Have raised an issue for this: >> > https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D821=DwIFAg=jf_iaSHvJObTbx-siA1ZOg=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA=8dKzRNI_r6CzuhGDpG6M4U24tdu2IEH8qUbdohhixek=UJRfQmkVQXm0xJJoewO9mmR8OiJfiMCZyz_Ky1Ucp5E= > >> I think the issue is 2 fold: >> 1) the test check the expected vs. actual and throws an exception but > this >> is caught later in the code, which causes the test to pass as there is > no >> exception thrown. >> 2) the exported XML now contains a `standalone="no"` entry in the XML >> prologue, which is not in the expected XML. >> >> I have generated a webrev to resolve this: >> > https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Esgroeger_821_webrev.00_=DwIFAg=jf_iaSHvJObTbx-siA1ZOg=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA=8dKzRNI_r6CzuhGDpG6M4U24tdu2IEH8qUbdohhixek=k81f_C-Jgejb860DUQscboWahNDRMgOCLnLQnL-ZQ4Y= > >> This occurs on jdk11 but is probabaly also an issue on other releases ie >> jdk8u, jdk12, jdk etc >> >> Please could someone review this webrev and sponsor this chnage for me > as >> I am unable to commit this myself. >> >> Thanks >> Steve Groeger >> IBM Runtime Technologies >> H
Re: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail
Hi Steve, Add 821 to the @bug line; it helps track and run tests that fixed bugs (jtreg -bug:821) +1 printing the expected and actual (when a failure occurs). Looks fine overall. Thanks, Roger On 01/25/2019 09:57 AM, Steve Groeger wrote: Hi Christoph, Thanks for looking at this. These lines 43 //System.out.print(baos.toString()); 44 //System.out.print(expectedResult); were commented out in the current code but if you think displaying this info would be good then I can un-comment them. I think only fixing this in the jdk (JDK13) branch is OK. If it is later determined that this is really needed in jdk12 or jdk11u , then I can always request a backport. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groe...@uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: "Langer, Christoph" To: Steve Groeger Cc: core-libs Date: 25/01/2019 14:30 Subject: RE: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail Hi Steve, in general this change looks reasonable to me. I think in case there is an error, it would be useful to get a printout of the expected/vs actual strings like these lines: 43 //System.out.print(baos.toString()); 44 //System.out.print(expectedResult); I'll take the change and run it through our test system and see if we see any issues. Is it ok for you if we do the fix just in the jdk branch (JDK13) or are you particularly interested in getting this fixed for jdk12 and/or jdk11u? Best regards Christoph -Original Message- From: core-libs-dev On Behalf Of Steve Groeger Sent: Freitag, 25. Januar 2019 12:40 To: core-libs Subject: RFR: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail Hi all, I have found an issue with the jdk/java/util/prefs/ExportSubtree.java test. Using jtreg to run this test the test passes no matter what happens within the test. Have raised an issue for this: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D821=DwIFAg=jf_iaSHvJObTbx-siA1ZOg=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA=8dKzRNI_r6CzuhGDpG6M4U24tdu2IEH8qUbdohhixek=UJRfQmkVQXm0xJJoewO9mmR8OiJfiMCZyz_Ky1Ucp5E= I think the issue is 2 fold: 1) the test check the expected vs. actual and throws an exception but this is caught later in the code, which causes the test to pass as there is no exception thrown. 2) the exported XML now contains a `standalone="no"` entry in the XML prologue, which is not in the expected XML. I have generated a webrev to resolve this: https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Esgroeger_821_webrev.00_=DwIFAg=jf_iaSHvJObTbx-siA1ZOg=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA=8dKzRNI_r6CzuhGDpG6M4U24tdu2IEH8qUbdohhixek=k81f_C-Jgejb860DUQscboWahNDRMgOCLnLQnL-ZQ4Y= This occurs on jdk11 but is probabaly also an issue on other releases ie jdk8u, jdk12, jdk etc Please could someone review this webrev and sponsor this chnage for me as I am unable to commit this myself. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groe...@uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
RE: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail
Hi Christoph, Thanks for looking at this. These lines 43 //System.out.print(baos.toString()); 44 //System.out.print(expectedResult); were commented out in the current code but if you think displaying this info would be good then I can un-comment them. I think only fixing this in the jdk (JDK13) branch is OK. If it is later determined that this is really needed in jdk12 or jdk11u , then I can always request a backport. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groe...@uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: "Langer, Christoph" To: Steve Groeger Cc: core-libs Date: 25/01/2019 14:30 Subject: RE: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail Hi Steve, in general this change looks reasonable to me. I think in case there is an error, it would be useful to get a printout of the expected/vs actual strings like these lines: 43 //System.out.print(baos.toString()); 44 //System.out.print(expectedResult); I'll take the change and run it through our test system and see if we see any issues. Is it ok for you if we do the fix just in the jdk branch (JDK13) or are you particularly interested in getting this fixed for jdk12 and/or jdk11u? Best regards Christoph > -Original Message- > From: core-libs-dev On Behalf > Of Steve Groeger > Sent: Freitag, 25. Januar 2019 12:40 > To: core-libs > Subject: RFR: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java > passes even when test should fail > > Hi all, > > I have found an issue with the jdk/java/util/prefs/ExportSubtree.java > test. > Using jtreg to run this test the test passes no matter what happens within > the test. > Have raised an issue for this: > https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D821=DwIFAg=jf_iaSHvJObTbx-siA1ZOg=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA=8dKzRNI_r6CzuhGDpG6M4U24tdu2IEH8qUbdohhixek=UJRfQmkVQXm0xJJoewO9mmR8OiJfiMCZyz_Ky1Ucp5E= > > I think the issue is 2 fold: > 1) the test check the expected vs. actual and throws an exception but this > is caught later in the code, which causes the test to pass as there is no > exception thrown. > 2) the exported XML now contains a `standalone="no"` entry in the XML > prologue, which is not in the expected XML. > > I have generated a webrev to resolve this: > https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Esgroeger_821_webrev.00_=DwIFAg=jf_iaSHvJObTbx-siA1ZOg=78GW2OHz7nNTH2dBkTx7-TKh2QCt3JD3zukzeUO8RpA=8dKzRNI_r6CzuhGDpG6M4U24tdu2IEH8qUbdohhixek=k81f_C-Jgejb860DUQscboWahNDRMgOCLnLQnL-ZQ4Y= > > This occurs on jdk11 but is probabaly also an issue on other releases ie > jdk8u, jdk12, jdk etc > > Please could someone review this webrev and sponsor this chnage for me as > I am unable to commit this myself. > > Thanks > Steve Groeger > IBM Runtime Technologies > Hursley, Winchester > Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 > Fax (44) 1962 816800 > Lotus Notes: Steve Groeger/UK/IBM > Internet: groe...@uk.ibm.com > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 > 3AU > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 > 3AU Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
RE: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail
Hi Steve, in general this change looks reasonable to me. I think in case there is an error, it would be useful to get a printout of the expected/vs actual strings like these lines: 43 //System.out.print(baos.toString()); 44 //System.out.print(expectedResult); I'll take the change and run it through our test system and see if we see any issues. Is it ok for you if we do the fix just in the jdk branch (JDK13) or are you particularly interested in getting this fixed for jdk12 and/or jdk11u? Best regards Christoph > -Original Message- > From: core-libs-dev On Behalf > Of Steve Groeger > Sent: Freitag, 25. Januar 2019 12:40 > To: core-libs > Subject: RFR: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java > passes even when test should fail > > Hi all, > > I have found an issue with the jdk/java/util/prefs/ExportSubtree.java > test. > Using jtreg to run this test the test passes no matter what happens within > the test. > Have raised an issue for this: > https://bugs.openjdk.java.net/browse/JDK-821 > > I think the issue is 2 fold: > 1) the test check the expected vs. actual and throws an exception but this > is caught later in the code, which causes the test to pass as there is no > exception thrown. > 2) the exported XML now contains a `standalone="no"` entry in the XML > prologue, which is not in the expected XML. > > I have generated a webrev to resolve this: > http://cr.openjdk.java.net/~sgroeger/821/webrev.00/ > > This occurs on jdk11 but is probabaly also an issue on other releases ie > jdk8u, jdk12, jdk etc > > Please could someone review this webrev and sponsor this chnage for me as > I am unable to commit this myself. > > Thanks > Steve Groeger > IBM Runtime Technologies > Hursley, Winchester > Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 > Fax (44) 1962 816800 > Lotus Notes: Steve Groeger/UK/IBM > Internet: groe...@uk.ibm.com > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 > 3AU > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 > 3AU
RFR: JDK-8217777 TEST_BUG: jdk/java/util/prefs/ExportSubtree.java passes even when test should fail
Hi all, I have found an issue with the jdk/java/util/prefs/ExportSubtree.java test. Using jtreg to run this test the test passes no matter what happens within the test. Have raised an issue for this: https://bugs.openjdk.java.net/browse/JDK-821 I think the issue is 2 fold: 1) the test check the expected vs. actual and throws an exception but this is caught later in the code, which causes the test to pass as there is no exception thrown. 2) the exported XML now contains a `standalone="no"` entry in the XML prologue, which is not in the expected XML. I have generated a webrev to resolve this: http://cr.openjdk.java.net/~sgroeger/821/webrev.00/ This occurs on jdk11 but is probabaly also an issue on other releases ie jdk8u, jdk12, jdk etc Please could someone review this webrev and sponsor this chnage for me as I am unable to commit this myself. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groe...@uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
