Re: JDK-8237818: Typo in Unsafe: resposibility
Hi,
Thanks for pushing changes!
regards,
Aya Ebata
2020年2月17日(月) 11:37 Yasumasa Suenaga :
> On 2020/02/17 11:21, David Holmes wrote:
> > Hi Yasumasa,
> >
> > On 17/02/2020 11:38 am, Yasumasa Suenaga wrote:
> >> Hi David,
> >>
> >> On 2020/02/17 8:10, David Holmes wrote:
> >>> On 17/02/2020 12:40 am, Aya Ebata wrote:
> Hi,
>
> I sent OCA today. So it hasn't been approved yet. I'm waiting for
> approval.
> >>>
> >>> For this trivial contribution an OCA is a not required, so this can be
> sponsored before the OCA goes through processing.
> >>
> >> I didn't know that!
> >> I hope it is described in "How to contribute" page [1].
> >
> > Unfortunately no, it is covered in the by-laws [1], when distinguishing
> a Participant from a Contributor:
> >
> > "A Participant may post messages to a list, submit simple patches, and
> make other kinds of small contributions."
> >
> > "A Contributor is a Participant who has signed the Oracle Contributor
> Agreement (OCA), ..."
>
> Thanks for your information!
>
>
> Cheers,
>
> Yasumasa
>
>
> > Cheers,
> > David
> >
> > [1] https://openjdk.java.net/bylaws
> >
> >
> >
> >> Anyway, I will push Aya's change to jdk/jdk.
> >>
> >>
> >> Thanks,
> >>
> >> Yasumasa
> >>
> >>
> >> [1] https://openjdk.java.net/contribute/
> >>
> >>
> >>> Cheers,
> >>> David
> >>>
> regards,
> Aya Ebata
>
>
> 2020年2月16日(日) 16:49 Yasumasa Suenaga :
>
> > Hi Aya,
> >
> > It looks good to me.
> > BTW, have you signed to OCA? If so, I will sponsor you.
> >
> >
> > Thanks,
> >
> > Yasumasa
> >
> >
> > On 2020/02/16 16:42, 江畑 彩 wrote:
> >> Hi,
> >>
> >> I fixed typo in s.m.Unsafe and j.i.Unsafe. The changes are below.
> >> Could you sponsor this, please.
> >> https://bugs.openjdk.java.net/browse/JDK-8237818
> >>
> >> regards,
> >> Aya Ebata
> >>
> >>
> >>
> >> diff --git
> a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
> >> b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
> >> --- a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
> >> +++ b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
> >> @@ -40,7 +40,7 @@
> >> * Although the class and all methods are public, use of this
> class is
> >> * limited because only trusted code can obtain instances of it.
> >> *
> >> - * Note: It is the resposibility of the caller to make
> sure
> >> + * Note: It is the responsibility of the caller to make
> sure
> >> * arguments are checked before methods of this class are
> >> * called. While some rudimentary checks are performed on the
> input,
> >> * the checks are best effort and when performance is an
> overriding
> >> @@ -425,7 +425,7 @@
> >>/**
> >> * Create an exception reflecting that some of the input was
> > invalid
> >> *
> >> - * Note: It is the resposibility of the caller to make
> >> + * Note: It is the responsibility of the caller to
> make
> >> * sure arguments are checked before the methods are called.
> While
> >> * some rudimentary checks are performed on the input, the
> checks
> >> * are best effort and when performance is an overriding
> priority,
> >> @@ -601,7 +601,7 @@
> >> * aligned for all value types. Dispose of this memory by
> calling
> >> {@link
> >> * #freeMemory}, or resize it with {@link #reallocateMemory}.
> >> *
> >> - * Note: It is the resposibility of the caller to make
> >> + * Note: It is the responsibility of the caller to
> make
> >> * sure arguments are checked before the methods are called.
> While
> >> * some rudimentary checks are performed on the input, the
> checks
> >> * are best effort and when performance is an overriding
> priority,
> >> @@ -657,7 +657,7 @@
> >> * #reallocateMemory}. The address passed to this method
> may be
> > null,
> >> in
> >> * which case an allocation will be performed.
> >> *
> >> - * Note: It is the resposibility of the caller to make
> >> + * Note: It is the responsibility of the caller to
> make
> >> * sure arguments are checked before the methods are called.
> While
> >> * some rudimentary checks are performed on the input, the
> checks
> >> * are best effort and when performance is an overriding
> priority,
> >> @@ -719,7 +719,7 @@
> >> * If the effective address and length are (resp.) even
> modulo 4
> > or 2,
> >> * the stores take place in units of 'int' or 'short'.
> >> *
> >> - * Note: It is the resposibility of the caller to make
> >> + * Note: It is the responsibility of the caller to
> make
> >> * sure arguments are
Re: JDK-8237818: Typo in Unsafe: resposibility
On 2020/02/17 11:21, David Holmes wrote:
Hi Yasumasa,
On 17/02/2020 11:38 am, Yasumasa Suenaga wrote:
Hi David,
On 2020/02/17 8:10, David Holmes wrote:
On 17/02/2020 12:40 am, Aya Ebata wrote:
Hi,
I sent OCA today. So it hasn't been approved yet. I'm waiting for approval.
For this trivial contribution an OCA is a not required, so this can be
sponsored before the OCA goes through processing.
I didn't know that!
I hope it is described in "How to contribute" page [1].
Unfortunately no, it is covered in the by-laws [1], when distinguishing a
Participant from a Contributor:
"A Participant may post messages to a list, submit simple patches, and make other
kinds of small contributions."
"A Contributor is a Participant who has signed the Oracle Contributor Agreement
(OCA), ..."
Thanks for your information!
Cheers,
Yasumasa
Cheers,
David
[1] https://openjdk.java.net/bylaws
Anyway, I will push Aya's change to jdk/jdk.
Thanks,
Yasumasa
[1] https://openjdk.java.net/contribute/
Cheers,
David
regards,
Aya Ebata
2020年2月16日(日) 16:49 Yasumasa Suenaga :
Hi Aya,
It looks good to me.
BTW, have you signed to OCA? If so, I will sponsor you.
Thanks,
Yasumasa
On 2020/02/16 16:42, 江畑 彩 wrote:
Hi,
I fixed typo in s.m.Unsafe and j.i.Unsafe. The changes are below.
Could you sponsor this, please.
https://bugs.openjdk.java.net/browse/JDK-8237818
regards,
Aya Ebata
diff --git a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
--- a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
+++ b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
@@ -40,7 +40,7 @@
* Although the class and all methods are public, use of this class is
* limited because only trusted code can obtain instances of it.
*
- * Note: It is the resposibility of the caller to make sure
+ * Note: It is the responsibility of the caller to make sure
* arguments are checked before methods of this class are
* called. While some rudimentary checks are performed on the input,
* the checks are best effort and when performance is an overriding
@@ -425,7 +425,7 @@
/**
* Create an exception reflecting that some of the input was
invalid
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -601,7 +601,7 @@
* aligned for all value types. Dispose of this memory by calling
{@link
* #freeMemory}, or resize it with {@link #reallocateMemory}.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -657,7 +657,7 @@
* #reallocateMemory}. The address passed to this method may be
null,
in
* which case an allocation will be performed.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -719,7 +719,7 @@
* If the effective address and length are (resp.) even modulo 4
or 2,
* the stores take place in units of 'int' or 'short'.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -781,7 +781,7 @@
* If the effective addresses and length are (resp.) even modulo 4
or
2,
* the transfer takes place in units of 'int' or 'short'.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -842,7 +842,7 @@
* as discussed in {@link #getInt(Object,long)}. When the object
reference is null,
* the offset supplies an absolute base address.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
Re: JDK-8237818: Typo in Unsafe: resposibility
Hi Yasumasa,
On 17/02/2020 11:38 am, Yasumasa Suenaga wrote:
Hi David,
On 2020/02/17 8:10, David Holmes wrote:
On 17/02/2020 12:40 am, Aya Ebata wrote:
Hi,
I sent OCA today. So it hasn't been approved yet. I'm waiting for
approval.
For this trivial contribution an OCA is a not required, so this can be
sponsored before the OCA goes through processing.
I didn't know that!
I hope it is described in "How to contribute" page [1].
Unfortunately no, it is covered in the by-laws [1], when distinguishing
a Participant from a Contributor:
"A Participant may post messages to a list, submit simple patches, and
make other kinds of small contributions."
"A Contributor is a Participant who has signed the Oracle Contributor
Agreement (OCA), ..."
Cheers,
David
[1] https://openjdk.java.net/bylaws
Anyway, I will push Aya's change to jdk/jdk.
Thanks,
Yasumasa
[1] https://openjdk.java.net/contribute/
Cheers,
David
regards,
Aya Ebata
2020年2月16日(日) 16:49 Yasumasa Suenaga :
Hi Aya,
It looks good to me.
BTW, have you signed to OCA? If so, I will sponsor you.
Thanks,
Yasumasa
On 2020/02/16 16:42, 江畑 彩 wrote:
Hi,
I fixed typo in s.m.Unsafe and j.i.Unsafe. The changes are below.
Could you sponsor this, please.
https://bugs.openjdk.java.net/browse/JDK-8237818
regards,
Aya Ebata
diff --git a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
--- a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
+++ b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
@@ -40,7 +40,7 @@
* Although the class and all methods are public, use of this
class is
* limited because only trusted code can obtain instances of it.
*
- * Note: It is the resposibility of the caller to make sure
+ * Note: It is the responsibility of the caller to make sure
* arguments are checked before methods of this class are
* called. While some rudimentary checks are performed on the
input,
* the checks are best effort and when performance is an overriding
@@ -425,7 +425,7 @@
/**
* Create an exception reflecting that some of the input was
invalid
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called.
While
* some rudimentary checks are performed on the input, the
checks
* are best effort and when performance is an overriding
priority,
@@ -601,7 +601,7 @@
* aligned for all value types. Dispose of this memory by
calling
{@link
* #freeMemory}, or resize it with {@link #reallocateMemory}.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called.
While
* some rudimentary checks are performed on the input, the
checks
* are best effort and when performance is an overriding
priority,
@@ -657,7 +657,7 @@
* #reallocateMemory}. The address passed to this method
may be
null,
in
* which case an allocation will be performed.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called.
While
* some rudimentary checks are performed on the input, the
checks
* are best effort and when performance is an overriding
priority,
@@ -719,7 +719,7 @@
* If the effective address and length are (resp.) even
modulo 4
or 2,
* the stores take place in units of 'int' or 'short'.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called.
While
* some rudimentary checks are performed on the input, the
checks
* are best effort and when performance is an overriding
priority,
@@ -781,7 +781,7 @@
* If the effective addresses and length are (resp.) even
modulo 4
or
2,
* the transfer takes place in units of 'int' or 'short'.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called.
While
* some rudimentary checks are performed on the input, the
checks
* are best effort and when performance is an overriding
priority,
@@ -842,7 +842,7 @@
* as discussed in {@link #getInt(Object,long)}. When the
object
reference is null,
* the offset supplies an absolute base address.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are
Re: JDK-8237818: Typo in Unsafe: resposibility
Pushed: http://hg.openjdk.java.net/jdk/jdk/rev/f3f66f9e98ee
Yasumasa
On 2020/02/17 10:38, Yasumasa Suenaga wrote:
Hi David,
On 2020/02/17 8:10, David Holmes wrote:
On 17/02/2020 12:40 am, Aya Ebata wrote:
Hi,
I sent OCA today. So it hasn't been approved yet. I'm waiting for approval.
For this trivial contribution an OCA is a not required, so this can be
sponsored before the OCA goes through processing.
I didn't know that!
I hope it is described in "How to contribute" page [1].
Anyway, I will push Aya's change to jdk/jdk.
Thanks,
Yasumasa
[1] https://openjdk.java.net/contribute/
Cheers,
David
regards,
Aya Ebata
2020年2月16日(日) 16:49 Yasumasa Suenaga :
Hi Aya,
It looks good to me.
BTW, have you signed to OCA? If so, I will sponsor you.
Thanks,
Yasumasa
On 2020/02/16 16:42, 江畑 彩 wrote:
Hi,
I fixed typo in s.m.Unsafe and j.i.Unsafe. The changes are below.
Could you sponsor this, please.
https://bugs.openjdk.java.net/browse/JDK-8237818
regards,
Aya Ebata
diff --git a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
--- a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
+++ b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
@@ -40,7 +40,7 @@
* Although the class and all methods are public, use of this class is
* limited because only trusted code can obtain instances of it.
*
- * Note: It is the resposibility of the caller to make sure
+ * Note: It is the responsibility of the caller to make sure
* arguments are checked before methods of this class are
* called. While some rudimentary checks are performed on the input,
* the checks are best effort and when performance is an overriding
@@ -425,7 +425,7 @@
/**
* Create an exception reflecting that some of the input was
invalid
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -601,7 +601,7 @@
* aligned for all value types. Dispose of this memory by calling
{@link
* #freeMemory}, or resize it with {@link #reallocateMemory}.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -657,7 +657,7 @@
* #reallocateMemory}. The address passed to this method may be
null,
in
* which case an allocation will be performed.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -719,7 +719,7 @@
* If the effective address and length are (resp.) even modulo 4
or 2,
* the stores take place in units of 'int' or 'short'.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -781,7 +781,7 @@
* If the effective addresses and length are (resp.) even modulo 4
or
2,
* the transfer takes place in units of 'int' or 'short'.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -842,7 +842,7 @@
* as discussed in {@link #getInt(Object,long)}. When the object
reference is null,
* the offset supplies an absolute base address.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -901,7 +901,7 @@
* #allocateMemory} or {@link #reallocateMemory}. The address
passed
to
* this method may be null, in which case no action is taken.
*
- * Note: It
Re: JDK-8237818: Typo in Unsafe: resposibility
Hi David,
On 2020/02/17 8:10, David Holmes wrote:
On 17/02/2020 12:40 am, Aya Ebata wrote:
Hi,
I sent OCA today. So it hasn't been approved yet. I'm waiting for approval.
For this trivial contribution an OCA is a not required, so this can be
sponsored before the OCA goes through processing.
I didn't know that!
I hope it is described in "How to contribute" page [1].
Anyway, I will push Aya's change to jdk/jdk.
Thanks,
Yasumasa
[1] https://openjdk.java.net/contribute/
Cheers,
David
regards,
Aya Ebata
2020年2月16日(日) 16:49 Yasumasa Suenaga :
Hi Aya,
It looks good to me.
BTW, have you signed to OCA? If so, I will sponsor you.
Thanks,
Yasumasa
On 2020/02/16 16:42, 江畑 彩 wrote:
Hi,
I fixed typo in s.m.Unsafe and j.i.Unsafe. The changes are below.
Could you sponsor this, please.
https://bugs.openjdk.java.net/browse/JDK-8237818
regards,
Aya Ebata
diff --git a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
--- a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
+++ b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
@@ -40,7 +40,7 @@
* Although the class and all methods are public, use of this class is
* limited because only trusted code can obtain instances of it.
*
- * Note: It is the resposibility of the caller to make sure
+ * Note: It is the responsibility of the caller to make sure
* arguments are checked before methods of this class are
* called. While some rudimentary checks are performed on the input,
* the checks are best effort and when performance is an overriding
@@ -425,7 +425,7 @@
/**
* Create an exception reflecting that some of the input was
invalid
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -601,7 +601,7 @@
* aligned for all value types. Dispose of this memory by calling
{@link
* #freeMemory}, or resize it with {@link #reallocateMemory}.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -657,7 +657,7 @@
* #reallocateMemory}. The address passed to this method may be
null,
in
* which case an allocation will be performed.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -719,7 +719,7 @@
* If the effective address and length are (resp.) even modulo 4
or 2,
* the stores take place in units of 'int' or 'short'.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -781,7 +781,7 @@
* If the effective addresses and length are (resp.) even modulo 4
or
2,
* the transfer takes place in units of 'int' or 'short'.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -842,7 +842,7 @@
* as discussed in {@link #getInt(Object,long)}. When the object
reference is null,
* the offset supplies an absolute base address.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -901,7 +901,7 @@
* #allocateMemory} or {@link #reallocateMemory}. The address
passed
to
* this method may be null, in which case no action is taken.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure
Re: JDK-8237818: Typo in Unsafe: resposibility
On 17/02/2020 12:40 am, Aya Ebata wrote:
Hi,
I sent OCA today. So it hasn't been approved yet. I'm waiting for approval.
For this trivial contribution an OCA is a not required, so this can be
sponsored before the OCA goes through processing.
Cheers,
David
regards,
Aya Ebata
2020年2月16日(日) 16:49 Yasumasa Suenaga :
Hi Aya,
It looks good to me.
BTW, have you signed to OCA? If so, I will sponsor you.
Thanks,
Yasumasa
On 2020/02/16 16:42, 江畑 彩 wrote:
Hi,
I fixed typo in s.m.Unsafe and j.i.Unsafe. The changes are below.
Could you sponsor this, please.
https://bugs.openjdk.java.net/browse/JDK-8237818
regards,
Aya Ebata
diff --git a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
--- a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
+++ b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
@@ -40,7 +40,7 @@
* Although the class and all methods are public, use of this class is
* limited because only trusted code can obtain instances of it.
*
- * Note: It is the resposibility of the caller to make sure
+ * Note: It is the responsibility of the caller to make sure
* arguments are checked before methods of this class are
* called. While some rudimentary checks are performed on the input,
* the checks are best effort and when performance is an overriding
@@ -425,7 +425,7 @@
/**
* Create an exception reflecting that some of the input was
invalid
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -601,7 +601,7 @@
* aligned for all value types. Dispose of this memory by calling
{@link
* #freeMemory}, or resize it with {@link #reallocateMemory}.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -657,7 +657,7 @@
* #reallocateMemory}. The address passed to this method may be
null,
in
* which case an allocation will be performed.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -719,7 +719,7 @@
* If the effective address and length are (resp.) even modulo 4
or 2,
* the stores take place in units of 'int' or 'short'.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -781,7 +781,7 @@
* If the effective addresses and length are (resp.) even modulo 4
or
2,
* the transfer takes place in units of 'int' or 'short'.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -842,7 +842,7 @@
* as discussed in {@link #getInt(Object,long)}. When the object
reference is null,
* the offset supplies an absolute base address.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -901,7 +901,7 @@
* #allocateMemory} or {@link #reallocateMemory}. The address
passed
to
* this method may be null, in which case no action is taken.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
diff --git
Re: JDK-8237818: Typo in Unsafe: resposibility
Hi,
I sent OCA today. So it hasn't been approved yet. I'm waiting for approval.
regards,
Aya Ebata
2020年2月16日(日) 16:49 Yasumasa Suenaga :
> Hi Aya,
>
> It looks good to me.
> BTW, have you signed to OCA? If so, I will sponsor you.
>
>
> Thanks,
>
> Yasumasa
>
>
> On 2020/02/16 16:42, 江畑 彩 wrote:
> > Hi,
> >
> > I fixed typo in s.m.Unsafe and j.i.Unsafe. The changes are below.
> > Could you sponsor this, please.
> > https://bugs.openjdk.java.net/browse/JDK-8237818
> >
> > regards,
> > Aya Ebata
> >
> >
> >
> > diff --git a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
> > b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
> > --- a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
> > +++ b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
> > @@ -40,7 +40,7 @@
> >* Although the class and all methods are public, use of this class is
> >* limited because only trusted code can obtain instances of it.
> >*
> > - * Note: It is the resposibility of the caller to make sure
> > + * Note: It is the responsibility of the caller to make sure
> >* arguments are checked before methods of this class are
> >* called. While some rudimentary checks are performed on the input,
> >* the checks are best effort and when performance is an overriding
> > @@ -425,7 +425,7 @@
> > /**
> >* Create an exception reflecting that some of the input was
> invalid
> >*
> > - * Note: It is the resposibility of the caller to make
> > + * Note: It is the responsibility of the caller to make
> >* sure arguments are checked before the methods are called. While
> >* some rudimentary checks are performed on the input, the checks
> >* are best effort and when performance is an overriding priority,
> > @@ -601,7 +601,7 @@
> >* aligned for all value types. Dispose of this memory by calling
> > {@link
> >* #freeMemory}, or resize it with {@link #reallocateMemory}.
> >*
> > - * Note: It is the resposibility of the caller to make
> > + * Note: It is the responsibility of the caller to make
> >* sure arguments are checked before the methods are called. While
> >* some rudimentary checks are performed on the input, the checks
> >* are best effort and when performance is an overriding priority,
> > @@ -657,7 +657,7 @@
> >* #reallocateMemory}. The address passed to this method may be
> null,
> > in
> >* which case an allocation will be performed.
> >*
> > - * Note: It is the resposibility of the caller to make
> > + * Note: It is the responsibility of the caller to make
> >* sure arguments are checked before the methods are called. While
> >* some rudimentary checks are performed on the input, the checks
> >* are best effort and when performance is an overriding priority,
> > @@ -719,7 +719,7 @@
> >* If the effective address and length are (resp.) even modulo 4
> or 2,
> >* the stores take place in units of 'int' or 'short'.
> >*
> > - * Note: It is the resposibility of the caller to make
> > + * Note: It is the responsibility of the caller to make
> >* sure arguments are checked before the methods are called. While
> >* some rudimentary checks are performed on the input, the checks
> >* are best effort and when performance is an overriding priority,
> > @@ -781,7 +781,7 @@
> >* If the effective addresses and length are (resp.) even modulo 4
> or
> > 2,
> >* the transfer takes place in units of 'int' or 'short'.
> >*
> > - * Note: It is the resposibility of the caller to make
> > + * Note: It is the responsibility of the caller to make
> >* sure arguments are checked before the methods are called. While
> >* some rudimentary checks are performed on the input, the checks
> >* are best effort and when performance is an overriding priority,
> > @@ -842,7 +842,7 @@
> >* as discussed in {@link #getInt(Object,long)}. When the object
> > reference is null,
> >* the offset supplies an absolute base address.
> >*
> > - * Note: It is the resposibility of the caller to make
> > + * Note: It is the responsibility of the caller to make
> >* sure arguments are checked before the methods are called. While
> >* some rudimentary checks are performed on the input, the checks
> >* are best effort and when performance is an overriding priority,
> > @@ -901,7 +901,7 @@
> >* #allocateMemory} or {@link #reallocateMemory}. The address
> passed
> > to
> >* this method may be null, in which case no action is taken.
> >*
> > - * Note: It is the resposibility of the caller to make
> > + * Note: It is the responsibility of the caller to make
> >* sure arguments are checked before the methods are called. While
> >* some rudimentary checks
Re: JDK-8237818: Typo in Unsafe: resposibility
Hi Aya,
It looks good to me.
BTW, have you signed to OCA? If so, I will sponsor you.
Thanks,
Yasumasa
On 2020/02/16 16:42, 江畑 彩 wrote:
Hi,
I fixed typo in s.m.Unsafe and j.i.Unsafe. The changes are below.
Could you sponsor this, please.
https://bugs.openjdk.java.net/browse/JDK-8237818
regards,
Aya Ebata
diff --git a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
--- a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
+++ b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
@@ -40,7 +40,7 @@
* Although the class and all methods are public, use of this class is
* limited because only trusted code can obtain instances of it.
*
- * Note: It is the resposibility of the caller to make sure
+ * Note: It is the responsibility of the caller to make sure
* arguments are checked before methods of this class are
* called. While some rudimentary checks are performed on the input,
* the checks are best effort and when performance is an overriding
@@ -425,7 +425,7 @@
/**
* Create an exception reflecting that some of the input was invalid
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -601,7 +601,7 @@
* aligned for all value types. Dispose of this memory by calling
{@link
* #freeMemory}, or resize it with {@link #reallocateMemory}.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -657,7 +657,7 @@
* #reallocateMemory}. The address passed to this method may be null,
in
* which case an allocation will be performed.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -719,7 +719,7 @@
* If the effective address and length are (resp.) even modulo 4 or 2,
* the stores take place in units of 'int' or 'short'.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -781,7 +781,7 @@
* If the effective addresses and length are (resp.) even modulo 4 or
2,
* the transfer takes place in units of 'int' or 'short'.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -842,7 +842,7 @@
* as discussed in {@link #getInt(Object,long)}. When the object
reference is null,
* the offset supplies an absolute base address.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -901,7 +901,7 @@
* #allocateMemory} or {@link #reallocateMemory}. The address passed
to
* this method may be null, in which case no action is taken.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
diff --git a/src/jdk.unsupported/share/classes/sun/misc/Unsafe.java
b/src/jdk.unsupported/share/classes/sun/misc/Unsafe.java
--- a/src/jdk.unsupported/share/classes/sun/misc/Unsafe.java
+++ b/src/jdk.unsupported/share/classes/sun/misc/Unsafe.java
@@ -39,7 +39,7 @@
* Although the class and all methods are public, use of this class is
* limited because only trusted code can obtain instances of it.
*
- *
JDK-8237818: Typo in Unsafe: resposibility
Hi,
I fixed typo in s.m.Unsafe and j.i.Unsafe. The changes are below.
Could you sponsor this, please.
https://bugs.openjdk.java.net/browse/JDK-8237818
regards,
Aya Ebata
diff --git a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
--- a/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
+++ b/src/java.base/share/classes/jdk/internal/misc/Unsafe.java
@@ -40,7 +40,7 @@
* Although the class and all methods are public, use of this class is
* limited because only trusted code can obtain instances of it.
*
- * Note: It is the resposibility of the caller to make sure
+ * Note: It is the responsibility of the caller to make sure
* arguments are checked before methods of this class are
* called. While some rudimentary checks are performed on the input,
* the checks are best effort and when performance is an overriding
@@ -425,7 +425,7 @@
/**
* Create an exception reflecting that some of the input was invalid
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -601,7 +601,7 @@
* aligned for all value types. Dispose of this memory by calling
{@link
* #freeMemory}, or resize it with {@link #reallocateMemory}.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -657,7 +657,7 @@
* #reallocateMemory}. The address passed to this method may be null,
in
* which case an allocation will be performed.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -719,7 +719,7 @@
* If the effective address and length are (resp.) even modulo 4 or 2,
* the stores take place in units of 'int' or 'short'.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -781,7 +781,7 @@
* If the effective addresses and length are (resp.) even modulo 4 or
2,
* the transfer takes place in units of 'int' or 'short'.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -842,7 +842,7 @@
* as discussed in {@link #getInt(Object,long)}. When the object
reference is null,
* the offset supplies an absolute base address.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
@@ -901,7 +901,7 @@
* #allocateMemory} or {@link #reallocateMemory}. The address passed
to
* this method may be null, in which case no action is taken.
*
- * Note: It is the resposibility of the caller to make
+ * Note: It is the responsibility of the caller to make
* sure arguments are checked before the methods are called. While
* some rudimentary checks are performed on the input, the checks
* are best effort and when performance is an overriding priority,
diff --git a/src/jdk.unsupported/share/classes/sun/misc/Unsafe.java
b/src/jdk.unsupported/share/classes/sun/misc/Unsafe.java
--- a/src/jdk.unsupported/share/classes/sun/misc/Unsafe.java
+++ b/src/jdk.unsupported/share/classes/sun/misc/Unsafe.java
@@ -39,7 +39,7 @@
* Although the class and all methods are public, use of this class is
* limited because only trusted code can obtain instances of it.
*
- * Note: It is the resposibility of the caller to make sure
+ * Note: It is the responsibility of the caller to make sure
* arguments are checked before methods of this class are
* called. While
