Re: JDK 9 RFR of 8039022: Fix serial lint warnings in sun.tools.java

2014-04-02 Thread Alan Bateman 

On 02/04/2014 00:20, Joe Darcy wrote:

Hello,

The plague of serial warnings in the jdk repo is nearly eradicated. 
Please review  the fix below if address to a few of the holdouts.


This looks okay, assuming of course that none of these types leak into 
the serialized form by some other means.


-Alan.

JDK 9 RFR of 8039022: Fix serial lint warnings in sun.tools.java

2014-04-01 Thread Joe Darcy 

Hello,

The plague of serial warnings in the jdk repo is nearly eradicated. 
Please review  the fix below if address to a few of the holdouts.


Thanks,

-Joe

diff -r b6997dd0667e src/share/classes/sun/tools/java/AmbiguousClass.java
--- a/src/share/classes/sun/tools/java/AmbiguousClass.javaTue Apr 01 
09:12:51 2014 -0700
+++ b/src/share/classes/sun/tools/java/AmbiguousClass.javaTue Apr 01 
16:19:44 2014 -0700

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1994, 2003, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 1994, 2014, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -34,6 +34,7 @@
  * they are subject to change or removal without notice.
  */

+@SuppressWarnings("serial") // JDK implementation class
 public
 class AmbiguousClass extends ClassNotFound {
 /**
diff -r b6997dd0667e src/share/classes/sun/tools/java/AmbiguousMember.java
--- a/src/share/classes/sun/tools/java/AmbiguousMember.javaTue Apr 
01 09:12:51 2014 -0700
+++ b/src/share/classes/sun/tools/java/AmbiguousMember.javaTue Apr 
01 16:19:44 2014 -0700

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1994, 2003, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 1994, 2014, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -35,6 +35,7 @@
  * supported API.  Code that depends on them does so at its own risk:
  * they are subject to change or removal without notice.
  */
+@SuppressWarnings("serial") // JDK implementation class
 public
 class AmbiguousMember extends Exception {
 /**
diff -r b6997dd0667e src/share/classes/sun/tools/java/ClassNotFound.java
--- a/src/share/classes/sun/tools/java/ClassNotFound.javaTue Apr 01 
09:12:51 2014 -0700
+++ b/src/share/classes/sun/tools/java/ClassNotFound.javaTue Apr 01 
16:19:44 2014 -0700

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1994, 2003, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 1994, 2014, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -33,6 +33,7 @@
  * supported API.  Code that depends on them does so at its own risk:
  * they are subject to change or removal without notice.
  */
+@SuppressWarnings("serial") // JDK implementation class
 public
 class ClassNotFound extends Exception {
 /**
diff -r b6997dd0667e src/share/classes/sun/tools/java/CompilerError.java
--- a/src/share/classes/sun/tools/java/CompilerError.javaTue Apr 01 
09:12:51 2014 -0700
+++ b/src/share/classes/sun/tools/java/CompilerError.javaTue Apr 01 
16:19:44 2014 -0700

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1994, 2003, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 1994, 2014, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -32,7 +32,7 @@
  * supported API.  Code that depends on them does so at its own risk:
  * they are subject to change or removal without notice.
  */
-
+@SuppressWarnings("serial") // JDK implementation class
 public
 class CompilerError extends Error {
 Throwable e;
diff -r b6997dd0667e src/share/classes/sun/tools/java/SyntaxError.java
--- a/src/share/classes/sun/tools/java/SyntaxError.javaTue Apr 01 
09:12:51 2014 -0700
+++ b/src/share/classes/sun/tools/java/SyntaxError.javaTue Apr 01 
16:19:44 2014 -0700

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1994, 2003, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 1994, 2014, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -33,7 +33,7 @@
  * supported API.  Code that depends on them does so at its own risk:
  * they are subject to change or removal without notice.
  */
-
+@SuppressWarnings("serial") // JDK implementation class
 public
 class SyntaxError extends Exception {
 }