Re: JDK 9 RFR of 8039027: Fix serial lint warnings in jconsole and jstat

2014-04-02 Thread Alan Bateman

On 02/04/2014 02:20, Joe Darcy wrote:

Hello,

With the serial warnings cleanup of the JDK drawing to completion, 
please review the patch below which addresses some lingering issues in 
jconsole and jstat.

This looks okay too.

-Alan


JDK 9 RFR of 8039027: Fix serial lint warnings in jconsole and jstat

2014-04-01 Thread Joe Darcy

Hello,

With the serial warnings cleanup of the JDK drawing to completion, 
please review the patch below which addresses some lingering issues in 
jconsole and jstat.


Thanks,

-Joe

diff -r b6997dd0667e src/share/classes/sun/tools/jconsole/Tab.java
--- a/src/share/classes/sun/tools/jconsole/Tab.javaTue Apr 01 
09:12:51 2014 -0700
+++ b/src/share/classes/sun/tools/jconsole/Tab.javaTue Apr 01 
18:20:03 2014 -0700

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2004, 2012, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2004, 2014, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -28,6 +28,7 @@
 import java.awt.*;
 import javax.swing.*;

+@SuppressWarnings(serial) // JDK implementation class
 public abstract class Tab extends JPanel {
 private String name;
 private Worker worker;
diff -r b6997dd0667e 
src/share/classes/sun/tools/jconsole/inspector/XOperations.java
--- a/src/share/classes/sun/tools/jconsole/inspector/XOperations.java 
Tue Apr 01 09:12:51 2014 -0700
+++ b/src/share/classes/sun/tools/jconsole/inspector/XOperations.java 
Tue Apr 01 18:20:03 2014 -0700

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2004, 2012, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2004, 2014, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -39,6 +39,7 @@
 import sun.tools.jconsole.JConsole;
 import sun.tools.jconsole.Messages;

+@SuppressWarnings(serial) // JDK implementation class
 public abstract class XOperations extends JPanel implements 
ActionListener {


 public final static String OPERATION_INVOCATION_EVENT =
diff -r b6997dd0667e 
src/share/classes/sun/tools/jconsole/inspector/XTable.java
--- a/src/share/classes/sun/tools/jconsole/inspector/XTable.java Tue Apr 
01 09:12:51 2014 -0700
+++ b/src/share/classes/sun/tools/jconsole/inspector/XTable.java Tue Apr 
01 18:20:03 2014 -0700

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2004, 2012, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2004, 2014, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -33,6 +33,7 @@
 import javax.swing.table.DefaultTableModel;
 import javax.swing.table.TableCellRenderer;

+@SuppressWarnings(serial) // JDK implementation class
 public abstract class XTable extends JTable {
 static final int NAME_COLUMN = 0;
 static final int VALUE_COLUMN = 1;
diff -r b6997dd0667e src/share/classes/sun/tools/jstat/ParserException.java
--- a/src/share/classes/sun/tools/jstat/ParserException.javaTue Apr 
01 09:12:51 2014 -0700
+++ b/src/share/classes/sun/tools/jstat/ParserException.javaTue Apr 
01 18:20:03 2014 -0700

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2004, 2014, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -31,6 +31,7 @@
  * @author Brian Doherty
  * @since 1.5
  */
+@SuppressWarnings(serial) // JDK implementation class
 public class ParserException extends Exception {

 public ParserException() {
diff -r b6997dd0667e src/share/classes/sun/tools/jstat/SyntaxException.java
--- a/src/share/classes/sun/tools/jstat/SyntaxException.javaTue Apr 
01 09:12:51 2014 -0700
+++ b/src/share/classes/sun/tools/jstat/SyntaxException.javaTue Apr 
01 18:20:03 2014 -0700

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2004, 2014, Oracle and/or its affiliates. All rights 
reserved.

  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -36,6 +36,7 @@
  * @author Brian Doherty
  * @since 1.5
  */
+@SuppressWarnings(serial) // JDK implementation class
 public class SyntaxException extends ParserException {
 private String message;