Re: JDK 9 RFR of JDK-8153563: java/nio/Buffer/Basic.java and CopyDirectMemory.java are failing after JDK-8149469
On 06/04/2016 08:59, Amy Lu wrote: Yes :-) Please review the updated patch: http://cr.openjdk.java.net/~amlu/8153563/webrev.01/ Thanks, Amy Looks fine.
Re: JDK 9 RFR of JDK-8153563: java/nio/Buffer/Basic.java and CopyDirectMemory.java are failing after JDK-8149469
On 4/6/16 3:52 PM, Alan Bateman wrote: On 06/04/2016 08:47, Amy Lu wrote: : * * @build Basic + * @modules java.base/jdk.internal.misc * @run main CopyDirectMemory */ It might be clearer to put it before the @build, otherwise looks okay. Yes :-) Please review the updated patch: http://cr.openjdk.java.net/~amlu/8153563/webrev.01/ Thanks, Amy --- old/test/java/nio/Buffer/Basic.java 2016-04-06 15:57:56.0 +0800 +++ new/test/java/nio/Buffer/Basic.java 2016-04-06 15:57:56.0 +0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2015, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2016, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -27,6 +27,7 @@ * 4526177 4463011 4660660 4661219 4663521 4782970 4804304 4938424 6231529 * 6221101 6234263 6535542 6591971 6593946 6795561 7190219 7199551 8065556 * 8149469 + * @modules java.base/jdk.internal.misc * @author Mark Reinhold */ --- old/test/java/nio/Buffer/CopyDirectMemory.java 2016-04-06 15:57:57.0 +0800 +++ new/test/java/nio/Buffer/CopyDirectMemory.java 2016-04-06 15:57:57.0 +0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2002, 2007, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2002, 2016, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -25,6 +25,7 @@ * @summary Test view buffer bulk operations for large buffers. * @bug 4463011 * + * @modules java.base/jdk.internal.misc * @build Basic * @run main CopyDirectMemory */
Re: JDK 9 RFR of JDK-8153563: java/nio/Buffer/Basic.java and CopyDirectMemory.java are failing after JDK-8149469
On 06/04/2016 08:47, Amy Lu wrote: : * * @build Basic + * @modules java.base/jdk.internal.misc * @run main CopyDirectMemory */ It might be clearer to put it before the @build, otherwise looks okay. -Alan
JDK 9 RFR of JDK-8153563: java/nio/Buffer/Basic.java and CopyDirectMemory.java are failing after JDK-8149469
With test/java/nio/Buffer/BasicByte.java change in JDK-8149469, test java/nio/Buffer/Basic.java java/nio/Buffer/CopyDirectMemory.java now requires @modules java.base/jdk.internal.misc Please review the patch. bug: https://bugs.openjdk.java.net/browse/JDK-8153563 webrev: http://cr.openjdk.java.net/~amlu/8153563/webrev.00/ Thanks, Amy --- old/test/java/nio/Buffer/Basic.java 2016-04-06 15:39:19.0 +0800 +++ new/test/java/nio/Buffer/Basic.java 2016-04-06 15:39:19.0 +0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2000, 2015, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2000, 2016, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -27,6 +27,7 @@ * 4526177 4463011 4660660 4661219 4663521 4782970 4804304 4938424 6231529 * 6221101 6234263 6535542 6591971 6593946 6795561 7190219 7199551 8065556 * 8149469 + * @modules java.base/jdk.internal.misc * @author Mark Reinhold */ --- old/test/java/nio/Buffer/CopyDirectMemory.java 2016-04-06 15:39:20.0 +0800 +++ new/test/java/nio/Buffer/CopyDirectMemory.java 2016-04-06 15:39:20.0 +0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2002, 2007, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2002, 2016, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -26,6 +26,7 @@ * @bug 4463011 * * @build Basic + * @modules java.base/jdk.internal.misc * @run main CopyDirectMemory */
