RE: RFR(XS): 8234696: tools/jlink/plugins/VendorInfoPluginsTest.java times out

2019-12-04 Thread Zeller, Arno
Hi Christoph,

thanks for your review and sponsoring!

Best regards,
Arno

> -Original Message-
> From: Langer, Christoph 
> Sent: Mittwoch, 4. Dezember 2019 13:55
> To: Zeller, Arno 
> Cc: core-libs-dev@openjdk.java.net; Mandy Chung
> 
> Subject: RE: RFR(XS): 8234696:
> tools/jlink/plugins/VendorInfoPluginsTest.java times out
> 
> Hi Arno,
> 
> +1
> 
> I'll push it for you.
> 
> Cheers
> Christoph
> 
> > -Original Message-
> > From: core-libs-dev  On Behalf
> > Of Mandy Chung
> > Sent: Mittwoch, 4. Dezember 2019 00:39
> > To: Zeller, Arno 
> > Cc: core-libs-dev@openjdk.java.net
> > Subject: Re: RFR(XS): 8234696:
> > tools/jlink/plugins/VendorInfoPluginsTest.java times out
> >
> > Hi Arno,
> >
> > On 12/3/19 1:13 AM, Zeller, Arno wrote:
> > > Hi all,
> > >
> > > could someone please review this small improvement for the test
> > VendorInfoPluginsTest.java? The change avoids writing a core file and
> might
> > reduce the memory footprint .
> > >
> > > JBS: https://bugs.openjdk.java.net/browse/JDK-8234696
> > > Webrev: http://cr.openjdk.java.net/~azeller/webrevs/8234696.0/
> > >
> >
> > This looks okay.
> >
> > Mandy


RE: RFR(XS): 8234696: tools/jlink/plugins/VendorInfoPluginsTest.java times out

2019-12-04 Thread Zeller, Arno
Hi Mandy,

thanks for your review.

Best regards,
Arno

> -Original Message-
> From: Mandy Chung 
> Sent: Mittwoch, 4. Dezember 2019 00:39
> To: Zeller, Arno 
> Cc: core-libs-dev@openjdk.java.net
> Subject: Re: RFR(XS): 8234696:
> tools/jlink/plugins/VendorInfoPluginsTest.java times out
> 
> Hi Arno,
> 
> On 12/3/19 1:13 AM, Zeller, Arno wrote:
> > Hi all,
> >
> > could someone please review this small improvement for the test
> VendorInfoPluginsTest.java? The change avoids writing a core file and might
> reduce the memory footprint .
> >
> > JBS: https://bugs.openjdk.java.net/browse/JDK-8234696
> > Webrev: http://cr.openjdk.java.net/~azeller/webrevs/8234696.0/
> >
> 
> This looks okay.
> 
> Mandy


RE: RFR(XS): 8234696: tools/jlink/plugins/VendorInfoPluginsTest.java times out

2019-12-04 Thread Langer, Christoph
Hi Arno,

+1

I'll push it for you.

Cheers
Christoph

> -Original Message-
> From: core-libs-dev  On Behalf
> Of Mandy Chung
> Sent: Mittwoch, 4. Dezember 2019 00:39
> To: Zeller, Arno 
> Cc: core-libs-dev@openjdk.java.net
> Subject: Re: RFR(XS): 8234696:
> tools/jlink/plugins/VendorInfoPluginsTest.java times out
> 
> Hi Arno,
> 
> On 12/3/19 1:13 AM, Zeller, Arno wrote:
> > Hi all,
> >
> > could someone please review this small improvement for the test
> VendorInfoPluginsTest.java? The change avoids writing a core file and might
> reduce the memory footprint .
> >
> > JBS: https://bugs.openjdk.java.net/browse/JDK-8234696
> > Webrev: http://cr.openjdk.java.net/~azeller/webrevs/8234696.0/
> >
> 
> This looks okay.
> 
> Mandy


Re: RFR(XS): 8234696: tools/jlink/plugins/VendorInfoPluginsTest.java times out

2019-12-03 Thread Mandy Chung

Hi Arno,

On 12/3/19 1:13 AM, Zeller, Arno wrote:

Hi all,

could someone please review this small improvement for the test 
VendorInfoPluginsTest.java? The change avoids writing a core file and might 
reduce the memory footprint .

JBS: https://bugs.openjdk.java.net/browse/JDK-8234696
Webrev: http://cr.openjdk.java.net/~azeller/webrevs/8234696.0/



This looks okay.

Mandy