Re: RFR: 8024876 : [TEST_BUG] javax/xml/jaxp/parsers/8022548/XOMParserTest.java failed when testbase dir has read only permissions

2013-11-05 Thread Alan Bateman 

On 04/11/2013 22:32, huizhe wang wrote:

:

It's closed, but outFilename was not. Since the behaviors are 
different among parsers, I've added them all in a try-with-resources 
statement.


Please review:
http://cr.openjdk.java.net/~joehw/jdk8/8024876/webrev/

Thanks, that makes it clear.

(I see that 8024876 has already been pushed so this update will need a 
new bug).


-Alan.

Re: RFR: 8024876 : [TEST_BUG] javax/xml/jaxp/parsers/8022548/XOMParserTest.java failed when testbase dir has read only permissions

2013-11-04 Thread Alan Bateman 

On 31/10/2013 19:54, huizhe wang wrote:
A quick fix to remove path for the temporary output file so that it's 
created in the working directory instead:


http://cr.openjdk.java.net/~joehw/jdk8/8024876/webrev/
Just reading this now and wondering about xslFilename - is that closed 
(as it's not obvious)?


-Alan.

Re: RFR: 8024876 : [TEST_BUG] javax/xml/jaxp/parsers/8022548/XOMParserTest.java failed when testbase dir has read only permissions

2013-11-04 Thread huizhe wang 


On 11/4/2013 12:38 AM, Alan Bateman wrote:

On 31/10/2013 19:54, huizhe wang wrote:
A quick fix to remove path for the temporary output file so that it's 
created in the working directory instead:


http://cr.openjdk.java.net/~joehw/jdk8/8024876/webrev/
Just reading this now and wondering about xslFilename - is that closed 
(as it's not obvious)?


It's closed, but outFilename was not. Since the behaviors are different 
among parsers, I've added them all in a try-with-resources statement.


Please review:
http://cr.openjdk.java.net/~joehw/jdk8/8024876/webrev/

Thanks,
Joe


-Alan.

RFR: 8024876 : [TEST_BUG] javax/xml/jaxp/parsers/8022548/XOMParserTest.java failed when testbase dir has read only permissions

2013-10-31 Thread huizhe wang 
A quick fix to remove path for the temporary output file so that it's 
created in the working directory instead:


http://cr.openjdk.java.net/~joehw/jdk8/8024876/webrev/

Thanks,
Joe

Re: RFR: 8024876 : [TEST_BUG] javax/xml/jaxp/parsers/8022548/XOMParserTest.java failed when testbase dir has read only permissions

2013-10-31 Thread Chris Hegarty 

Looks ok to me.

-Chris.

On 10/31/2013 07:54 PM, huizhe wang wrote:

A quick fix to remove path for the temporary output file so that it's
created in the working directory instead:

http://cr.openjdk.java.net/~joehw/jdk8/8024876/webrev/

Thanks,
Joe