RFR: 8028638: java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java fails

2013-11-19 Thread Stuart Marks 

Hi all,

Please review this small fix for an intermittent timeout. Nothing seems to be 
going wrong except that if the machine running the test is exceptionally slow, 
spurious timeouts will occur. The solution is to raise the timeout in the RMI 
test infrastructure.


Bug:
https://bugs.openjdk.java.net/browse/JDK-8028638

Diff:
(appended below)

Thanks,

s'marks


# HG changeset patch
# User smarks
# Date 1384899795 28800
# Node ID ebbfb1b45a4e6b37d339942568a662268dcb18fe
# Parent  67d742c759717ca17518aaadb17725cac85c5897
8028638: 
java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java fails

Reviewed-by: XXX

diff -r 67d742c75971 -r ebbfb1b45a4e test/java/rmi/testlibrary/RMID.java
--- a/test/java/rmi/testlibrary/RMID.java   Tue Nov 19 20:10:58 2013 +0100
+++ b/test/java/rmi/testlibrary/RMID.java   Tue Nov 19 14:23:15 2013 -0800
@@ -74,6 +74,10 @@
 // +
 //  -Djava.security.debug=all ;

+// Set execTimeout to 60 sec (default is 30 sec)
+// to avoid spurious timeouts on slow machines.
+options +=  -Dsun.rmi.activation.execTimeout=6;
+
 return options;
 }

Re: RFR: 8028638: java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java fails

2013-11-19 Thread Lance Andersen - Oracle 
looks fine
On Nov 19, 2013, at 5:24 PM, Stuart Marks wrote:

 Hi all,
 
 Please review this small fix for an intermittent timeout. Nothing seems to be 
 going wrong except that if the machine running the test is exceptionally 
 slow, spurious timeouts will occur. The solution is to raise the timeout in 
 the RMI test infrastructure.
 
 Bug:
   https://bugs.openjdk.java.net/browse/JDK-8028638
 
 Diff:
   (appended below)
 
 Thanks,
 
 s'marks
 
 
 # HG changeset patch
 # User smarks
 # Date 1384899795 28800
 # Node ID ebbfb1b45a4e6b37d339942568a662268dcb18fe
 # Parent  67d742c759717ca17518aaadb17725cac85c5897
 8028638: 
 java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java 
 fails
 Reviewed-by: XXX
 
 diff -r 67d742c75971 -r ebbfb1b45a4e test/java/rmi/testlibrary/RMID.java
 --- a/test/java/rmi/testlibrary/RMID.java Tue Nov 19 20:10:58 2013 +0100
 +++ b/test/java/rmi/testlibrary/RMID.java Tue Nov 19 14:23:15 2013 -0800
 @@ -74,6 +74,10 @@
 // +
 //  -Djava.security.debug=all ;
 
 +// Set execTimeout to 60 sec (default is 30 sec)
 +// to avoid spurious timeouts on slow machines.
 +options +=  -Dsun.rmi.activation.execTimeout=6;
 +
 return options;
 }
 


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com