Re: RFR: 8063147: Class.getFields spec should state that fields are inherited from superinterfaces
On Nov 10, 2014, at 10:43 AM, Paul Sandoz paul.san...@oracle.com wrote: Please shepherd through CCC. Kick started. CCC has been approved, Paul.
Re: RFR: 8063147: Class.getFields spec should state that fields are inherited from superinterfaces
Committed. On Fri, Nov 14, 2014 at 7:53 AM, Paul Sandoz paul.san...@oracle.com wrote: On Nov 10, 2014, at 10:43 AM, Paul Sandoz paul.san...@oracle.com wrote: Please shepherd through CCC. Kick started. CCC has been approved, Paul.
Re: RFR: 8063147: Class.getFields spec should state that fields are inherited from superinterfaces
On Nov 6, 2014, at 8:07 PM, Martin Buchholz marti...@google.com wrote: Sorry, Paul, I missed your offer on the other thread to take this to CCC. It's yours. On Thu, Nov 6, 2014 at 10:50 AM, Martin Buchholz marti...@google.com wrote: Hi Joe, I'd like you to do a code review. https://bugs.openjdk.java.net/browse/JDK-8063147 Webrev: http://cr.openjdk.java.net/~martin/webrevs/openjdk9/Class-getFields-spec/ getFields was embarrassingly undertested, so I added some. Test looks good. Please shepherd through CCC. Kick started. Paul.
Re: RFR: 8063147: Class.getFields spec should state that fields are inherited from superinterfaces
On 10/11/14 09:43, Paul Sandoz wrote: On Nov 6, 2014, at 8:07 PM, Martin Buchholz marti...@google.com wrote: Sorry, Paul, I missed your offer on the other thread to take this to CCC. It's yours. On Thu, Nov 6, 2014 at 10:50 AM, Martin Buchholz marti...@google.com wrote: Hi Joe, I'd like you to do a code review. https://bugs.openjdk.java.net/browse/JDK-8063147 Webrev: http://cr.openjdk.java.net/~martin/webrevs/openjdk9/Class-getFields-spec/ The change looks good to me. getFields was embarrassingly undertested, so I added some. Test looks good. Yes, very nice. Please shepherd through CCC. Kick started. Reviewed. -Chris. Paul.
RFR: 8063147: Class.getFields spec should state that fields are inherited from superinterfaces
Hi Joe, I'd like you to do a code review. https://bugs.openjdk.java.net/browse/JDK-8063147 Webrev: http://cr.openjdk.java.net/~martin/webrevs/openjdk9/Class-getFields-spec/ getFields was embarrassingly undertested, so I added some. Please shepherd through CCC.
Re: RFR: 8063147: Class.getFields spec should state that fields are inherited from superinterfaces
Sorry, Paul, I missed your offer on the other thread to take this to CCC. It's yours. On Thu, Nov 6, 2014 at 10:50 AM, Martin Buchholz marti...@google.com wrote: Hi Joe, I'd like you to do a code review. https://bugs.openjdk.java.net/browse/JDK-8063147 Webrev: http://cr.openjdk.java.net/~martin/webrevs/openjdk9/Class-getFields-spec/ getFields was embarrassingly undertested, so I added some. Please shepherd through CCC.
