Re: RFR: 8235625: [TESTBUG] tools/jpackage/share/JavaOptionsEqualsTest.java fails with debug VMs

2019-12-11 Thread Jie Fu

Thanks Andy for your review.

Done.

Best regards,
Jie



Re: RFR: 8235625: [TESTBUG] tools/jpackage/share/JavaOptionsEqualsTest.java fails with debug VMs

2019-12-11 Thread Andy Herrick

yes - looks good

/Andy

On 12/9/2019 9:26 PM, Jie Fu wrote:

Hi all,

May I get reviews for the small fix?

JBS:    https://bugs.openjdk.java.net/browse/JDK-8235625
Webrev: http://cr.openjdk.java.net/~jiefu/8235625/webrev.00/

Thanks a lot.
Best regards,
Jie



Re: RFR: 8235625: [TESTBUG] tools/jpackage/share/JavaOptionsEqualsTest.java fails with debug VMs

2019-12-11 Thread Jie Fu

Hi Alexey,

Thanks for your review [1].

May I get one more review from a reviewer?

Thanks a lot.
Best regards,
Jie

[1] 
https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-December/063967.html


On 2019/12/10 上午10:26, Jie Fu wrote:

Hi all,

May I get reviews for the small fix?

JBS:    https://bugs.openjdk.java.net/browse/JDK-8235625
Webrev: http://cr.openjdk.java.net/~jiefu/8235625/webrev.00/

Thanks a lot.
Best regards,
Jie





Re: RFR: 8235625: [TESTBUG] tools/jpackage/share/JavaOptionsEqualsTest.java fails with debug VMs

2019-12-10 Thread Alexey Semenyuk

Looks good.

- Alexey

On 12/9/2019 9:26 PM, Jie Fu wrote:

Hi all,

May I get reviews for the small fix?

JBS:    https://bugs.openjdk.java.net/browse/JDK-8235625
Webrev: http://cr.openjdk.java.net/~jiefu/8235625/webrev.00/

Thanks a lot.
Best regards,
Jie





RFR: 8235625: [TESTBUG] tools/jpackage/share/JavaOptionsEqualsTest.java fails with debug VMs

2019-12-09 Thread Jie Fu

Hi all,

May I get reviews for the small fix?

JBS:    https://bugs.openjdk.java.net/browse/JDK-8235625
Webrev: http://cr.openjdk.java.net/~jiefu/8235625/webrev.00/

Thanks a lot.
Best regards,
Jie