Re: RFR: 8240349: jlink should not leave partial image output directory on failure [v2]
On Tue, 8 Jun 2021 14:29:38 GMT, Athijegannathan Sundararajan wrote: >> jlink should clean up output directory on any failure. should not leave >> partially filled output. > > Athijegannathan Sundararajan has updated the pull request incrementally with > one additional commit since the last revision: > > Fixed resouce closing issue for lib/moduls file. Pre-existing output > directory should not be deleted when exiting. New version looks good. Good spot by Jorn that ImageFileCreator wasn't closing. - Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4386
Re: RFR: 8240349: jlink should not leave partial image output directory on failure [v2]
On Tue, 8 Jun 2021 14:29:38 GMT, Athijegannathan Sundararajan wrote: >> jlink should clean up output directory on any failure. should not leave >> partially filled output. > > Athijegannathan Sundararajan has updated the pull request incrementally with > one additional commit since the last revision: > > Fixed resouce closing issue for lib/moduls file. Pre-existing output > directory should not be deleted when exiting. Marked as reviewed by jlaskey (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4386
Re: RFR: 8240349: jlink should not leave partial image output directory on failure [v2]
> jlink should clean up output directory on any failure. should not leave > partially filled output. Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision: Fixed resouce closing issue for lib/moduls file. Pre-existing output directory should not be deleted when exiting. - Changes: - all: https://git.openjdk.java.net/jdk/pull/4386/files - new: https://git.openjdk.java.net/jdk/pull/4386/files/f12e6a29..df036a3a Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=4386=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=4386=00-01 Stats: 48 lines in 5 files changed: 22 ins; 12 del; 14 mod Patch: https://git.openjdk.java.net/jdk/pull/4386.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4386/head:pull/4386 PR: https://git.openjdk.java.net/jdk/pull/4386
