Re: RFR: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside [v5]
On Fri, 30 Jul 2021 15:43:52 GMT, Lance Andersen wrote:
>> Hi,
>>
>> As discussed in the
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079621.html
>> thread, this is the revised patch to address the use of '.' and '..' within
>> Zip FS
>>
>> Zip FS needs to use "." and ".." as links to the current and parent
>> directories and cannot reliably support entries that have "." and ".." as
>> name elements. This patch updates Zip Fs to reject ZIP files that have
>> entries in the CEN that can't be used for files in a file system.
>>
>>
>> Mach5 tiers 1 through 3 have been run without any errors encountered .
>>
>> Best,
>> Lance
>
> Lance Andersen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update note added to Zip FS module-info
Looks good to me.
test/jdk/jdk/nio/zipfs/HasDotDotTest.java line 116:
> 114: @Test(dataProvider = "checkForDotOrDotDotPaths")
> 115: public void hasDotOrDotDotTest(String path) throws IOException {
> 116: if(DEBUG) {
Nit: space after `if`
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4900
Re: RFR: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside [v5]
> Hi, > > As discussed in the > https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079621.html > thread, this is the revised patch to address the use of '.' and '..' within > Zip FS > > Zip FS needs to use "." and ".." as links to the current and parent > directories and cannot reliably support entries that have "." and ".." as > name elements. This patch updates Zip Fs to reject ZIP files that have > entries in the CEN that can't be used for files in a file system. > > > Mach5 tiers 1 through 3 have been run without any errors encountered . > > Best, > Lance Lance Andersen has updated the pull request incrementally with one additional commit since the last revision: Update note added to Zip FS module-info - Changes: - all: https://git.openjdk.java.net/jdk/pull/4900/files - new: https://git.openjdk.java.net/jdk/pull/4900/files/67c726af..0bf065ea Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=4900=04 - incr: https://webrevs.openjdk.java.net/?repo=jdk=4900=03-04 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/4900.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4900/head:pull/4900 PR: https://git.openjdk.java.net/jdk/pull/4900
