Re: RFR: 8252730: jlink does not create reproducible builds on different servers [v2]

2020-09-15 Thread Ian Graves 
On Tue, 15 Sep 2020 09:32:33 GMT, Daniel Fuchs  wrote:

>> Ian Graves has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Merging streams
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageFileCreator.java 
> line 41:
> 
>> 39: import java.util.Objects;
>> 40: import java.util.Set;
>> 41: import java.util.Comparator;
> 
> nit: `Comparator` might no longer be needed? I don't see where it's used.

Yep. Looks like it's a leftover. Thanks!

-

PR: https://git.openjdk.java.net/jdk/pull/156

Re: RFR: 8252730: jlink does not create reproducible builds on different servers [v2]

2020-09-15 Thread Daniel Fuchs 
On Mon, 14 Sep 2020 22:57:44 GMT, Ian Graves  wrote:

>> Related to [JDK-8252730 jlink does not create reproducible builds on 
>> different
>> servers](https://bugs.openjdk.java.net/browse/JDK-8252730). Introduces 
>> ordering based on `Archive` module names to
>> ensure stable files (and file signatures) across generated JDK images by 
>> jlink.
>
> Ian Graves has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Merging streams

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageFileCreator.java line 
41:

> 39: import java.util.Objects;
> 40: import java.util.Set;
> 41: import java.util.Comparator;

nit: `Comparator` might no longer be needed? I don't see where it's used.

-

PR: https://git.openjdk.java.net/jdk/pull/156

Re: RFR: 8252730: jlink does not create reproducible builds on different servers [v2]

2020-09-15 Thread Alan Bateman 
On Mon, 14 Sep 2020 22:54:34 GMT, Ian Graves  wrote:

>> Looks good to me.
>
> Updated to merge streams in line with @stuart-marks suggestion.

There are several existing jlink tests that check that generated lib/modules is 
reproducible. Can we do more in these
tests or add a new test that would improve the chances of finding issues, e.g. 
using jlink to create a JDK that
includes the jlink tool and the packaged modules, copy it to two locations and 
run the jlink in both run-time images to
see if they produce the same bits.

-

PR: https://git.openjdk.java.net/jdk/pull/156

Re: RFR: 8252730: jlink does not create reproducible builds on different servers [v2]

2020-09-14 Thread Ian Graves 
On Mon, 14 Sep 2020 22:03:02 GMT, Mandy Chung  wrote:

>> Ian Graves has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Merging streams
>
> Looks good to me.

Updated to merge streams in line with @stuart-marks suggestion.

-

PR: https://git.openjdk.java.net/jdk/pull/156

Re: RFR: 8252730: jlink does not create reproducible builds on different servers [v2]

2020-09-14 Thread Ian Graves 
> Related to [JDK-8252730 jlink does not create reproducible builds on different
> servers](https://bugs.openjdk.java.net/browse/JDK-8252730). Introduces 
> ordering based on `Archive` module names to
> ensure stable files (and file signatures) across generated JDK images by 
> jlink.

Ian Graves has updated the pull request incrementally with one additional 
commit since the last revision:

  Merging streams

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/156/files
  - new: https://git.openjdk.java.net/jdk/pull/156/files/122bbdfc..ef3eacec

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=156=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=156=00-01

  Stats: 6 lines in 1 file changed: 0 ins; 1 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/156.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/156/head:pull/156

PR: https://git.openjdk.java.net/jdk/pull/156