Re: RFR: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
On Tue, 15 Sep 2020 07:47:54 GMT, Christoph Langer wrote: > There are some little flaws in LdapDNSProvider and auxilliary classes, mostly > in Javadoc. > > In detail: > src/java.naming/share/classes/com/sun/jndi/ldap/DefaultLdapDnsProvider.java: > Unnecessary import > src/java.naming/share/classes/com/sun/jndi/ldap/LdapDnsProviderService.java: > typo > src/java.naming/share/classes/javax/naming/ldap/spi/LdapDnsProvider.java: > Whitespace > src/java.naming/share/classes/javax/naming/ldap/spi/LdapDnsProviderResult.java: > Spelling of "ldap" -> should be > capitalized Looks okay, no semantic changes. - Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/168
Re: RFR: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
On Tue, 15 Sep 2020 09:39:29 GMT, Daniel Fuchs wrote: >> There are some little flaws in LdapDNSProvider and auxilliary classes, >> mostly in Javadoc. >> >> In detail: >> src/java.naming/share/classes/com/sun/jndi/ldap/DefaultLdapDnsProvider.java: >> Unnecessary import >> src/java.naming/share/classes/com/sun/jndi/ldap/LdapDnsProviderService.java: >> typo >> src/java.naming/share/classes/javax/naming/ldap/spi/LdapDnsProvider.java: >> Whitespace >> src/java.naming/share/classes/javax/naming/ldap/spi/LdapDnsProviderResult.java: >> Spelling of "ldap" -> should be >> capitalized > > Hi Christoph, > > The changes look good to me. > > best regards, > > -- daniel Hi Christoph, Looks good to me. Kind Regards, Aleksei - PR: https://git.openjdk.java.net/jdk/pull/168
Re: RFR: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
On Tue, 15 Sep 2020 07:47:54 GMT, Christoph Langer wrote: > There are some little flaws in LdapDNSProvider and auxilliary classes, mostly > in Javadoc. > > In detail: > src/java.naming/share/classes/com/sun/jndi/ldap/DefaultLdapDnsProvider.java: > Unnecessary import > src/java.naming/share/classes/com/sun/jndi/ldap/LdapDnsProviderService.java: > typo > src/java.naming/share/classes/javax/naming/ldap/spi/LdapDnsProvider.java: > Whitespace > src/java.naming/share/classes/javax/naming/ldap/spi/LdapDnsProviderResult.java: > Spelling of "ldap" -> should be > capitalized Marked as reviewed by aefimov (Committer). - PR: https://git.openjdk.java.net/jdk/pull/168
Re: RFR: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
On Tue, 15 Sep 2020 07:47:54 GMT, Christoph Langer wrote: > There are some little flaws in LdapDNSProvider and auxilliary classes, mostly > in Javadoc. > > In detail: > src/java.naming/share/classes/com/sun/jndi/ldap/DefaultLdapDnsProvider.java: > Unnecessary import > src/java.naming/share/classes/com/sun/jndi/ldap/LdapDnsProviderService.java: > typo > src/java.naming/share/classes/javax/naming/ldap/spi/LdapDnsProvider.java: > Whitespace > src/java.naming/share/classes/javax/naming/ldap/spi/LdapDnsProviderResult.java: > Spelling of "ldap" -> should be > capitalized Hi Christoph, The changes look good to me. best regards, -- daniel - Marked as reviewed by dfuchs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/168
Re: RFR: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
Hi Christoph, Changes look ok to me. On Tue, Sep 15, 2020 at 1:26 PM Christoph Langer wrote: > There are some little flaws in LdapDNSProvider and auxilliary classes, > mostly in Javadoc. > > In detail: > src/java.naming/share/classes/com/sun/jndi/ldap/DefaultLdapDnsProvider.java: > Unnecessary import > src/java.naming/share/classes/com/sun/jndi/ldap/LdapDnsProviderService.java: > typo > src/java.naming/share/classes/javax/naming/ldap/spi/LdapDnsProvider.java: > Whitespace > src/java.naming/share/classes/javax/naming/ldap/spi/LdapDnsProviderResult.java: > Spelling of "ldap" -> should be > capitalized > > - > > Commit messages: > - JDK-8253155 > > Changes: https://git.openjdk.java.net/jdk/pull/168/files > Webrev: https://webrevs.openjdk.java.net/?repo=jdk=168=00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8253155 > Stats: 21 lines in 4 files changed: 3 ins; 7 del; 11 mod > Patch: https://git.openjdk.java.net/jdk/pull/168.diff > Fetch: git fetch https://git.openjdk.java.net/jdk pull/168/head:pull/168 > > PR: https://git.openjdk.java.net/jdk/pull/168 > -- Thanks, Vyom
RFR: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
There are some little flaws in LdapDNSProvider and auxilliary classes, mostly in Javadoc. In detail: src/java.naming/share/classes/com/sun/jndi/ldap/DefaultLdapDnsProvider.java: Unnecessary import src/java.naming/share/classes/com/sun/jndi/ldap/LdapDnsProviderService.java: typo src/java.naming/share/classes/javax/naming/ldap/spi/LdapDnsProvider.java: Whitespace src/java.naming/share/classes/javax/naming/ldap/spi/LdapDnsProviderResult.java: Spelling of "ldap" -> should be capitalized - Commit messages: - JDK-8253155 Changes: https://git.openjdk.java.net/jdk/pull/168/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=168=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253155 Stats: 21 lines in 4 files changed: 3 ins; 7 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/168.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/168/head:pull/168 PR: https://git.openjdk.java.net/jdk/pull/168
