Re: RFR: 8259074: regex benchmarks and tests [v5]
On Tue, 2 Feb 2021 13:10:29 GMT, Claes Redestad wrote: >> Martin Buchholz has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix imports > > Marked as reviewed by redestad (Reviewer). @cl4es Your comment sent me back to jmh re-education camp. I never looked at warmup iterations numbers before, but I now see they can be very useful for eyeballing how long warmup takes. Very JVM-dependent of course. In practice I will stick with my rule of thumb that 10 seconds of warmup is good enough for any simple program, and that happens to be the JMH warmup time default. OTOH I think more than one warmup iteration is overkill for most benchmarks. - PR: https://git.openjdk.java.net/jdk/pull/1940
Re: RFR: 8259074: regex benchmarks and tests [v5]
On Tue, 2 Feb 2021 03:07:08 GMT, Martin Buchholz wrote: >> 8259074: regex benchmarks and tests > > Martin Buchholz has updated the pull request incrementally with one > additional commit since the last revision: > > fix imports Marked as reviewed by redestad (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1940
Re: RFR: 8259074: regex benchmarks and tests [v5]
> 8259074: regex benchmarks and tests Martin Buchholz has updated the pull request incrementally with one additional commit since the last revision: fix imports - Changes: - all: https://git.openjdk.java.net/jdk/pull/1940/files - new: https://git.openjdk.java.net/jdk/pull/1940/files/89638833..2f688a41 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=1940=04 - incr: https://webrevs.openjdk.java.net/?repo=jdk=1940=03-04 Stats: 8 lines in 1 file changed: 0 ins; 7 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/1940.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1940/head:pull/1940 PR: https://git.openjdk.java.net/jdk/pull/1940
