Re: RFR: 8260621: (jrtfs) ThreadLocal memory leak in ImageBufferCache when using jrtfs

2021-05-05 Thread Alan Bateman 
On Tue, 4 May 2021 09:05:38 GMT, Athijegannathan Sundararajan 
 wrote:

> Instead of BufferReference class, Map.Entry is used as pair implementation.
> This avoids the metaspace leak seen via thread local.

src/java.base/share/classes/jdk/internal/jimage/ImageBufferCache.java line 46:

> 44: 
> 45: /*
> 46:  * We used to have a class BufferReference extending from 
> WeakReference.

I think this comment needs to be re-worded to drop "We used to have ...", 
"Solution is ..." and the other history. Instead it should provide a clear 
paragraph that explains the value of the TL for anyone reading this code.

-

PR: https://git.openjdk.java.net/jdk/pull/3849

Re: RFR: 8260621: (jrtfs) ThreadLocal memory leak in ImageBufferCache when using jrtfs

2021-05-04 Thread Vyom Tewari 
On Tue, 4 May 2021 09:05:38 GMT, Athijegannathan Sundararajan 
 wrote:

> Instead of BufferReference class, Map.Entry is used as pair implementation.
> This avoids the metaspace leak seen via thread local.

looks OK to me.

-

Marked as reviewed by vtewari (Committer).

PR: https://git.openjdk.java.net/jdk/pull/3849

Re: RFR: 8260621: (jrtfs) ThreadLocal memory leak in ImageBufferCache when using jrtfs

2021-05-04 Thread Jim Laskey 
On Tue, 4 May 2021 09:05:38 GMT, Athijegannathan Sundararajan 
 wrote:

> Instead of BufferReference class, Map.Entry is used as pair implementation.
> This avoids the metaspace leak seen via thread local.

Marked as reviewed by jlaskey (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/3849

RFR: 8260621: (jrtfs) ThreadLocal memory leak in ImageBufferCache when using jrtfs

2021-05-04 Thread Athijegannathan Sundararajan 
Instead of BufferReference class, Map.Entry is used as pair implementation.
This avoids the metaspace leak seen via thread local.

-

Commit messages:
 - added comment. generics cleanup.
 - 8260621: (jrtfs) ThreadLocal memory leak in ImageBufferCache when using jrtfs

Changes: https://git.openjdk.java.net/jdk/pull/3849/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3849=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8260621
  Stats: 57 lines in 1 file changed: 30 ins; 7 del; 20 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3849.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3849/head:pull/3849

PR: https://git.openjdk.java.net/jdk/pull/3849