Re: RFR: 8261673: Move javadoc for the lookup mechanism to module-info [v2]
On Tue, 16 Mar 2021 21:39:26 GMT, Joe Wang wrote: >> Consolidate and move javadoc for the lookup mechanism to the module summary. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Fix typos: s/XMLEventFactory/XMLInputFactory > s/XMLEventFactory/XMLOutputFactory Nice consolidation. I've added myself as a reviewer of the CSR too. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3020
Re: RFR: 8261673: Move javadoc for the lookup mechanism to module-info [v2]
On Tue, 16 Mar 2021 16:59:47 GMT, Naoto Sato wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typos: s/XMLEventFactory/XMLInputFactory
>> s/XMLEventFactory/XMLOutputFactory
>
> src/java.xml/share/classes/javax/xml/stream/XMLInputFactory.java line 172:
>
>> 170:* Creates a new instance of the factory. This method uses the
>> 171:* JAXP Lookup
>> Mechanism
>> 172:* to determine the {@code XMLEventFactory} implementation class to
>> load.
>
> Should it be `XMLInputFactory`?
Fixed. Updated CSR as well.
> src/java.xml/share/classes/javax/xml/stream/XMLOutputFactory.java line 149:
>
>> 147:* Creates a new instance of the factory. This method uses the
>> 148:* JAXP Lookup
>> Mechanism
>> 149:* to determine the {@code XMLEventFactory} implementation class to
>> load.
>
> And this one as `XMLOutputFactory`?
Fixed. Thanks.
-
PR: https://git.openjdk.java.net/jdk/pull/3020
Re: RFR: 8261673: Move javadoc for the lookup mechanism to module-info [v2]
On Tue, 16 Mar 2021 21:39:26 GMT, Joe Wang wrote: >> Consolidate and move javadoc for the lookup mechanism to the module summary. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Fix typos: s/XMLEventFactory/XMLInputFactory > s/XMLEventFactory/XMLOutputFactory Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3020
Re: RFR: 8261673: Move javadoc for the lookup mechanism to module-info [v2]
On Tue, 16 Mar 2021 21:36:40 GMT, Joe Wang wrote: >> Consolidate and move javadoc for the lookup mechanism to the module summary. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Fix typos: s/XMLEventFactory/XMLInputFactory > s/XMLEventFactory/XMLOutputFactory Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3020
Re: RFR: 8261673: Move javadoc for the lookup mechanism to module-info [v2]
> Consolidate and move javadoc for the lookup mechanism to the module summary. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: Fix typos: s/XMLEventFactory/XMLInputFactory s/XMLEventFactory/XMLOutputFactory - Changes: - all: https://git.openjdk.java.net/jdk/pull/3020/files - new: https://git.openjdk.java.net/jdk/pull/3020/files/9884e8ce..5554c8df Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=3020=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3020=00-01 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/3020.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3020/head:pull/3020 PR: https://git.openjdk.java.net/jdk/pull/3020
Re: RFR: 8261673: Move javadoc for the lookup mechanism to module-info
On Tue, 16 Mar 2021 00:52:24 GMT, Joe Wang wrote:
> Consolidate and move javadoc for the lookup mechanism to the module summary.
src/java.xml/share/classes/javax/xml/stream/XMLInputFactory.java line 172:
> 170:* Creates a new instance of the factory. This method uses the
> 171:* JAXP Lookup
> Mechanism
> 172:* to determine the {@code XMLEventFactory} implementation class to
> load.
Should it be `XMLInputFactory`?
src/java.xml/share/classes/javax/xml/stream/XMLOutputFactory.java line 149:
> 147:* Creates a new instance of the factory. This method uses the
> 148:* JAXP Lookup
> Mechanism
> 149:* to determine the {@code XMLEventFactory} implementation class to
> load.
And this one as `XMLOutputFactory`?
-
PR: https://git.openjdk.java.net/jdk/pull/3020
Re: RFR: 8261673: Move javadoc for the lookup mechanism to module-info
On Tue, 16 Mar 2021 00:52:24 GMT, Joe Wang wrote: > Consolidate and move javadoc for the lookup mechanism to the module summary. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3020
RFR: 8261673: Move javadoc for the lookup mechanism to module-info
Consolidate and move javadoc for the lookup mechanism to the module summary. - Commit messages: - 8261673: Move javadoc for the lookup mechanism to module-info Changes: https://git.openjdk.java.net/jdk/pull/3020/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3020=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8261673 Stats: 602 lines in 9 files changed: 197 ins; 361 del; 44 mod Patch: https://git.openjdk.java.net/jdk/pull/3020.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3020/head:pull/3020 PR: https://git.openjdk.java.net/jdk/pull/3020
