Re: RFR: 8263890: Broken links to Unicode.org [v2]
On Fri, 19 Mar 2021 21:23:03 GMT, Naoto Sato wrote: >> Fixed several broken links to Unicode.org. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed review comments. Looks all good. Thanks Naoto. - Marked as reviewed by joehw (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3093
Re: RFR: 8263890: Broken links to Unicode.org [v2]
On Fri, 19 Mar 2021 18:43:30 GMT, Joe Wang wrote: > Some minor comments. Thanks, Joe. Addressed them as suggested. - PR: https://git.openjdk.java.net/jdk/pull/3093
Re: RFR: 8263890: Broken links to Unicode.org [v2]
> Fixed several broken links to Unicode.org. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Addressed review comments. - Changes: - all: https://git.openjdk.java.net/jdk/pull/3093/files - new: https://git.openjdk.java.net/jdk/pull/3093/files/2b32b86a..37093a4d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=3093=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3093=00-01 Stats: 24 lines in 6 files changed: 4 ins; 0 del; 20 mod Patch: https://git.openjdk.java.net/jdk/pull/3093.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3093/head:pull/3093 PR: https://git.openjdk.java.net/jdk/pull/3093
Re: RFR: 8263890: Broken links to Unicode.org
On Fri, 19 Mar 2021 17:57:31 GMT, Naoto Sato wrote: > Fixed several broken links to Unicode.org. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3093
Re: RFR: 8263890: Broken links to Unicode.org
On Fri, 19 Mar 2021 17:57:31 GMT, Naoto Sato wrote: > Fixed several broken links to Unicode.org. Some minor comments. src/java.base/share/classes/java/text/Collator.java line 211: > 209: * FULL_DECOMPOSITION corresponds to Normalization Form KD as > 210: * described in > 211: * http://www.unicode.org/reports/tr15/tr15-23.html;>Unicode While the previous "Unicode Technical Report #15" was in http://unicode.org/reports/tr15/tr15-15.html, by tr15-23 it was "approved by the Unicode Technical Committee as a Unicode Standard Annex". Do we want to change the title to "Unicode Standard Annex #15"? Also, is Collator stuck with a particular revision (e.g. 23) or do we refer to the latest, e.g. "http://www.unicode.org/reports/tr15/;? src/java.base/share/classes/jdk/internal/icu/text/BidiLine.java line 50: > 48: * which has already been processed according to > 49: * the Unicode 3.0 Bidi algorithm as defined in > 50: * http://www.unicode.org/reports/tr9/ , version 13, Previous references provided links e.g. "http://www.unicode.org/unicode/reports/tr9/;>Unicode Standard Annex #9" instead of URL. src/java.base/share/classes/jdk/internal/icu/text/Normalizer2.java line 46: > 44: * a string is already normalized. > 45: * The most commonly used normalization forms are those defined in > 46: * http://www.unicode.org/reports/tr15/ Same as above. src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/RegularExpression.java line 476: > 474: * TODO > 475: * > 476: * http://www.unicode.org/reports/tr18/;>Unicode Regular > Expression Guidelines Just a note that the references had been report numbers, e.g. Report/Annex #15, while this one the Title (by the way, the official title was "Unicode Regular Expressions"). The only exception seems to be the one in NormalizerBase.java where it referred to the number + title. - Marked as reviewed by joehw (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3093
Re: RFR: 8263890: Broken links to Unicode.org
On Fri, 19 Mar 2021 17:57:31 GMT, Naoto Sato wrote: > Fixed several broken links to Unicode.org. Marked as reviewed by redestad (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3093
RFR: 8263890: Broken links to Unicode.org
Fixed several broken links to Unicode.org. - Commit messages: - 8263890: Broken links to Unicode.org Changes: https://git.openjdk.java.net/jdk/pull/3093/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3093=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263890 Stats: 22 lines in 8 files changed: 0 ins; 0 del; 22 mod Patch: https://git.openjdk.java.net/jdk/pull/3093.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3093/head:pull/3093 PR: https://git.openjdk.java.net/jdk/pull/3093
