Re: RFR: 8264208: Console charset API [v8]
On Thu, 15 Apr 2021 14:17:11 GMT, Alan Bateman wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added @see links.
>
> src/java.base/share/classes/java/io/Console.java line 397:
>
>> 395: /**
>> 396: * Returns the {@link java.nio.charset.Charset Charset} object used
>> in
>> 397: * the {@code Console}.
>
> What would you think about re-phrasing the first sentence to use "for the
> Console" rather than "in the Console".
Changed to "for the Console", as well as `@return`.
> src/java.base/share/classes/java/lang/System.java line 123:
>
>> 121: *
>> 122: * @see Console#charset()
>> 123: * @see Console#reader()
>
> What would you think about changing the example in InputStreamReader class
> description as part of this?
Replaced `System.in` with generic `anInputStream`, as changing `new
InputStreamReader` with `Console.reader()` would defy the purpose of the
example.
-
PR: https://git.openjdk.java.net/jdk/pull/3419
Re: RFR: 8264208: Console charset API [v8]
On Wed, 14 Apr 2021 17:17:03 GMT, Naoto Sato wrote:
>> Please review the changes for the subject issue. This has been suggested in
>> a recent discussion thread for the JEP 400
>> [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)].
>> A CSR has also been drafted, and comments are welcome
>> [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)].
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added @see links.
src/java.base/share/classes/java/io/Console.java line 397:
> 395: /**
> 396: * Returns the {@link java.nio.charset.Charset Charset} object used
> in
> 397: * the {@code Console}.
What would you think about re-phrasing the first sentence to use "for the
Console" rather than "in the Console".
src/java.base/share/classes/java/lang/System.java line 123:
> 121: *
> 122: * @see Console#charset()
> 123: * @see Console#reader()
What would you think about changing the example in InputStreamReader class
description as part of this?
-
PR: https://git.openjdk.java.net/jdk/pull/3419
Re: RFR: 8264208: Console charset API [v8]
> Please review the changes for the subject issue. This has been suggested in > a recent discussion thread for the JEP 400 > [[1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075214.html)]. > A CSR has also been drafted, and comments are welcome > [[2](https://bugs.openjdk.java.net/browse/JDK-8264209)]. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Added @see links. - Changes: - all: https://git.openjdk.java.net/jdk/pull/3419/files - new: https://git.openjdk.java.net/jdk/pull/3419/files/45ab77b3..5988f600 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=3419=07 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3419=06-07 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/3419.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3419/head:pull/3419 PR: https://git.openjdk.java.net/jdk/pull/3419
