Re: RFR: 8265019 : Update tests for additional TestNG test permissions [v2]

2021-04-14 Thread Lance Andersen 



On Apr 14, 2021, at 2:13 AM, Alan Bateman 
mailto:al...@openjdk.java.net>> wrote:

On Tue, 13 Apr 2021 18:56:22 GMT, Lance Andersen 
mailto:lan...@openjdk.org>> wrote:

Hi all,

Please review the following patch which adds additional permissions needed for 
when JTREG upgrades to a newer version of TestNG.

Best,
Lance

Lance Andersen has updated the pull request incrementally with one additional 
commit since the last revision:

 TestNG updates Permission re-organization

Marked as reviewed by alanb (Reviewer).

test/jdk/java/sql/testng/util/TestPolicy.java line 27:

25: import java.io.FilePermission;
26: import java.lang.reflect.ReflectPermission;
27: import java.security.*;

My guess is that you didn't mean the change the import.

Intellij did that automagically.  I just reverted the change for consistency

-

PR: https://git.openjdk.java.net/jdk/pull/3471

[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com

Re: RFR: 8265019 : Update tests for additional TestNG test permissions [v2]

2021-04-14 Thread Alan Bateman 
On Tue, 13 Apr 2021 18:56:22 GMT, Lance Andersen  wrote:

>> Hi all,
>> 
>> Please review the following patch which adds additional permissions needed 
>> for when JTREG upgrades to a newer version of TestNG.
>> 
>> Best,
>> Lance
>
> Lance Andersen has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   TestNG updates Permission re-organization

Marked as reviewed by alanb (Reviewer).

test/jdk/java/sql/testng/util/TestPolicy.java line 27:

> 25: import java.io.FilePermission;
> 26: import java.lang.reflect.ReflectPermission;
> 27: import java.security.*;

My guess is that you didn't mean the change the import.

-

PR: https://git.openjdk.java.net/jdk/pull/3471

Re: RFR: 8265019 : Update tests for additional TestNG test permissions [v2]

2021-04-13 Thread Brian Burkhalter 
On Tue, 13 Apr 2021 18:56:22 GMT, Lance Andersen  wrote:

>> Hi all,
>> 
>> Please review the following patch which adds additional permissions needed 
>> for when JTREG upgrades to a newer version of TestNG.
>> 
>> Best,
>> Lance
>
> Lance Andersen has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   TestNG updates Permission re-organization

Marked as reviewed by bpb (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/3471

Re: RFR: 8265019 : Update tests for additional TestNG test permissions [v2]

2021-04-13 Thread Naoto Sato 
On Tue, 13 Apr 2021 18:56:22 GMT, Lance Andersen  wrote:

>> Hi all,
>> 
>> Please review the following patch which adds additional permissions needed 
>> for when JTREG upgrades to a newer version of TestNG.
>> 
>> Best,
>> Lance
>
> Lance Andersen has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   TestNG updates Permission re-organization

Looks good.

-

Marked as reviewed by naoto (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3471

Re: RFR: 8265019 : Update tests for additional TestNG test permissions [v2]

2021-04-13 Thread Lance Andersen 
> Hi all,
> 
> Please review the following patch which adds additional permissions needed 
> for when JTREG upgrades to a newer version of TestNG.
> 
> Best,
> Lance

Lance Andersen has updated the pull request incrementally with one additional 
commit since the last revision:

  TestNG updates Permission re-organization

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3471/files
  - new: https://git.openjdk.java.net/jdk/pull/3471/files/0183f88b..20ef2bd0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=3471=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3471=00-01

  Stats: 20 lines in 2 files changed: 10 ins; 10 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3471.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3471/head:pull/3471

PR: https://git.openjdk.java.net/jdk/pull/3471