Re: RFR: 8267357: build breaks with -Werror option on micro benchmark added for JDK-8256973

2021-05-19 Thread Tobias Hartmann 
On Wed, 19 May 2021 08:20:13 GMT, Jatin Bhateja  wrote:

> Relevant declarations modified and tested with -Werror, no longer see 
> unchecked conversion warnings.
> 
> Kindly review and approve.

Marked as reviewed by thartmann (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/4108

Re: RFR: 8267357: build breaks with -Werror option on micro benchmark added for JDK-8256973

2021-05-19 Thread Nils Eliasson 
On Wed, 19 May 2021 08:20:13 GMT, Jatin Bhateja  wrote:

> Relevant declarations modified and tested with -Werror, no longer see 
> unchecked conversion warnings.
> 
> Kindly review and approve.

Looks good.

-

Marked as reviewed by neliasso (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4108

Re: RFR: 8267357: build breaks with -Werror option on micro benchmark added for JDK-8256973

2021-05-19 Thread Jie Fu 
On Wed, 19 May 2021 08:20:13 GMT, Jatin Bhateja  wrote:

> Relevant declarations modified and tested with -Werror, no longer see 
> unchecked conversion warnings.
> 
> Kindly review and approve.

LGTM

-

Marked as reviewed by jiefu (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4108

RFR: 8267357: build breaks with -Werror option on micro benchmark added for JDK-8256973

2021-05-19 Thread Jatin Bhateja 
Relevant declarations modified and tested with -Werror, no longer see unchecked 
conversion warnings.

Kindly review and approve.

-

Commit messages:
 - 8267357: build breaks with -Werror option on micro benchmark added for 
JDK-8256973

Changes: https://git.openjdk.java.net/jdk/pull/4108/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4108=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8267357
  Stats: 10 lines in 1 file changed: 0 ins; 1 del; 9 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4108.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4108/head:pull/4108

PR: https://git.openjdk.java.net/jdk/pull/4108