Re: RFR: 8268469: Update java.time to use switch expressions [v4]
On Tue, 22 Jun 2021 09:58:55 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.time` >> packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - 8268469: Removed alignment of arrow operators in some cases; reverted > logic of switch/case in LocalDate > - Merge remote-tracking branch 'origin/master' into JDK-8268469 > - 8268469: Removed excessive spacing; corrected misplaced comments > - Merge remote-tracking branch 'origin/master' into JDK-8268469 > - Merge remote-tracking branch 'origin/master' into JDK-8268469 > - 8268469: Update java.time to use switch expressions Marked as reviewed by chegar (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4433
Re: RFR: 8268469: Update java.time to use switch expressions [v4]
On Tue, 22 Jun 2021 09:58:55 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.time` >> packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - 8268469: Removed alignment of arrow operators in some cases; reverted > logic of switch/case in LocalDate > - Merge remote-tracking branch 'origin/master' into JDK-8268469 > - 8268469: Removed excessive spacing; corrected misplaced comments > - Merge remote-tracking branch 'origin/master' into JDK-8268469 > - Merge remote-tracking branch 'origin/master' into JDK-8268469 > - 8268469: Update java.time to use switch expressions Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4433
Re: RFR: 8268469: Update java.time to use switch expressions [v4]
On Tue, 22 Jun 2021 09:58:55 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.time` >> packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - 8268469: Removed alignment of arrow operators in some cases; reverted > logic of switch/case in LocalDate > - Merge remote-tracking branch 'origin/master' into JDK-8268469 > - 8268469: Removed excessive spacing; corrected misplaced comments > - Merge remote-tracking branch 'origin/master' into JDK-8268469 > - Merge remote-tracking branch 'origin/master' into JDK-8268469 > - 8268469: Update java.time to use switch expressions Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4433
Re: RFR: 8268469: Update java.time to use switch expressions [v4]
On Tue, 22 Jun 2021 09:58:55 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.time` >> packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - 8268469: Removed alignment of arrow operators in some cases; reverted > logic of switch/case in LocalDate > - Merge remote-tracking branch 'origin/master' into JDK-8268469 > - 8268469: Removed excessive spacing; corrected misplaced comments > - Merge remote-tracking branch 'origin/master' into JDK-8268469 > - Merge remote-tracking branch 'origin/master' into JDK-8268469 > - 8268469: Update java.time to use switch expressions Marked as reviewed by dfuchs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4433
Re: RFR: 8268469: Update java.time to use switch expressions [v4]
> Hi, > > Could someone please review my code for updating the code in the `java.time` > packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - 8268469: Removed alignment of arrow operators in some cases; reverted logic of switch/case in LocalDate - Merge remote-tracking branch 'origin/master' into JDK-8268469 - 8268469: Removed excessive spacing; corrected misplaced comments - Merge remote-tracking branch 'origin/master' into JDK-8268469 - Merge remote-tracking branch 'origin/master' into JDK-8268469 - 8268469: Update java.time to use switch expressions - Changes: - all: https://git.openjdk.java.net/jdk/pull/4433/files - new: https://git.openjdk.java.net/jdk/pull/4433/files/2ae4a574..24ae9e53 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=4433=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk=4433=02-03 Stats: 24105 lines in 400 files changed: 15347 ins; 7613 del; 1145 mod Patch: https://git.openjdk.java.net/jdk/pull/4433.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4433/head:pull/4433 PR: https://git.openjdk.java.net/jdk/pull/4433
