Re: RFR: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result

2021-08-03 Thread Valerie Peng
On Tue, 3 Aug 2021 19:05:55 GMT, Weijun Wang  wrote:

> `oddPart` contains a lot of info on the `modInverse` output, sometimes it's 
> even the same. Clearing it in case the result is sensitive.
> 
> No new regression test since it's difficult to access a temporary local 
> variable in an internal class. Existing tier1-2 tests passed.

Marked as reviewed by valeriep (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/4973


Re: RFR: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result

2021-08-03 Thread Joe Darcy
On Tue, 3 Aug 2021 19:05:55 GMT, Weijun Wang  wrote:

> `oddPart` contains a lot of info on the `modInverse` output, sometimes it's 
> even the same. Clearing it in case the result is sensitive.
> 
> No new regression test since it's difficult to access a temporary local 
> variable in an internal class. Existing tier1-2 tests passed.

Marked as reviewed by darcy (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/4973


Re: RFR: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result

2021-08-03 Thread Brian Burkhalter
On Tue, 3 Aug 2021 19:05:55 GMT, Weijun Wang  wrote:

> `oddPart` contains a lot of info on the `modInverse` output, sometimes it's 
> even the same. Clearing it in case the result is sensitive.
> 
> No new regression test since it's difficult to access a temporary local 
> variable in an internal class. Existing tier1-2 tests passed.

Looks fine.

-

Marked as reviewed by bpb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4973


RFR: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result

2021-08-03 Thread Weijun Wang
oddPart contains a lot of info on the modInverse output, sometimes it's even 
the same. Clearing it in case the result is sensitive.

No new regression test since it's difficult to access a temporary local 
variable in an internal class. Existing tier1-2 tests passed.

-

Commit messages:
 - 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on 
final result

Changes: https://git.openjdk.java.net/jdk/pull/4973/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4973=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8271616
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4973.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4973/head:pull/4973

PR: https://git.openjdk.java.net/jdk/pull/4973