Re: RFR: 8273369: Computing micros between two instants unexpectedly overflows for some cases [v6]

2021-09-08 Thread Lance Andersen 
On Wed, 8 Sep 2021 17:40:29 GMT, Naoto Sato  wrote:

>> Please review the fix to the issue. Avoiding overflow by not calling 
>> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference 
>> in nano unit.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Corrected the calculation for MILLIS as well.

Marked as reviewed by lancea (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5396

Re: RFR: 8273369: Computing micros between two instants unexpectedly overflows for some cases [v6]

2021-09-08 Thread Roger Riggs 
On Wed, 8 Sep 2021 17:40:29 GMT, Naoto Sato  wrote:

>> Please review the fix to the issue. Avoiding overflow by not calling 
>> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference 
>> in nano unit.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Corrected the calculation for MILLIS as well.

Marked as reviewed by rriggs (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5396

Re: RFR: 8273369: Computing micros between two instants unexpectedly overflows for some cases [v6]

2021-09-08 Thread Naoto Sato 
> Please review the fix to the issue. Avoiding overflow by not calling 
> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference 
> in nano unit.

Naoto Sato has updated the pull request incrementally with one additional 
commit since the last revision:

  Corrected the calculation for MILLIS as well.

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5396/files
  - new: https://git.openjdk.java.net/jdk/pull/5396/files/ccf73bf7..1f6fd470

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=5396=05
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=5396=04-05

  Stats: 24 lines in 3 files changed: 21 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5396.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5396/head:pull/5396

PR: https://git.openjdk.java.net/jdk/pull/5396