Re: RFR: 8273616: Fix trivial doc typos in the java.base module [v2]
On Fri, 10 Sep 2021 23:20:11 GMT, Pavel Rappo wrote: >> 8273616: Fix trivial doc typos in the java.base module > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Revert two fixes Thanks to those who reviewed this PR. Since I posted it, I've found three more occurrences of _insure_ used in the sense of _ensure_: two in the `java.io.Object*Stream` area and one in the `java.util.Currency` class. I decided to fix those in this PR, which now needs to be (re)reviewed. Thanks! There are more occurrences of _insure_, which I didn't touch. Some of them are in java.sql, java.sql.rowset and java.desktop. In the latter, _insure_ even crept into method names. - PR: https://git.openjdk.java.net/jdk/pull/5475
Re: RFR: 8273616: Fix trivial doc typos in the java.base module [v2]
On Fri, 10 Sep 2021 23:20:11 GMT, Pavel Rappo wrote: >> 8273616: Fix trivial doc typos in the java.base module > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Revert two fixes Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5475
Re: RFR: 8273616: Fix trivial doc typos in the java.base module [v2]
On Fri, 10 Sep 2021 23:20:11 GMT, Pavel Rappo wrote: >> 8273616: Fix trivial doc typos in the java.base module > > Pavel Rappo has updated the pull request incrementally with one additional > commit since the last revision: > > Revert two fixes Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5475
Re: RFR: 8273616: Fix trivial doc typos in the java.base module [v2]
> 8273616: Fix trivial doc typos in the java.base module Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision: Revert two fixes - Changes: - all: https://git.openjdk.java.net/jdk/pull/5475/files - new: https://git.openjdk.java.net/jdk/pull/5475/files/b90d1556..9a9deee1 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=5475=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=5475=00-01 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/5475.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5475/head:pull/5475 PR: https://git.openjdk.java.net/jdk/pull/5475
Re: RFR: 8273616: Fix trivial doc typos in the java.base module [v2]
On Fri, 10 Sep 2021 21:52:36 GMT, John R Rose wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert two fixes
>
> src/java.base/share/classes/java/nio/channels/FileChannel.java line 567:
>
>> 565: * If {@code true} then this method is required to force
>> changes
>> 566: * to both the file's content and metadata to be written to
>> 567: * storage; otherwise, it needs only force content changes
>> to be
>
> (same as previous comment: the suggested fix makes the English *less*
> correct)
Reverted both in 9a9deee; thanks.
-
PR: https://git.openjdk.java.net/jdk/pull/5475
