Re: RFR: 8273935: (zipfs) Files.getFileAttributeView() throws UOE instead of returning null when view not supported [v3]

2021-09-21 Thread Severin Gehwolf
On Mon, 20 Sep 2021 18:17:29 GMT, Lance Andersen  wrote:

>> Hi all,
>> 
>> Please review this patch which addresses the issue where Zip FS will throw a 
>> UOE instead of returning null  when  Files.getFileAttributeView() is invoked 
>> and  the view not supported.
>> 
>> Mach5 tiers1 - tier3 are clean.
>> 
>> Best
>> Lance
>
> Lance Andersen has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fix minor typo

Marked as reviewed by sgehwolf (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5579


Re: RFR: 8273935: (zipfs) Files.getFileAttributeView() throws UOE instead of returning null when view not supported [v3]

2021-09-20 Thread Brian Burkhalter
On Mon, 20 Sep 2021 18:17:29 GMT, Lance Andersen  wrote:

>> Hi all,
>> 
>> Please review this patch which addresses the issue where Zip FS will throw a 
>> UOE instead of returning null  when  Files.getFileAttributeView() is invoked 
>> and  the view not supported.
>> 
>> Mach5 tiers1 - tier3 are clean.
>> 
>> Best
>> Lance
>
> Lance Andersen has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fix minor typo

Marked as reviewed by bpb (Reviewer).

Marked as reviewed by bpb (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5579


Re: RFR: 8273935: (zipfs) Files.getFileAttributeView() throws UOE instead of returning null when view not supported [v3]

2021-09-20 Thread Alan Bateman
On Mon, 20 Sep 2021 18:17:29 GMT, Lance Andersen  wrote:

>> Hi all,
>> 
>> Please review this patch which addresses the issue where Zip FS will throw a 
>> UOE instead of returning null  when  Files.getFileAttributeView() is invoked 
>> and  the view not supported.
>> 
>> Mach5 tiers1 - tier3 are clean.
>> 
>> Best
>> Lance
>
> Lance Andersen has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fix minor typo

Marked as reviewed by alanb (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5579


Re: RFR: 8273935: (zipfs) Files.getFileAttributeView() throws UOE instead of returning null when view not supported [v3]

2021-09-20 Thread Lance Andersen
> Hi all,
> 
> Please review this patch which addresses the issue where Zip FS will throw a 
> UOE instead of returning null  when  Files.getFileAttributeView() is invoked 
> and  the view not supported.
> 
> Mach5 tiers1 - tier3 are clean.
> 
> Best
> Lance

Lance Andersen has updated the pull request incrementally with one additional 
commit since the last revision:

  fix minor typo

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5579/files
  - new: https://git.openjdk.java.net/jdk/pull/5579/files/6ff49197..65184a5a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=5579=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=5579=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5579.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5579/head:pull/5579

PR: https://git.openjdk.java.net/jdk/pull/5579