Re: RFR: 8274071: Clean up java.lang.ref comments and documentation

2021-09-21 Thread Lance Andersen 
On Tue, 21 Sep 2021 12:05:27 GMT, Pavel Rappo  wrote:

> This PR fixes an inline comment typo and reduces "overlinking" in a doc 
> comment in `java.lang.ref.Reference`. Overlinking happens because the 
> `reachabilityFence` method:
>  * Links `package-summary.html#reachability` twice.
>  * Refers to JLS 12.6 twice: once from a block tag and once from an inline 
> tag.

Marked as reviewed by lancea (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5609

Re: RFR: 8274071: Clean up java.lang.ref comments and documentation

2021-09-21 Thread Iris Clark 
On Tue, 21 Sep 2021 12:05:27 GMT, Pavel Rappo  wrote:

> This PR fixes an inline comment typo and reduces "overlinking" in a doc 
> comment in `java.lang.ref.Reference`. Overlinking happens because the 
> `reachabilityFence` method:
>  * Links `package-summary.html#reachability` twice.
>  * Refers to JLS 12.6 twice: once from a block tag and once from an inline 
> tag.

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5609

Re: RFR: 8274071: Clean up java.lang.ref comments and documentation

2021-09-21 Thread Mandy Chung 
On Tue, 21 Sep 2021 12:05:27 GMT, Pavel Rappo  wrote:

> This PR fixes an inline comment typo and reduces "overlinking" in a doc 
> comment in `java.lang.ref.Reference`. Overlinking happens because the 
> `reachabilityFence` method:
>  * Links `package-summary.html#reachability` twice.
>  * Refers to JLS 12.6 twice: once from a block tag and once from an inline 
> tag.

Marked as reviewed by mchung (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5609

Re: RFR: 8274071: Clean up java.lang.ref comments and documentation

2021-09-21 Thread Kim Barrett 
On Tue, 21 Sep 2021 12:05:27 GMT, Pavel Rappo  wrote:

> This PR fixes an inline comment typo and reduces "overlinking" in a doc 
> comment in `java.lang.ref.Reference`. Overlinking happens because the 
> `reachabilityFence` method:
>  * Links `package-summary.html#reachability` twice.
>  * Refers to JLS 12.6 twice: once from a block tag and once from an inline 
> tag.

Looks good.

-

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5609

Re: RFR: 8274071: Clean up java.lang.ref comments and documentation

2021-09-21 Thread Roger Riggs 
On Tue, 21 Sep 2021 12:05:27 GMT, Pavel Rappo  wrote:

> This PR fixes an inline comment typo and reduces "overlinking" in a doc 
> comment in `java.lang.ref.Reference`. Overlinking happens because the 
> `reachabilityFence` method:
>  * Links `package-summary.html#reachability` twice.
>  * Refers to JLS 12.6 twice: once from a block tag and once from an inline 
> tag.

Marked as reviewed by rriggs (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5609

RFR: 8274071: Clean up java.lang.ref comments and documentation

2021-09-21 Thread Pavel Rappo 
This PR fixes an inline comment typo and reduces "overlinking" in a doc comment 
in `java.lang.ref.Reference`. Overlinking happens because the 
`reachabilityFence` method:
 * Links `package-summary.html#reachability` twice.
 * Refers to JLS 12.6 twice: once from a block tag and once from an inline tag.

-

Commit messages:
 - Initial commit

Changes: https://git.openjdk.java.net/jdk/pull/5609/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5609=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8274071
  Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5609.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5609/head:pull/5609

PR: https://git.openjdk.java.net/jdk/pull/5609