Re: RFR: 8286368: Cleanup problem lists after loom integration [v2]
On Mon, 16 May 2022 02:25:26 GMT, Leonid Mesnik wrote: >> test/hotspot/jtreg/ProblemList-Xcomp.txt line 38: >> >>> 36: serviceability/sa/TestJhsdbJstackMixed.java 8248675 linux-aarch64 >>> 37: >>> 38: compiler/c2/irTests/TestSkeletonPredicates.java 8286361 generic-all >> >> @lmesnik This line should not have been removed! > > It might be a merge problem. My PR was submitted before 8286442. I remereged > changes, however my merge commit also doesn't have removal of this line: > https://github.com/openjdk/jdk/pull/8604/commits/8255e760ff1a2ff616f00f559de29e66d7036b39 > > So I am really confused and can't understand how I managed to introduce this > problem. That is really bizarre. No individual commit shows the line being deleted, yet in the final commit it is. - PR: https://git.openjdk.java.net/jdk/pull/8604
Re: RFR: 8286368: Cleanup problem lists after loom integration [v2]
On Mon, 16 May 2022 01:23:09 GMT, David Holmes wrote: >> Leonid Mesnik has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - Merge >> - 8286368: Cleanup problem lists after loom integration > > test/hotspot/jtreg/ProblemList-Xcomp.txt line 38: > >> 36: serviceability/sa/TestJhsdbJstackMixed.java 8248675 linux-aarch64 >> 37: >> 38: compiler/c2/irTests/TestSkeletonPredicates.java 8286361 generic-all > > @lmesnik This line should not have been removed! It might be a merge problem. My PR was submitted before 8286442. I remereged changes, however my merge commit also doesn't have removal of this line: https://github.com/openjdk/jdk/pull/8604/commits/8255e760ff1a2ff616f00f559de29e66d7036b39 So I am really confused and can't understand how I managed to introduce this problem. - PR: https://git.openjdk.java.net/jdk/pull/8604
Re: RFR: 8286368: Cleanup problem lists after loom integration [v2]
On Tue, 10 May 2022 19:16:34 GMT, Leonid Mesnik wrote: >> 8286368: Cleanup problem lists after loom integration > > Leonid Mesnik has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - Merge > - 8286368: Cleanup problem lists after loom integration test/hotspot/jtreg/ProblemList-Xcomp.txt line 38: > 36: serviceability/sa/TestJhsdbJstackMixed.java 8248675 linux-aarch64 > 37: > 38: compiler/c2/irTests/TestSkeletonPredicates.java 8286361 generic-all @lmesnik This line should not have been removed! - PR: https://git.openjdk.java.net/jdk/pull/8604
Re: RFR: 8286368: Cleanup problem lists after loom integration [v2]
> 8286368: Cleanup problem lists after loom integration Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge - 8286368: Cleanup problem lists after loom integration - Changes: https://git.openjdk.java.net/jdk/pull/8604/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8604=01 Stats: 29 lines in 4 files changed: 1 ins; 22 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/8604.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8604/head:pull/8604 PR: https://git.openjdk.java.net/jdk/pull/8604
