Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v8]
On Fri, 10 Jun 2022 18:19:42 GMT, Thiago Henrique Hüpner wrote: >> test/jdk/tools/jar/modularJar/Basic.java line 44: >> >>> 42: >>> 43: import jdk.internal.module.ModuleReferenceImpl; >>> 44: import jdk.internal.module.ModuleResolution; >> >> At some point we need to put in test infrastructure to avoid this and a few >> other tests from depending on JDK internals. > > Do you think it is better to parse the output of `javap` instead of using the > internals to detect if it worked? Parsing the output of javap would be fragile. Instead, I think we'll just add some test infrastructure at some point, maybe when this class file attribute is documented somewhere. - PR: https://git.openjdk.org/jdk/pull/9049
Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v8]
On Fri, 10 Jun 2022 18:01:24 GMT, Alan Bateman wrote: >> Thiago Henrique Hüpner has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix copyright year > > test/jdk/tools/jar/modularJar/Basic.java line 44: > >> 42: >> 43: import jdk.internal.module.ModuleReferenceImpl; >> 44: import jdk.internal.module.ModuleResolution; > > At some point we need to put in test infrastructure to avoid this and a few > other tests from depending on JDK internals. Do you think it is better to parse the output of `javap` instead of using the internals to detect if it worked? - PR: https://git.openjdk.org/jdk/pull/9049
Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v8]
On Fri, 10 Jun 2022 16:30:57 GMT, Thiago Henrique Hüpner
wrote:
>> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
>> flags is used
>
> Thiago Henrique Hüpner has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix copyright year
test/jdk/tools/jar/modularJar/Basic.java line 44:
> 42:
> 43: import jdk.internal.module.ModuleReferenceImpl;
> 44: import jdk.internal.module.ModuleResolution;
At some point we need to put in test infrastructure to avoid this and a few
other tests from depending on JDK internals.
test/jdk/tools/jar/modularJar/Basic.java line 951:
> 949:
> 950: @DataProvider(name = "resolutionNames")
> 951: public Object[][] resolutionNames() {
This is a data provider for resolution warnings, maybe it should be renamed.
-
PR: https://git.openjdk.org/jdk/pull/9049
Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v8]
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved > flags is used Thiago Henrique Hüpner has updated the pull request incrementally with one additional commit since the last revision: Fix copyright year - Changes: - all: https://git.openjdk.org/jdk/pull/9049/files - new: https://git.openjdk.org/jdk/pull/9049/files/8544abd9..962f0ec1 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=9049=07 - incr: https://webrevs.openjdk.java.net/?repo=jdk=9049=06-07 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/9049.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9049/head:pull/9049 PR: https://git.openjdk.org/jdk/pull/9049
