Re: RFR: JDK-8233578: Document configurable parameters of msi packages

2020-01-13 Thread Alexander Matveev 

Looks good.

Thanks,
Alexander

On 12/20/2019 8:56 AM, Andy Herrick wrote:

looks good.

/Andy

On 12/19/2019 8:52 PM, Alexey Semenyuk wrote:

Please review fix [2] for jpackage bug [1].

Comments added to the default WiX source file explaining how the 
default file is expected to be overridden.


- Alexey

[1] https://bugs.openjdk.java.net/browse/JDK-8233578

[2] http://cr.openjdk.java.net/~asemenyuk/8233578/webrev.00

Re: RFR: JDK-8233578: Document configurable parameters of msi packages

2019-12-20 Thread Andy Herrick 

looks good.

/Andy

On 12/19/2019 8:52 PM, Alexey Semenyuk wrote:

Please review fix [2] for jpackage bug [1].

Comments added to the default WiX source file explaining how the 
default file is expected to be overridden.


- Alexey

[1] https://bugs.openjdk.java.net/browse/JDK-8233578

[2] http://cr.openjdk.java.net/~asemenyuk/8233578/webrev.00

RFR: JDK-8233578: Document configurable parameters of msi packages

2019-12-19 Thread Alexey Semenyuk 

Please review fix [2] for jpackage bug [1].

Comments added to the default WiX source file explaining how the default 
file is expected to be overridden.


- Alexey

[1] https://bugs.openjdk.java.net/browse/JDK-8233578

[2] http://cr.openjdk.java.net/~asemenyuk/8233578/webrev.00