Re: RFR: JDK-8264244: BasicShortcutHintTest shortcut can not be found
Yeh, you are right. It was copy/paste error. Thank you for the correction! - Alexey On 6/16/2020 6:13 PM, Alexander Matveev wrote: Hi Alexey, Looks good. I think you got links and bug ID incorrect. It should be JDK-8246244 and you have 8264244. Links also does not work. Working links are: https://bugs.openjdk.java.net/browse/JDK-8246244 http://cr.openjdk.java.net/~asemenyuk/8246244/webrev.00/ Thanks, Alexander On 6/16/2020 2:56 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. The fix is to put value of `Exec` property of .desktop files generated by jpackage in double quotes if the value of the propery contains whitespace characters. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8264244 [2] http://cr.openjdk.java.net/~asemenyuk/8264244/webrev.00
Re: RFR: JDK-8264244: BasicShortcutHintTest shortcut can not be found
looks good with these links /Andy On 6/16/2020 6:13 PM, Alexander Matveev wrote: Hi Alexey, Looks good. I think you got links and bug ID incorrect. It should be JDK-8246244 and you have 8264244. Links also does not work. Working links are: https://bugs.openjdk.java.net/browse/JDK-8246244 http://cr.openjdk.java.net/~asemenyuk/8246244/webrev.00/ Thanks, Alexander On 6/16/2020 2:56 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. The fix is to put value of `Exec` property of .desktop files generated by jpackage in double quotes if the value of the propery contains whitespace characters. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8264244 [2] http://cr.openjdk.java.net/~asemenyuk/8264244/webrev.00
RFR: JDK-8264244: BasicShortcutHintTest shortcut can not be found
Please review fix [2] for jpackage bug [1]. The fix is to put value of `Exec` property of .desktop files generated by jpackage in double quotes if the value of the propery contains whitespace characters. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8264244 [2] http://cr.openjdk.java.net/~asemenyuk/8264244/webrev.00
Re: RFR: JDK-8264244: BasicShortcutHintTest shortcut can not be found
Hi Alexey, Looks good. I think you got links and bug ID incorrect. It should be JDK-8246244 and you have 8264244. Links also does not work. Working links are: https://bugs.openjdk.java.net/browse/JDK-8246244 http://cr.openjdk.java.net/~asemenyuk/8246244/webrev.00/ Thanks, Alexander On 6/16/2020 2:56 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. The fix is to put value of `Exec` property of .desktop files generated by jpackage in double quotes if the value of the propery contains whitespace characters. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8264244 [2] http://cr.openjdk.java.net/~asemenyuk/8264244/webrev.00
