Re: RFR: JDK-8273194: Document the two possible cases when Lookup::ensureInitialized returns [v2]

2021-09-02 Thread Mandy Chung 
> Improve the specification to document the cases when 
> `Lookup::ensureInitialized` returns as specified JVMS 5.5 and matches the 
> implementation.
> 
> Please also review CSR: https://bugs.openjdk.java.net/browse/JDK-8273253

Mandy Chung has updated the pull request incrementally with one additional 
commit since the last revision:

  review comment

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5343/files
  - new: https://git.openjdk.java.net/jdk/pull/5343/files/3a2aa6da..3f7e66b0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5343&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5343&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5343.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5343/head:pull/5343

PR: https://git.openjdk.java.net/jdk/pull/5343

Re: RFR: JDK-8273194: Document the two possible cases when Lookup::ensureInitialized returns [v2]

2021-09-02 Thread Mandy Chung 
On Thu, 2 Sep 2021 14:00:03 GMT, Alan Bateman  wrote:

>> Mandy Chung has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   review comment
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 2787:
> 
>> 2785:  * This method returns when {@code targetClass} is fully 
>> initialized, or
>> 2786:  * when {@code targetClass} is being initialized if this 
>> method is called
>> 2787:  * by the initializing thread.
> 
> This looks okay but I wonder if it might be a bit clearer to say "when 
> targetClass is being initialized on the current thread".

That works for me.  Updated.

-

PR: https://git.openjdk.java.net/jdk/pull/5343

Re: RFR: JDK-8273194: Document the two possible cases when Lookup::ensureInitialized returns [v2]

2021-09-02 Thread Alan Bateman 
On Thu, 2 Sep 2021 16:18:03 GMT, Mandy Chung  wrote:

>> Improve the specification to document the cases when 
>> `Lookup::ensureInitialized` returns as specified JVMS 5.5 and matches the 
>> implementation.
>> 
>> Please also review CSR: https://bugs.openjdk.java.net/browse/JDK-8273253
>
> Mandy Chung has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   review comment

Marked as reviewed by alanb (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5343

Re: RFR: JDK-8273194: Document the two possible cases when Lookup::ensureInitialized returns

2021-09-02 Thread Alan Bateman 
On Wed, 1 Sep 2021 20:56:59 GMT, Mandy Chung  wrote:

> Improve the specification to document the cases when 
> `Lookup::ensureInitialized` returns as specified JVMS 5.5 and matches the 
> implementation.
> 
> Please also review CSR: https://bugs.openjdk.java.net/browse/JDK-8273253

src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 2787:

> 2785:  * This method returns when {@code targetClass} is fully 
> initialized, or
> 2786:  * when {@code targetClass} is being initialized if this method 
> is called
> 2787:  * by the initializing thread.

This looks okay but I wonder if it might be a bit clearer to say "when 
targetClass is being initialized on the current thread".

-

PR: https://git.openjdk.java.net/jdk/pull/5343

RFR: JDK-8273194: Document the two possible cases when Lookup::ensureInitialized returns

2021-09-01 Thread Mandy Chung 
Improve the specification to document the cases when 
`Lookup::ensureInitialized` returns as specified JVMS 5.5 and matches the 
implementation.

Please also review CSR: https://bugs.openjdk.java.net/browse/JDK-8273253

-

Commit messages:
 - JDK-8273194: Document the two possible cases when Lookup::ensureInitialized 
returns

Changes: https://git.openjdk.java.net/jdk/pull/5343/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5343&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8273194
  Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5343.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5343/head:pull/5343

PR: https://git.openjdk.java.net/jdk/pull/5343