Re: RFR: JDK-8287671: Adjust ForceGC to invoke System::gc fewer times for negative case

2022-06-06 Thread Mandy Chung 
On Fri, 3 Jun 2022 18:05:52 GMT, Mandy Chung  wrote:

> This reapplies JDK-8287384 and adjust the number of GCs for negative case, 
> i.e. the condition is never met that is used to verify a reference is not 
> GC'ed.

JDK-8287384 affects the tests using ForceGC for negative cases only.  It will 
return with a fewer GC cycles of a shortened wait time between each cycle.  It 
will be okay since a strongly reachable reference will never be GC'ed.

-

PR: https://git.openjdk.java.net/jdk/pull/9021

Re: RFR: JDK-8287671: Adjust ForceGC to invoke System::gc fewer times for negative case

2022-06-03 Thread Xue-Lei Andrew Fan 
On Fri, 3 Jun 2022 18:05:52 GMT, Mandy Chung  wrote:

> This reapplies JDK-8287384 and adjust the number of GCs for negative case, 
> i.e. the condition is never met that is used to verify a reference is not 
> GC'ed.

Marked as reviewed by xuelei (Reviewer).

@mlchung Thank you for pick up and fix the issue.

The waiting time now is reduced from 10 seconds to 1 seconds.  As most of the 
tests intermittent fail, the failure may be more popular now.  Alternatively, 
it might be OK to run less cases in UnloadingTest.java (for example one or two 
call to tryUnload() in one test by separating the case into a few).  But let's 
see if the intermittent failure is still rare enough.

-

PR: https://git.openjdk.java.net/jdk/pull/9021

Re: RFR: JDK-8287671: Adjust ForceGC to invoke System::gc fewer times for negative case

2022-06-03 Thread Brent Christian 
On Fri, 3 Jun 2022 18:05:52 GMT, Mandy Chung  wrote:

> This reapplies JDK-8287384 and adjust the number of GCs for negative case, 
> i.e. the condition is never met that is used to verify a reference is not 
> GC'ed.

Marked as reviewed by bchristi (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/9021

Re: RFR: JDK-8287671: Adjust ForceGC to invoke System::gc fewer times for negative case

2022-06-03 Thread Roger Riggs 
On Fri, 3 Jun 2022 18:05:52 GMT, Mandy Chung  wrote:

> This reapplies JDK-8287384 and adjust the number of GCs for negative case, 
> i.e. the condition is never met that is used to verify a reference is not 
> GC'ed.

Marked as reviewed by rriggs (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/9021

RFR: JDK-8287671: Adjust ForceGC to invoke System::gc fewer times for negative case

2022-06-03 Thread Mandy Chung 
This reapplies JDK-8287384 and adjust the number of GCs for negative case, i.e. 
the condition is never met that is used to verify a reference is not GC'ed.

-

Commit messages:
 - JDK-8287671: Adjust ForceGC to invoke System::gc fewer times for negative 
case

Changes: https://git.openjdk.java.net/jdk/pull/9021/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=9021&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8287671
  Stats: 19 lines in 1 file changed: 11 ins; 0 del; 8 mod
  Patch: https://git.openjdk.java.net/jdk/pull/9021.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/9021/head:pull/9021

PR: https://git.openjdk.java.net/jdk/pull/9021