Re: RFR (JDK11/JAXP/java.xml) 8198548: Initialization race in com.sun.org.apache.xerces.internal.impl.xpath.regex.Token.getRange() on Token.categories

[Joe Wang]

Thanks Lance!  Running one last test. Will check in once the tests pass.

Best,
Joe

On 5/18/2018 2:26 PM, Lance Andersen wrote:

Hi Joe,

The current webrev looks fine.

On May 16, 2018, at 7:40 PM, Joe Wang > wrote:


Hi,

Please review a fix on synchronization. The real change is the 
double-checked locking, all others are s/Token.categories/tmpMap/g.


All JAXP tests passed. Before the fix, the test attached to JBS 
failed only once for me after 10,000 runs and then a few 1000 runs 
(impossible to get one with only 20 runs as the comment mentioned). 
 The author of the original report put the actual pass rate at 
99.994%. After the fix then, in theory it should be 100%, I've made a 
100,000 run without seeing a failure.


JBS: https://bugs.openjdk.java.net/browse/JDK-8198548
webrevs: http://cr.openjdk.java.net/~joehw/jdk11/8198548/webrev/ 



Thanks,
Joe




Lance 
Andersen| Principal Member of Technical Staff | +1.781.442.2037

Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com 

Re: RFR (JDK11/JAXP/java.xml) 8198548: Initialization race in com.sun.org.apache.xerces.internal.impl.xpath.regex.Token.getRange() on Token.categories

[Lance Andersen]

Hi Joe,

The current webrev looks fine.

> On May 16, 2018, at 7:40 PM, Joe Wang  wrote:
> 
> Hi,
> 
> Please review a fix on synchronization. The real change is the double-checked 
> locking, all others are s/Token.categories/tmpMap/g.
> 
> All JAXP tests passed. Before the fix, the test attached to JBS failed only 
> once for me after 10,000 runs and then a few 1000 runs (impossible to get one 
> with only 20 runs as the comment mentioned).  The author of the original 
> report put the actual pass rate at 99.994%. After the fix then, in theory it 
> should be 100%, I've made a 100,000 run without seeing a failure.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8198548
> webrevs: http://cr.openjdk.java.net/~joehw/jdk11/8198548/webrev/
> 
> Thanks,
> Joe

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com 

RFR (JDK11/JAXP/java.xml) 8198548: Initialization race in com.sun.org.apache.xerces.internal.impl.xpath.regex.Token.getRange() on Token.categories

[Joe Wang]

Hi,

Please review a fix on synchronization. The real change is the 
double-checked locking, all others are s/Token.categories/tmpMap/g.


All JAXP tests passed. Before the fix, the test attached to JBS failed 
only once for me after 10,000 runs and then a few 1000 runs (impossible 
to get one with only 20 runs as the comment mentioned).  The author of 
the original report put the actual pass rate at 99.994%. After the fix 
then, in theory it should be 100%, I've made a 100,000 run without 
seeing a failure.


JBS: https://bugs.openjdk.java.net/browse/JDK-8198548
webrevs: http://cr.openjdk.java.net/~joehw/jdk11/8198548/webrev/

Thanks,
Joe