Re: RFR [14/java.xml] 8016914: CoreDocumentImpl.setXmlVersion NPE

[Joe Wang]

Thanks Lance!

On 9/27/19 10:47 AM, Lance Andersen wrote:

Hi Joe,

The change looks fine as does the test.

Best
Lance
On Sep 27, 2019, at 12:29 PM, Joe Wang > wrote:


Please review a fix to the NPE issue. This is part of the work on the 
XML declaration related issues.


JBS: https://bugs.openjdk.java.net/browse/JDK-8016914
webrev: http://cr.openjdk.java.net/~joehw/jdk14/8016914/webrev/

Thanks,
Joe




Lance 
Andersen| Principal Member of Technical Staff | +1.781.442.2037

Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com 

Re: RFR [14/java.xml] 8016914: CoreDocumentImpl.setXmlVersion NPE

[Lance Andersen]

Hi Joe,

The change looks fine as does the test.

Best
Lance
> On Sep 27, 2019, at 12:29 PM, Joe Wang  wrote:
> 
> Please review a fix to the NPE issue. This is part of the work on the XML 
> declaration related issues.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8016914
> webrev: http://cr.openjdk.java.net/~joehw/jdk14/8016914/webrev/
> 
> Thanks,
> Joe

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com 

RFR [14/java.xml] 8016914: CoreDocumentImpl.setXmlVersion NPE

[Joe Wang]

Please review a fix to the NPE issue. This is part of the work on the 
XML declaration related issues.


JBS: https://bugs.openjdk.java.net/browse/JDK-8016914
webrev: http://cr.openjdk.java.net/~joehw/jdk14/8016914/webrev/

Thanks,
Joe