Re: [12] RFR 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/

2018-10-18 Thread Chris Yin 
Thank you, Roger

Chris

> On 19 Oct 2018, at 2:54 AM, Roger Riggs  wrote:
> 
> +1,
> 
> On 09/20/2018 04:55 AM, vyom tewari wrote:
>> Hi Chris,
>> 
>> tests  looks good to me.
>> 
>> Thanks,
>> 
>> 
>> 
>> On Tuesday 04 September 2018 12:00 PM, Chris Yin wrote:
>>> Please review the changes to add 10 JNDI tests to 
>>> com/sun/jndi/dns/FedTests/ in OpenJDK, thanks
>>> 
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8210339
>>> webrev: http://cr.openjdk.java.net/~xyin/8210339/webrev.00/
>>> 
>>> Regards,
>>> Chris
>> 
>

Re: [12] RFR 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/

2018-10-18 Thread Roger Riggs 

+1,

On 09/20/2018 04:55 AM, vyom tewari wrote:

Hi Chris,

tests  looks good to me.

Thanks,



On Tuesday 04 September 2018 12:00 PM, Chris Yin wrote:
Please review the changes to add 10 JNDI tests to 
com/sun/jndi/dns/FedTests/ in OpenJDK, thanks


bug: https://bugs.openjdk.java.net/browse/JDK-8210339
webrev: http://cr.openjdk.java.net/~xyin/8210339/webrev.00/

Regards,
Chris

Re: [12] RFR 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/

2018-09-20 Thread Chris Yin 
Thank you, Vyom

Regards,
Chris

> On 20 Sep 2018, at 4:55 PM, vyom tewari  wrote:
> 
> Hi Chris,
> 
> tests  looks good to me.
> 
> Thanks,
> 
> 
> 
> On Tuesday 04 September 2018 12:00 PM, Chris Yin wrote:
>> Please review the changes to add 10 JNDI tests to com/sun/jndi/dns/FedTests/ 
>> in OpenJDK, thanks
>> 
>> bug: https://bugs.openjdk.java.net/browse/JDK-8210339
>> webrev: http://cr.openjdk.java.net/~xyin/8210339/webrev.00/
>> 
>> Regards,
>> Chris
>

Re: [12] RFR 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/

2018-09-20 Thread vyom tewari 

Hi Chris,

tests  looks good to me.

Thanks,



On Tuesday 04 September 2018 12:00 PM, Chris Yin wrote:

Please review the changes to add 10 JNDI tests to com/sun/jndi/dns/FedTests/ in 
OpenJDK, thanks

bug: https://bugs.openjdk.java.net/browse/JDK-8210339
webrev: http://cr.openjdk.java.net/~xyin/8210339/webrev.00/

Regards,
Chris