Re: [jdk17] RFR: 8265073: XML transformation and indentation when using xml:space [v2]
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote: >> The issue was that the attribute was processed before the variable was set >> (e.g. m_preserveSpaces.push). Reversing the order fixed it. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Thanks Naoto. Updated accordingly. Thanks Iris. - PR: https://git.openjdk.java.net/jdk17/pull/89
Re: [jdk17] RFR: 8265073: XML transformation and indentation when using xml:space [v2]
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote: >> The issue was that the attribute was processed before the variable was set >> (e.g. m_preserveSpaces.push). Reversing the order fixed it. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Thanks Naoto. Updated accordingly. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/89
Re: [jdk17] RFR: 8265073: XML transformation and indentation when using xml:space [v2]
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote: >> The issue was that the attribute was processed before the variable was set >> (e.g. m_preserveSpaces.push). Reversing the order fixed it. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Thanks Naoto. Updated accordingly. Looks good. Thanks for the fix! - Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.java.net/jdk17/pull/89
Re: [jdk17] RFR: 8265073: XML transformation and indentation when using xml:space [v2]
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote: >> The issue was that the attribute was processed before the variable was set >> (e.g. m_preserveSpaces.push). Reversing the order fixed it. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Thanks Naoto. Updated accordingly. Thanks Lance. Indeed, me too. So this is the first without the name parameter :-) - PR: https://git.openjdk.java.net/jdk17/pull/89
Re: [jdk17] RFR: 8265073: XML transformation and indentation when using xml:space [v2]
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote: >> The issue was that the attribute was processed before the variable was set >> (e.g. m_preserveSpaces.push). Reversing the order fixed it. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Thanks Naoto. Updated accordingly. Looks fine. I still add the DataProvider name out of habit myself even though it is always the same as the method names for me (some habits are hard to break) - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk17/pull/89
Re: [jdk17] RFR: 8265073: XML transformation and indentation when using xml:space [v2]
> The issue was that the attribute was processed before the variable was set > (e.g. m_preserveSpaces.push). Reversing the order fixed it. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: Thanks Naoto. Updated accordingly. - Changes: - all: https://git.openjdk.java.net/jdk17/pull/89/files - new: https://git.openjdk.java.net/jdk17/pull/89/files/509a101c..32ba04d8 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17=89=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17=89=00-01 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17/pull/89.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/89/head:pull/89 PR: https://git.openjdk.java.net/jdk17/pull/89
