Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property [v4]

2021-06-28 Thread Joe Wang 
On Mon, 28 Jun 2021 20:33:29 GMT, Naoto Sato  wrote:

>> Please review this small doc change to the system property. Accompanying CSR 
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Missed one.

Marked as reviewed by joehw (Reviewer).

Thanks for the update. As for "of", apparently the native speakers were fine 
with it ;-)

-

PR: https://git.openjdk.java.net/jdk17/pull/163

Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property [v4]

2021-06-28 Thread Lance Andersen 
On Mon, 28 Jun 2021 20:33:29 GMT, Naoto Sato  wrote:

>> Please review this small doc change to the system property. Accompanying CSR 
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Missed one.

Marked as reviewed by lancea (Reviewer).

-

PR: https://git.openjdk.java.net/jdk17/pull/163

Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property [v4]

2021-06-28 Thread Iris Clark 
On Mon, 28 Jun 2021 20:33:29 GMT, Naoto Sato  wrote:

>> Please review this small doc change to the system property. Accompanying CSR 
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Missed one.

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk17/pull/163

Re: [jdk17] RFR: 8269513: Clarify the spec wrt `useOldISOCodes` system property [v4]

2021-06-28 Thread Naoto Sato 
> Please review this small doc change to the system property. Accompanying CSR 
> has also been created.

Naoto Sato has updated the pull request incrementally with one additional 
commit since the last revision:

  Missed one.

-

Changes:
  - all: https://git.openjdk.java.net/jdk17/pull/163/files
  - new: https://git.openjdk.java.net/jdk17/pull/163/files/da119219..3b6ff65d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk17=163=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk17=163=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk17/pull/163.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/163/head:pull/163

PR: https://git.openjdk.java.net/jdk17/pull/163