Re: 8244293 : Remove outdated @apiNote in java.util.Objects

2020-05-05 Thread Anirvan Sarkar
Hi Paul,

Thanks for sponsoring !

On Tue, 5 May 2020 at 01:16, Paul Sandoz  wrote:

> Hi,
>
> Removing all of the api note looks good, since it was really written in
> the context of the removed methods.
>
> I’ll sponsor. (I removed the methods but forgot to remove the note.)
>
> Paul.
>
> > On May 3, 2020, at 9:03 AM, Anirvan Sarkar 
> wrote:
> >
> > Hi,
> >
> > The class level @apiNote in java.util.Objects refers to variation of
> static
> > methods checkIndex(int, int), checkFromToIndex(int, int, int), and
> > checkFromIndexSize(int, int, int), which support customization of the
> > runtime exception, and corresponding exception detail message.
> >
> > But these static methods were removed from java.util.Objects as part of
> > JDK-8155794 [1].
> > So the @apiNote in java.util.Objects is outdated.
> >
> > I have created JBS issue to remove the @apiNote [2].
> > Patch is attached.
> >
> > Can someone review and sponsor it?
> >
> > [1] : https://bugs.openjdk.java.net/browse/JDK-8155794
> > [2] : https://bugs.openjdk.java.net/browse/JDK-8244293
> >
> > --
> > Anirvan
> > 
>
>

-- 
Anirvan


Re: 8244293 : Remove outdated @apiNote in java.util.Objects

2020-05-04 Thread Paul Sandoz
Hi,

Removing all of the api note looks good, since it was really written in the 
context of the removed methods.

I’ll sponsor. (I removed the methods but forgot to remove the note.)

Paul.

> On May 3, 2020, at 9:03 AM, Anirvan Sarkar  wrote:
> 
> Hi,
> 
> The class level @apiNote in java.util.Objects refers to variation of static
> methods checkIndex(int, int), checkFromToIndex(int, int, int), and
> checkFromIndexSize(int, int, int), which support customization of the
> runtime exception, and corresponding exception detail message.
> 
> But these static methods were removed from java.util.Objects as part of
> JDK-8155794 [1].
> So the @apiNote in java.util.Objects is outdated.
> 
> I have created JBS issue to remove the @apiNote [2].
> Patch is attached.
> 
> Can someone review and sponsor it?
> 
> [1] : https://bugs.openjdk.java.net/browse/JDK-8155794
> [2] : https://bugs.openjdk.java.net/browse/JDK-8244293
> 
> -- 
> Anirvan
>