Re: RFR(XS): 8217349: Problem list java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java

2019-01-22 Thread Mikael Vidstedt 


Mandy, Igor - thanks! Change pushed to jdk12.

Cheers,
Mikael

> On Jan 22, 2019, at 4:34 PM, Igor Ignatyev  wrote:
> 
> looks good.
> 
> -- Igor
> 
>> On Jan 22, 2019, at 4:30 PM, Mandy Chung  wrote:
>> 
>> +1
>> 
>> Mandy
>> 
>> On 1/22/19 4:26 PM, Mikael Vidstedt wrote:
>>> Please review this change which back ports the problem listing of 
>>> LFMultiThreadCachingTest.java to jdk12 (my original intent was actually to 
>>> push it to jdk12, but that plan got lost somewhere on the way).
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8217349
>>> Webrev: 
>>> http://cr.openjdk.java.net/~mikael/webrevs/8217349/jdk12/webrev.00/open/webrev/
>>> 
>>> The change is the same as the one in jdk/jdk, but the copyright year was 
>>> already updated in jdk12, so there was a trivially resolved merge conflict.
>>> 
>>> Cheers,
>>> Mikael
>>> 
 On Jan 17, 2019, at 3:00 PM, Mikael Vidstedt  
 wrote:
 
 
 Thanks Igor! Pushed.
 
 Cheers,
 Mikael
 
> On Jan 17, 2019, at 2:07 PM, Igor Ignatyev  
> wrote:
> 
> Mikael,
> 
> looks good and trivial to me.
> 
> -- Igor
> 
>> On Jan 17, 2019, at 2:02 PM, Mikael Vidstedt 
>>  wrote:
>> 
>> 
>> Please review this change which adds 
>> java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java to the problem 
>> list until the main bug has been addressed.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8217349 
>> 
>> Webrev: 
>> http://cr.openjdk.java.net/~mikael/webrevs/8217349/webrev.00/open/webrev/
>>  
>> 
>> Main bug: https://bugs.openjdk.java.net/browse/JDK-8151492 
>> 
>> 
>> Cheers,
>> Mikael
>> 
>> 
>

Re: RFR(XS): 8217349: Problem list java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java

2019-01-22 Thread Igor Ignatyev 
looks good.

-- Igor

> On Jan 22, 2019, at 4:30 PM, Mandy Chung  wrote:
> 
> +1
> 
> Mandy
> 
> On 1/22/19 4:26 PM, Mikael Vidstedt wrote:
>> Please review this change which back ports the problem listing of 
>> LFMultiThreadCachingTest.java to jdk12 (my original intent was actually to 
>> push it to jdk12, but that plan got lost somewhere on the way).
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8217349
>> Webrev: 
>> http://cr.openjdk.java.net/~mikael/webrevs/8217349/jdk12/webrev.00/open/webrev/
>> 
>> The change is the same as the one in jdk/jdk, but the copyright year was 
>> already updated in jdk12, so there was a trivially resolved merge conflict.
>> 
>> Cheers,
>> Mikael
>> 
>>> On Jan 17, 2019, at 3:00 PM, Mikael Vidstedt  
>>> wrote:
>>> 
>>> 
>>> Thanks Igor! Pushed.
>>> 
>>> Cheers,
>>> Mikael
>>> 
 On Jan 17, 2019, at 2:07 PM, Igor Ignatyev  
 wrote:
 
 Mikael,
 
 looks good and trivial to me.
 
 -- Igor
 
> On Jan 17, 2019, at 2:02 PM, Mikael Vidstedt  
> wrote:
> 
> 
> Please review this change which adds 
> java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java to the problem 
> list until the main bug has been addressed.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8217349 
> 
> Webrev: 
> http://cr.openjdk.java.net/~mikael/webrevs/8217349/webrev.00/open/webrev/ 
> 
> Main bug: https://bugs.openjdk.java.net/browse/JDK-8151492 
> 
> 
> Cheers,
> Mikael
> 
>

Re: RFR(XS): 8217349: Problem list java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java

2019-01-22 Thread Mandy Chung 

+1

Mandy

On 1/22/19 4:26 PM, Mikael Vidstedt wrote:

Please review this change which back ports the problem listing of 
LFMultiThreadCachingTest.java to jdk12 (my original intent was actually to push 
it to jdk12, but that plan got lost somewhere on the way).

Bug: https://bugs.openjdk.java.net/browse/JDK-8217349
Webrev: 
http://cr.openjdk.java.net/~mikael/webrevs/8217349/jdk12/webrev.00/open/webrev/

The change is the same as the one in jdk/jdk, but the copyright year was 
already updated in jdk12, so there was a trivially resolved merge conflict.

Cheers,
Mikael


On Jan 17, 2019, at 3:00 PM, Mikael Vidstedt  wrote:


Thanks Igor! Pushed.

Cheers,
Mikael


On Jan 17, 2019, at 2:07 PM, Igor Ignatyev  wrote:

Mikael,

looks good and trivial to me.

-- Igor


On Jan 17, 2019, at 2:02 PM, Mikael Vidstedt  wrote:


Please review this change which adds 
java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java to the problem list 
until the main bug has been addressed.

Bug: https://bugs.openjdk.java.net/browse/JDK-8217349 

Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8217349/webrev.00/open/webrev/ 

Main bug: https://bugs.openjdk.java.net/browse/JDK-8151492 


Cheers,
Mikael

Re: RFR(XS): 8217349: Problem list java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java

2019-01-22 Thread Mikael Vidstedt 


Please review this change which back ports the problem listing of 
LFMultiThreadCachingTest.java to jdk12 (my original intent was actually to push 
it to jdk12, but that plan got lost somewhere on the way).

Bug: https://bugs.openjdk.java.net/browse/JDK-8217349
Webrev: 
http://cr.openjdk.java.net/~mikael/webrevs/8217349/jdk12/webrev.00/open/webrev/ 


The change is the same as the one in jdk/jdk, but the copyright year was 
already updated in jdk12, so there was a trivially resolved merge conflict.

Cheers,
Mikael

> On Jan 17, 2019, at 3:00 PM, Mikael Vidstedt  
> wrote:
> 
> 
> Thanks Igor! Pushed.
> 
> Cheers,
> Mikael
> 
>> On Jan 17, 2019, at 2:07 PM, Igor Ignatyev  wrote:
>> 
>> Mikael,
>> 
>> looks good and trivial to me.
>> 
>> -- Igor
>> 
>>> On Jan 17, 2019, at 2:02 PM, Mikael Vidstedt  
>>> wrote:
>>> 
>>> 
>>> Please review this change which adds 
>>> java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java to the problem 
>>> list until the main bug has been addressed.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8217349 
>>> 
>>> Webrev: 
>>> http://cr.openjdk.java.net/~mikael/webrevs/8217349/webrev.00/open/webrev/ 
>>> 
>>> Main bug: https://bugs.openjdk.java.net/browse/JDK-8151492 
>>> 
>>> 
>>> Cheers,
>>> Mikael
>>> 
>> 
>

Re: RFR(XS): 8217349: Problem list java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java

2019-01-17 Thread Mikael Vidstedt 


Thanks Igor! Pushed.

Cheers,
Mikael

> On Jan 17, 2019, at 2:07 PM, Igor Ignatyev  wrote:
> 
> Mikael,
> 
> looks good and trivial to me.
> 
> -- Igor
> 
>> On Jan 17, 2019, at 2:02 PM, Mikael Vidstedt  
>> wrote:
>> 
>> 
>> Please review this change which adds 
>> java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java to the problem list 
>> until the main bug has been addressed.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8217349 
>> 
>> Webrev: 
>> http://cr.openjdk.java.net/~mikael/webrevs/8217349/webrev.00/open/webrev/ 
>> 
>> Main bug: https://bugs.openjdk.java.net/browse/JDK-8151492 
>> 
>> 
>> Cheers,
>> Mikael
>> 
>

Re: RFR(XS): 8217349: Problem list java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java

2019-01-17 Thread Igor Ignatyev 
Mikael,

looks good and trivial to me.

-- Igor

> On Jan 17, 2019, at 2:02 PM, Mikael Vidstedt  
> wrote:
> 
> 
> Please review this change which adds 
> java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java to the problem list 
> until the main bug has been addressed.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8217349 
> 
> Webrev: 
> http://cr.openjdk.java.net/~mikael/webrevs/8217349/webrev.00/open/webrev/ 
> 
> Main bug: https://bugs.openjdk.java.net/browse/JDK-8151492 
> 
> 
> Cheers,
> Mikael
>