Re: RFR: 8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record [v2]

2020-12-08 Thread Chris Hegarty
On Tue, 8 Dec 2020 16:21:09 GMT, Julia Boes  wrote:

>> This change applies a stricter semantic distinction of 'type' versus 'class 
>> and interface'. This is based on the JLS changes described in the 
>> "Consistent Class and Interface Terminology" document: 
>> https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html.
>> 
>> The following rules were applied:
>> - 'class' and/or 'interface' are used when referring to the class/interface 
>> itself
>> - 'type' is used when referring to the type of a variable or expression
>
> Julia Boes has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   adjust 1 change in Enum.java

Marked as reviewed by chegar (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/1670


Re: RFR: 8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record [v2]

2020-12-08 Thread Daniel Fuchs
On Tue, 8 Dec 2020 16:21:09 GMT, Julia Boes  wrote:

>> This change applies a stricter semantic distinction of 'type' versus 'class 
>> and interface'. This is based on the JLS changes described in the 
>> "Consistent Class and Interface Terminology" document: 
>> https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html.
>> 
>> The following rules were applied:
>> - 'class' and/or 'interface' are used when referring to the class/interface 
>> itself
>> - 'type' is used when referring to the type of a variable or expression
>
> Julia Boes has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   adjust 1 change in Enum.java

Marked as reviewed by dfuchs (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/1670


Re: RFR: 8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record [v2]

2020-12-08 Thread Julia Boes
> This change applies a stricter semantic distinction of 'type' versus 'class 
> and interface'. This is based on the JLS changes described in the "Consistent 
> Class and Interface Terminology" document: 
> https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html.
> 
> The following rules were applied:
> - 'class' and/or 'interface' are used when referring to the class/interface 
> itself
> - 'type' is used when referring to the type of a variable or expression

Julia Boes has updated the pull request incrementally with one additional 
commit since the last revision:

  adjust 1 change in Enum.java

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1670/files
  - new: https://git.openjdk.java.net/jdk/pull/1670/files/6a2a55ea..36b7ceb0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=1670=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=1670=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1670.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1670/head:pull/1670

PR: https://git.openjdk.java.net/jdk/pull/1670